d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d5af6a0417
numam-spdk/mk/spdk.lib.mk

140 lines
4.0 KiB
Makefile
Raw Normal View History

build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
#
# BSD LICENSE
#
# Copyright (c) Intel Corporation.
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Intel Corporation nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
mk: add a lib deps file. By adding this file and modifying the way we define a couple of variables in the makefiles, we can actually avoid having to redefine the library dependencies on a per file basis. Change-Id: Ieab4aa1021b0341fc21e3b65677a9ad7f70559c2 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466063 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
2019-08-22 17:26:08 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.lib_deps.mk
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.modules.mk
test/make: add leaf type changes check to check_so_deps. This is an important aspect of ABI versioning. There was a change to the spdk_bdev_opts struct which is accessible from the public API that results in an ABI change. There was also a change in the spdk_accel_module_if struct that will affect new modules so its major version needs to be revved. There was also a change in the publically accessible rmda_hooks structure which forced an ABI change in the NVMe library. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I5cc6886fe01b4adc2836b6e15995471f0361dc29 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2663 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-05-27 23:57:53 +00:00
make: add a map file for libspdk_accel. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I49f0011d0cdb22ae8830d71b3ba554f85f83892e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1400 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-03-20 21:41:56 +00:00
ifeq ($(SPDK_MAP_FILE),)
make: remove spdk.map. As of now, all of the libraries and modules have their own map file specified. Get rid of the generic top level one and add a test to make sure that these files have been specified. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I329004e7442c7975731fc973455c93e724982952 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2359 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-10 20:31:11 +00:00
$(error SPDK_MAP_FILE is not set for lib $(LIBNAME))
make: add a map file for libspdk_accel. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I49f0011d0cdb22ae8830d71b3ba554f85f83892e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1400 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-03-20 21:41:56 +00:00
endif
mk/lib: add a check that major and minor version is set for libs. Also, while we are here, consolidate setting SO_SUFFIX to one spot. Previously, it was possible for a library to slip through without an SO version. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I4db5fa5839502d266c6259892e5719b05134518c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-05-10 20:40:09 +00:00
ifeq ($(SO_VER),)
$(error SO major version is not set for lib $(LIBNAME))
endif
ifeq ($(SO_MINOR),)
$(error SO minor version is not set for lib $(LIBNAME))
endif
SO_SUFFIX := $(SO_VER).$(SO_MINOR)
mk: add spdk_lib_list_to_shared_libs While here, change spdk_lib_list_to_files to spdk_lib_list_to_static_libs to differentiate it from the new spdk_lib_list_to_shared_libs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6e5913addfbdd556fae2451d4e2b2c43feaf33ab Reviewed-on: https://review.gerrithub.io/429286 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-10-12 21:50:36 +00:00
LIB := $(call spdk_lib_list_to_static_libs,$(LIBNAME))
make: Fix shared lib build Build with shared libraries fails if there is '.a' anywhere in the path to spdk, e.g. '/home/user/dir.auto/spdk'. 'subst' function in spdk.lib.mk is replaced with substitution reference, that alters only suffixes. Signed-off-by: Evgeniy Kochetov <evgeniik@mellanox.com> Change-Id: I5dd06ab95b85d5dd93becff001cef8e78daa0b81 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/669 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-02-09 10:01:12 +00:00
SHARED_LINKED_LIB := $(LIB:.a=.so)
make: rev SO versions individually for libraries. This will allow us to keep track of compatibility issues on a per-library basis. Change-Id: Ib0c796adb1efe1570212a503ed660bef6f142b6e Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1067 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2020-02-28 20:47:11 +00:00
SHARED_REALNAME_LIB := $(SHARED_LINKED_LIB:.so=.so.$(SO_SUFFIX))
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
PKGCONFIG = $(call pkgconfig_filename,spdk_$(LIBNAME))
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
PKGCONFIG_INST = $(call pkgconfig_filename,tmp/spdk_$(LIBNAME))
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
ifeq ($(CONFIG_SHARED),y)
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
DEP := $(SHARED_LINKED_LIB)
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
else
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
DEP := $(LIB)
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
endif
build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
DEP += $(PKGCONFIG) ${PKGCONFIG_INST}
Make: Add deps for each shared obj individually This prevents the SPDK build from requirng unnecessary dependencies when not compiling certain features. Also, fixes github issue #434 Change-Id: I7d0520474f3656ae32670313f2290e6b741c5ca8 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426131 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 19:15:37 +00:00
ifeq ($(OS),FreeBSD)
build: only link rt where needed Only libraries that are using shm_open require linking rt when creating the shared library. Stop including it on every library and just add it to LOCAL_SYS_LIBS in the one case where it is used (spdk_trace). Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ic13128873a76c355b14871a0dea0922488c9cd13 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4370 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2020-09-24 00:12:58 +00:00
LOCAL_SYS_LIBS += -L/usr/local/lib
Make: Add deps for each shared obj individually This prevents the SPDK build from requirng unnecessary dependencies when not compiling certain features. Also, fixes github issue #434 Change-Id: I7d0520474f3656ae32670313f2290e6b741c5ca8 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426131 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 19:15:37 +00:00
endif
mk/lib: Build subdirs before lib dir The subdirectories of libraries are currently listed as dependencies of the library. If you look at the actual symbols they contain, the opposite is true. For all of the bdevs, event subsystems and other library directories, the subdirectories actually rely on symbols contained in the parent directory. If we want to create the proper inter-library dependencies in SPDK at compile/link time, then we need to respect the order of these symbol dependencies when executing make (e.g. make libspdk_event.so before libspdk_event_bdev.so). Otherwise we create a loop of dependencies in the make system. Change-Id: Idcbb050b2709f575d0cec46b481824d6313612b4 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465191 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-08-13 17:43:39 +00:00
define subdirs_rule
$(1): $(2)
@+$(Q)$(MAKE) -C $(1) S=$S$(S:%=/)$@ $(MAKECMDGOALS)
endef
$(foreach dir,$(DIRS-y),$(eval $(call subdirs_rule,$(dir),$(DEP))))
ifneq ($(DIRS-y),)
BUILD_DEP := $(DIRS-y)
else
BUILD_DEP := $(DEP)
endif
build: add SPDK_NO_LIB_DEPS to build libraries w/o dependencies Our check_so_deps.sh test script removes the spdk.lib_deps.mk include from spdk.lib.mk so that we can check which symbols the libraries depend on. But modifying the code like this is a bit kludgy. So instead add a Makefile variable that check_so_deps.sh can set to get the same behavior. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I5622f4c3adb2d5ccd5ae33cb4cd116716134a9b7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4512 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: <dongx.yi@intel.com>
2020-10-02 14:30:10 +00:00
ifeq ($(SPDK_NO_LIB_DEPS),)
mk: add a lib deps file. By adding this file and modifying the way we define a couple of variables in the makefiles, we can actually avoid having to redefine the library dependencies on a per file basis. Change-Id: Ieab4aa1021b0341fc21e3b65677a9ad7f70559c2 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466063 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
2019-08-22 17:26:08 +00:00
SPDK_DEP_LIBS = $(call spdk_lib_list_to_shared_libs,$(DEPDIRS-$(LIBNAME)))
build: add SPDK_NO_LIB_DEPS to build libraries w/o dependencies Our check_so_deps.sh test script removes the spdk.lib_deps.mk include from spdk.lib.mk so that we can check which symbols the libraries depend on. But modifying the code like this is a bit kludgy. So instead add a Makefile variable that check_so_deps.sh can set to get the same behavior. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I5622f4c3adb2d5ccd5ae33cb4cd116716134a9b7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4512 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: <dongx.yi@intel.com>
2020-10-02 14:30:10 +00:00
endif
Make: Add deps for each shared obj individually This prevents the SPDK build from requirng unnecessary dependencies when not compiling certain features. Also, fixes github issue #434 Change-Id: I7d0520474f3656ae32670313f2290e6b741c5ca8 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426131 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 19:15:37 +00:00
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
MODULES-bdev = spdk_bdev_modules
MODULES-sock = spdk_sock_modules
MODULES-accel = spdk_accel_modules
ifeq ($(SPDK_ROOT_DIR)/lib/env_dpdk,$(CONFIG_ENV))
MODULES-event = spdk_env_dpdk_rpc
endif
log: Add a lib for integrating the log lib with event framework. Linking this library into an application makes the log configurable via RPC. This only works if the rpc subsystem is also loaded. Change-Id: If1340cf2a845ef159290232c26f341150c98fb9a Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-07-06 18:08:24 +00:00
.PHONY: all clean $(DIRS-y)
build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
mk/lib: Build subdirs before lib dir The subdirectories of libraries are currently listed as dependencies of the library. If you look at the actual symbols they contain, the opposite is true. For all of the bdevs, event subsystems and other library directories, the subdirectories actually rely on symbols contained in the parent directory. If we want to create the proper inter-library dependencies in SPDK at compile/link time, then we need to respect the order of these symbol dependencies when executing make (e.g. make libspdk_event.so before libspdk_event_bdev.so). Otherwise we create a loop of dependencies in the make system. Change-Id: Idcbb050b2709f575d0cec46b481824d6313612b4 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465191 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-08-13 17:43:39 +00:00
all: $(BUILD_DEP)
build: add dummy @: to some "all" targets This suppresses: make[3]: Nothing to be done for 'all'. when nothing needs to be rebuilt. Still more work will be needed, specifically in examples and apps directories. But this will cover most of lib/ and anything in unit/test that is using the new spdk.unittest.mk. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I1c0c2b88e70ec37629740aa47f612c9d46fc88fb Reviewed-on: https://review.gerrithub.io/399725 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-02-13 15:28:54 +00:00
@:
log: Add a lib for integrating the log lib with event framework. Linking this library into an application makes the log configurable via RPC. This only works if the rpc subsystem is also loaded. Change-Id: If1340cf2a845ef159290232c26f341150c98fb9a Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-07-06 18:08:24 +00:00
clean: $(DIRS-y)
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
$(CLEAN_C) $(LIB) $(SHARED_LINKED_LIB) $(SHARED_REALNAME_LIB)
$(SHARED_LINKED_LIB): $(SHARED_REALNAME_LIB)
$(Q)echo " SYMLINK $(notdir $@)"; $(BUILD_LINKERNAME_LIB)
$(SHARED_REALNAME_LIB): $(LIB)
$(Q)echo " SO $(notdir $@)"; \
build: force shared library dependencies We use some implicit depdendencies in our subsystem libraries. With at least some linkers, these dependencies are not written into the shared library file if there is no actual symbol dependency found. So use --no-as-needed to ensure the dependencies stick. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Idb476efb50b00ff04f5640b4e5a1362a1f096fa7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4796 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: <dongx.yi@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Maciej Wawryk <maciejx.wawryk@intel.com>
2020-10-21 02:17:46 +00:00
$(call spdk_build_realname_shared_lib,$^,$(SPDK_MAP_FILE),$(LOCAL_SYS_LIBS),$(SPDK_DEP_LIBS))
build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
define pkgconfig_create
$(Q)$(SPDK_ROOT_DIR)/scripts/pc.sh $(1) $(LIBNAME) $(SO_SUFFIX) \
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
"$(DEPDIRS-$(LIBNAME):%=spdk_%) $(MODULES-$(LIBNAME))" \
"" > $@
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
endef
$(PKGCONFIG): $(LIB)
$(call pkgconfig_create,$(SPDK_ROOT_DIR)/build)
$(PKGCONFIG_INST): $(LIB)
$(call pkgconfig_create,$(CONFIG_PREFIX))
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
$(LIB): $(OBJS)
$(LIB_C)
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
install: all
$(INSTALL_LIB)
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
@$(call pkgconfig_install,$(PKGCONFIG_INST))
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
ifeq ($(CONFIG_SHARED),y)
$(INSTALL_SHARED_LIB)
endif
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
mk/lib: Build subdirs before lib dir The subdirectories of libraries are currently listed as dependencies of the library. If you look at the actual symbols they contain, the opposite is true. For all of the bdevs, event subsystems and other library directories, the subdirectories actually rely on symbols contained in the parent directory. If we want to create the proper inter-library dependencies in SPDK at compile/link time, then we need to respect the order of these symbol dependencies when executing make (e.g. make libspdk_event.so before libspdk_event_bdev.so). Otherwise we create a loop of dependencies in the make system. Change-Id: Idcbb050b2709f575d0cec46b481824d6313612b4 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465191 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-08-13 17:43:39 +00:00
uninstall: $(DIRS-y)
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
$(UNINSTALL_LIB)
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
@$(call pkgconfig_uninstall,$(PKGCONFIG_INST))
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
ifeq ($(CONFIG_SHARED),y)
$(UNINSTALL_SHARED_LIB)
endif
build: add spdk.lib.mk for common library rules Change-Id: I0547554c010b0eaa6e98c843e7d9eb78c90f76d5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-09 18:14:04 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk
Reference in New Issue Copy Permalink