d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
dc09422cd3
numam-spdk/mk/spdk.app_vars.mk

73 lines
2.9 KiB
Makefile
Raw Normal View History

build: add mk/spdk.app_vars.mk This is a step towards moving a lot of the boilerplate rules in various application Makefiles into mk/spdk.app.mk. We will need to add a mk/spdk.app_cxx.mk for our C++ applications, but that will need to share these same variables. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaee73a4fa47ff2ee54f1a1ea3c0d2097900df218 Reviewed-on: https://review.gerrithub.io/434278 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:11:50 +00:00
#
# BSD LICENSE
#
# Copyright (c) Intel Corporation.
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Intel Corporation nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
build: use DEPDIRS variables to build SPDK_LIB_LIST All of our Makefiles duplicate huge lists of libraries in SPDK_LIB_LIST. We have a very precise and accurate accounting of the library dependencies in mk/spdk.lib_deps.mk which can be used to generate the full list if the app specifies the modules and subsystem libraries it wishes to link. I did a first pass through all of the existing Makefiles to take advantage of this new functionality. There may be more optimizations we can make later but don't want to hold up this patch for all of them. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Icdaf6f749a6908df2c2ce2db22631a4af4ff3a9e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5553 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-12-11 20:41:37 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.lib_deps.mk
# _uniq returns the unique elements from the list specified. It does
# not change the order of the elements. If the same element occurs
# multiple times in the list, the last instance is kept and the others
# removed.
# Example: _uniq(conf log json log util util log util) = conf json log util
define _uniq
$(if $1,$(call _uniq,$(filter-out $(lastword $1),$1)) $(lastword $1))
endef
define _deplibs
$(if $1,$(foreach d,$1,$(d) $(call _deplibs,$(DEPDIRS-$(d)))))
endef
define deplibs
$(call _uniq,$(call _deplibs,$1))
endef
SPDK_DEPLIB_LIST += $(call deplibs,$(SPDK_LIB_LIST))
SPDK_LIB_FILES = $(call spdk_lib_list_to_static_libs,$(SPDK_DEPLIB_LIST))
build: add mk/spdk.app_vars.mk This is a step towards moving a lot of the boilerplate rules in various application Makefiles into mk/spdk.app.mk. We will need to add a mk/spdk.app_cxx.mk for our C++ applications, but that will need to share these same variables. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaee73a4fa47ff2ee54f1a1ea3c0d2097900df218 Reviewed-on: https://review.gerrithub.io/434278 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:11:50 +00:00
SPDK_LIB_LINKER_ARGS = \
-L$(SPDK_ROOT_DIR)/build/lib \
-Wl,--whole-archive \
mk: force --no-as-needed for spdk libs. When building shared libs, we specifically don't set the --as-needed flag so that we still link against libraries that have constructor functions. LD reports on its man page that the default behavior is equivalent to --no-as-needed. For RHEL based distros like fedora and centos this works fine. While the LD man page shipped with ubuntu distributions also states that --no-as-needed is the default, they don't respect that behavior and do --as-needed linking unless you force them with --no-as-needed. Change-Id: I914ab849323de198af5c5e53fffb1f57fcaff5fe Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464621 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-08-09 00:46:56 +00:00
-Wl,--no-as-needed \
build: use DEPDIRS variables to build SPDK_LIB_LIST All of our Makefiles duplicate huge lists of libraries in SPDK_LIB_LIST. We have a very precise and accurate accounting of the library dependencies in mk/spdk.lib_deps.mk which can be used to generate the full list if the app specifies the modules and subsystem libraries it wishes to link. I did a first pass through all of the existing Makefiles to take advantage of this new functionality. There may be more optimizations we can make later but don't want to hold up this patch for all of them. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Icdaf6f749a6908df2c2ce2db22631a4af4ff3a9e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5553 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-12-11 20:41:37 +00:00
$(SPDK_DEPLIB_LIST:%=-lspdk_%) \
build: add mk/spdk.app_vars.mk This is a step towards moving a lot of the boilerplate rules in various application Makefiles into mk/spdk.app.mk. We will need to add a mk/spdk.app_cxx.mk for our C++ applications, but that will need to share these same variables. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaee73a4fa47ff2ee54f1a1ea3c0d2097900df218 Reviewed-on: https://review.gerrithub.io/434278 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:11:50 +00:00
-Wl,--no-whole-archive
# This is primarily used for unit tests to ensure they link when shared library
# build is enabled. Shared libraries can't get their mock implementation from
# the unit test file. Note that even for unittests, we must include the mock
# library with whole-archive, to keep its functions from getting stripped out
# when LTO is enabled.
SPDK_STATIC_LIB_LINKER_ARGS = \
$(SPDK_LIB_LIST:%=$(SPDK_ROOT_DIR)/build/lib/libspdk_%.a) \
-Wl,--whole-archive \
$(SPDK_ROOT_DIR)/build/lib/libspdk_ut_mock.a \
-Wl,--no-whole-archive
Reference in New Issue Copy Permalink