d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
eecc6dc8e6
numam-spdk/mk/spdk.unittest.mk

65 lines
2.1 KiB
Makefile
Raw Normal View History

SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
#
# BSD LICENSE
#
Remove year from copyright headers. Also add a space between Copyright and (c). The copyright year can be determined using git metadata. Also remove the duplicated "All rights reserved." - every instance of this line already has a corresponding "All rights reserved" immediately below it, except for examples/ioat/kperf/kmod/dma_perf.c, where I have added it manually. Performed using this command: git ls-files | xargs sed -i -e 's/Copyright(c) \(.*\) Intel Corporation. All rights reserved./Copyright (c) Intel Corporation./' Change-Id: I3779f404966800709024eb1eb66a50068af2716c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-01-26 17:47:22 +00:00
# Copyright (c) Intel Corporation.
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Intel Corporation nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
nvme/test: build unit tests using common CFLAGS Inherit the CFLAGS and other common setup from spdk.common.mk instead of redefining it in nvme.unittest.mk. In particular, this enables warnings for the unit test code that were not enabled before. Change-Id: Id0fbf0ee0b0d63f9de0c362d1d23e2bd036a7145 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-24 17:01:22 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
build: move app rules to spdk.app.mk This removes a ton of duplicate from a lot of Makefiles. Note that spdk.unittest.mk still keeps its own app rules, and now just includes spdk.app_vars.mk instead. Fixing Makefiles that include this .mk file requires more work that is deferred for now. We do need to add the "install: all" rule explicitly to this .mk files. Note that Makefiles need to include spdk.app.mk now at the end of the file, so that things like APP and SPDK_LIB_LIST are defined before including it. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: If6823cda135180c37690ffc96c91660b7f0718e3 Reviewed-on: https://review.gerrithub.io/434283 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:03:15 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.app_vars.mk
test: add one unit test showing example of ut_mock wrap This patch shows how to use the spdk_mock library which now only consists of --wrap capability for a few functions. Next will be a patch that provides a generic mock capability to use either the --wrap feature or a combination of globals and stubs to make adding more UT easier wrt mocking. After that is in place nvme_ut.c will be updated to use the new library for all mocking. Change-Id: I1a6ffb722da043bb70bd4cfe1afa7c5e39a0fccb Signed-off-by: Paul Luse <paul.e.luse@intel.com> Reviewed-on: https://review.gerrithub.io/365074 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-06-12 21:31:50 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.mock.unittest.mk
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
test: remove explicit build rule from nvme/nvmf mk file These aren't needed - the common %.o rule is sufficient. As part of this patch, remove OTHER_FILES references from nvme and nvmf unit tests, and just include these .c files directly. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I76ab20da2f560c7997e978fcbfe28c2a4907f759 Reviewed-on: https://review.gerrithub.io/399715 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-13 15:11:12 +00:00
C_SRCS = $(TEST_FILE)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
nvme: Eliminate nvme_impl.h and use the swappable env lib. Change-Id: Ibbc557b732d5b0858a2922a7a442c4b17a0d579a Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-12 17:24:34 +00:00
CFLAGS += -I$(SPDK_ROOT_DIR)/lib
nvme/utest: add SPDK_CU_ASSERT_FATAL wrapper The normal CU_ASSERT_FATAL macro calls a function that is not marked as noreturn, so static analyzers (e.g. scan-buid) can't figure out that fatal asserts are really fatal. Add a wrapper macro that calls abort(), which the analyzer can determine does not return. Change-Id: I0c087bf9c8d3c272bf88120caa70e87dab6d9546 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-01-07 20:17:15 +00:00
CFLAGS += -I$(SPDK_ROOT_DIR)/test
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
build: link all static libs with --whole-archive SPDK uses constructor functions for registration functionality in several different areas - RPCs, bdev modules, event tracing, etc. Since these functions are not explicitly referenced, the linker will remove these constructor functions from the linked application unless their library is included using the --whole-archive linker option. SPDK has tried to minimize the number of libraries linked with --whole-archive to only those that are necessary. But there are still a lot of exceptions that we need to work around. The benefit to trying to restrict it is minimal - for example, an nvmf_tgt binary built before this patch is 4746320 bytes on my system, but linking all of the libraries with --whole-archive only increases it to 4784080 bytes - a difference of less than 1%. Note that DPDK also links all libraries with --whole-archive by default. This will also simplify some upcoming changes around shared library dependencies - we will be able to blindly use --whole-archive when linking the shared library as well. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iab0dbbace06a3d15c835491e55683ab4cf9e53f0 Reviewed-on: https://review.gerrithub.io/434107 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-20 14:24:15 +00:00
SPDK_LIB_LIST += thread util log sock
nvme: Use log library instead of nvme_printf Change-Id: Ic9b2db9bff3a914b3e5021695287157f1e076f9f Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-12 16:03:40 +00:00
build: explicitly link unit tests with static libraries Unit tests define mock functions in the unit test code itself. This links fine with static libraries, but doesn't work if trying to link with shared libraries. So change the unit tests to always explicitly link with the static libraries. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I3a8a60162fcab6c73a216c4bb364175767fdc62c Reviewed-on: https://review.gerrithub.io/422441 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-08-15 16:32:03 +00:00
LIBS += -lcunit $(SPDK_STATIC_LIB_LINKER_ARGS)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
build: use $(APP) target consistently Replace $(UT_APP) in nvme.unittest.mk with $(APP); there is no actual difference in the way they are used. Change-Id: I039c2488ee998ee8b1a67af129045b66a97bc29c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 23:10:03 +00:00
APP = $(TEST_FILE:.c=)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
build: add ENV_LINKER_ARGS to LINK_C and LINK_CXX This allows us to remove $(ENV_LINKER_ARGS) from all of the application Makefiles. Modify spdk.unittest.mk to explicitly set ENV_LINKER_ARGS to nothing, to avoid DPDK libraries from getting linked into unit tests. This seems better than creating separate LINK_C rules for unit tests. Provide a UNIT_TEST_LINK_ENV flag to allow select unit tests to override this behavior - it's needed for some of the env unit tests. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I647f2c848cf434023cf5a1f3a45869bbc4fc8102 Reviewed-on: https://review.gerrithub.io/434145 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-20 16:59:47 +00:00
ifneq ($(UNIT_TEST_LINK_ENV),1)
ENV_LINKER_ARGS =
endif
build: move app rules to spdk.app.mk This removes a ton of duplicate from a lot of Makefiles. Note that spdk.unittest.mk still keeps its own app rules, and now just includes spdk.app_vars.mk instead. Fixing Makefiles that include this .mk file requires more work that is deferred for now. We do need to add the "install: all" rule explicitly to this .mk files. Note that Makefiles need to include spdk.app.mk now at the end of the file, so that things like APP and SPDK_LIB_LIST are defined before including it. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: If6823cda135180c37690ffc96c91660b7f0718e3 Reviewed-on: https://review.gerrithub.io/434283 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:03:15 +00:00
install: all
build: use $(APP) target consistently Replace $(UT_APP) in nvme.unittest.mk with $(APP); there is no actual difference in the way they are used. Change-Id: I039c2488ee998ee8b1a67af129045b66a97bc29c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 23:10:03 +00:00
all: $(APP)
build: add dummy @: to some "all" targets This suppresses: make[3]: Nothing to be done for 'all'. when nothing needs to be rebuilt. Still more work will be needed, specifically in examples and apps directories. But this will cover most of lib/ and anything in unit/test that is using the new spdk.unittest.mk. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I1c0c2b88e70ec37629740aa47f612c9d46fc88fb Reviewed-on: https://review.gerrithub.io/399725 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-02-13 15:28:54 +00:00
@:
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
build: remove ADDITIONAL_LIBS This can just be replaced with ENV_LIBS - similar to other application Makefiles. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Icad14e6f74264389972c7798aac493e584f7c8c3 Reviewed-on: https://review.gerrithub.io/434280 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-11-20 22:24:09 +00:00
$(APP) : $(OBJS) $(SPDK_LIB_FILES) $(ENV_LIBS)
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
$(LINK_C)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
clean:
build: define a common Makefile clean command Use $(CLEAN_C) throughout the Makefiles to clean up a consistent set of generated files. This also adds coverage files to the list of cleaned files. Change-Id: Iceb922935a45c9eecbf2f3443bd0ee4f5c966825 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-12-07 22:14:36 +00:00
$(CLEAN_C) $(APP)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
Fix header file dependencies. Move dependency includes into a new spdk.deps.mk file, then include it at the end of Makefiles that build source files. Also add a test to autobuild.sh to confirm that binaries are regenerated if we make after touching a header file. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: If6a1905706a840f92cbdf3ace7fbdb27fe2de213
2015-09-25 20:29:39 +00:00
include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk
Reference in New Issue Copy Permalink