2019-02-23 11:59:34 +00:00
|
|
|
/*-
|
|
|
|
* BSD LICENSE
|
|
|
|
*
|
|
|
|
* Copyright (c) Intel Corporation.
|
|
|
|
* All rights reserved.
|
2021-11-15 08:01:14 +00:00
|
|
|
* Copyright (c) 2021 Mellanox Technologies LTD. All rights reserved.
|
2019-02-23 11:59:34 +00:00
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
*
|
|
|
|
* * Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in
|
|
|
|
* the documentation and/or other materials provided with the
|
|
|
|
* distribution.
|
|
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
|
|
* contributors may be used to endorse or promote products derived
|
|
|
|
* from this software without specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
|
|
|
|
#include "spdk/env.h"
|
|
|
|
#include "spdk/likely.h"
|
|
|
|
#include "spdk/string.h"
|
|
|
|
#include "spdk/util.h"
|
2020-02-27 13:38:02 +00:00
|
|
|
#include "spdk/memory.h"
|
2019-02-23 11:59:34 +00:00
|
|
|
#include "spdk/barrier.h"
|
|
|
|
#include "spdk/vhost.h"
|
|
|
|
#include "vhost_internal.h"
|
2021-02-09 07:17:24 +00:00
|
|
|
#include <rte_version.h>
|
2019-02-23 11:59:34 +00:00
|
|
|
|
|
|
|
#include "spdk_internal/vhost_user.h"
|
2019-10-03 15:25:29 +00:00
|
|
|
|
2021-12-08 10:47:32 +00:00
|
|
|
char g_vhost_user_dev_dirname[PATH_MAX] = "";
|
2022-01-12 13:10:09 +00:00
|
|
|
sem_t g_dpdk_sem;
|
|
|
|
|
|
|
|
static void __attribute__((constructor))
|
|
|
|
_vhost_user_sem_init(void)
|
|
|
|
{
|
|
|
|
if (sem_init(&g_dpdk_sem, 0, 0) != 0) {
|
|
|
|
SPDK_ERRLOG("Failed to initialize semaphore for rte_vhost pthread.\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __attribute__((destructor))
|
|
|
|
_vhost_user_sem_destroy(void)
|
|
|
|
{
|
|
|
|
sem_destroy(&g_dpdk_sem);
|
|
|
|
}
|
2021-12-08 10:47:32 +00:00
|
|
|
|
2019-12-25 14:45:04 +00:00
|
|
|
static inline void
|
|
|
|
vhost_session_mem_region_calc(uint64_t *previous_start, uint64_t *start, uint64_t *end,
|
|
|
|
uint64_t *len, struct rte_vhost_mem_region *region)
|
|
|
|
{
|
|
|
|
*start = FLOOR_2MB(region->mmap_addr);
|
|
|
|
*end = CEIL_2MB(region->mmap_addr + region->mmap_size);
|
|
|
|
if (*start == *previous_start) {
|
|
|
|
*start += (size_t) VALUE_2MB;
|
|
|
|
}
|
|
|
|
*previous_start = *start;
|
|
|
|
*len = *end - *start;
|
|
|
|
}
|
|
|
|
|
2019-10-03 15:25:29 +00:00
|
|
|
void
|
|
|
|
vhost_session_mem_register(struct rte_vhost_memory *mem)
|
|
|
|
{
|
2019-12-25 14:45:04 +00:00
|
|
|
uint64_t start, end, len;
|
2019-10-03 15:25:29 +00:00
|
|
|
uint32_t i;
|
|
|
|
uint64_t previous_start = UINT64_MAX;
|
|
|
|
|
2019-12-25 14:45:04 +00:00
|
|
|
|
2019-10-03 15:25:29 +00:00
|
|
|
for (i = 0; i < mem->nregions; i++) {
|
2019-12-25 14:45:04 +00:00
|
|
|
vhost_session_mem_region_calc(&previous_start, &start, &end, &len, &mem->regions[i]);
|
2020-09-04 11:27:29 +00:00
|
|
|
SPDK_INFOLOG(vhost, "Registering VM memory for vtophys translation - 0x%jx len:0x%jx\n",
|
2019-10-03 15:25:29 +00:00
|
|
|
start, len);
|
|
|
|
|
|
|
|
if (spdk_mem_register((void *)start, len) != 0) {
|
|
|
|
SPDK_WARNLOG("Failed to register memory region %"PRIu32". Future vtophys translation might fail.\n",
|
|
|
|
i);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
vhost_session_mem_unregister(struct rte_vhost_memory *mem)
|
|
|
|
{
|
2019-12-25 14:45:04 +00:00
|
|
|
uint64_t start, end, len;
|
2019-10-03 15:25:29 +00:00
|
|
|
uint32_t i;
|
|
|
|
uint64_t previous_start = UINT64_MAX;
|
|
|
|
|
|
|
|
for (i = 0; i < mem->nregions; i++) {
|
2019-12-25 14:45:04 +00:00
|
|
|
vhost_session_mem_region_calc(&previous_start, &start, &end, &len, &mem->regions[i]);
|
2019-10-03 15:25:29 +00:00
|
|
|
if (spdk_vtophys((void *) start, NULL) == SPDK_VTOPHYS_ERROR) {
|
|
|
|
continue; /* region has not been registered */
|
|
|
|
}
|
|
|
|
|
|
|
|
if (spdk_mem_unregister((void *)start, len) != 0) {
|
|
|
|
assert(false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-02-23 11:59:34 +00:00
|
|
|
|
2022-01-12 14:25:38 +00:00
|
|
|
int
|
|
|
|
_stop_session(struct spdk_vhost_session *vsession)
|
|
|
|
{
|
|
|
|
struct spdk_vhost_dev *vdev = vsession->vdev;
|
|
|
|
struct spdk_vhost_virtqueue *q;
|
|
|
|
int rc;
|
|
|
|
uint16_t i;
|
|
|
|
|
|
|
|
rc = vdev->backend->stop_session(vsession);
|
|
|
|
if (rc != 0) {
|
|
|
|
SPDK_ERRLOG("Couldn't stop device with vid %d.\n", vsession->vid);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < vsession->max_queues; i++) {
|
|
|
|
q = &vsession->virtqueue[i];
|
|
|
|
|
|
|
|
/* vring.desc and vring.desc_packed are in a union struct
|
|
|
|
* so q->vring.desc can replace q->vring.desc_packed.
|
|
|
|
*/
|
|
|
|
if (q->vring.desc == NULL) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Packed virtqueues support up to 2^15 entries each
|
|
|
|
* so left one bit can be used as wrap counter.
|
|
|
|
*/
|
|
|
|
if (q->packed.packed_ring) {
|
|
|
|
q->last_avail_idx = q->last_avail_idx |
|
|
|
|
((uint16_t)q->packed.avail_phase << 15);
|
|
|
|
q->last_used_idx = q->last_used_idx |
|
|
|
|
((uint16_t)q->packed.used_phase << 15);
|
|
|
|
}
|
|
|
|
|
|
|
|
rte_vhost_set_vring_base(vsession->vid, i, q->last_avail_idx, q->last_used_idx);
|
|
|
|
}
|
|
|
|
|
|
|
|
vhost_session_mem_unregister(vsession->mem);
|
|
|
|
free(vsession->mem);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-09-27 14:13:04 +00:00
|
|
|
static int
|
|
|
|
new_connection(int vid)
|
|
|
|
{
|
|
|
|
char ifname[PATH_MAX];
|
|
|
|
|
|
|
|
if (rte_vhost_get_ifname(vid, ifname, PATH_MAX) < 0) {
|
|
|
|
SPDK_ERRLOG("Couldn't get a valid ifname for device with vid %d\n", vid);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return vhost_new_connection_cb(vid, ifname);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
start_device(int vid)
|
|
|
|
{
|
|
|
|
return vhost_start_device_cb(vid);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
stop_device(int vid)
|
|
|
|
{
|
|
|
|
vhost_stop_device_cb(vid);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
destroy_connection(int vid)
|
|
|
|
{
|
|
|
|
vhost_destroy_connection_cb(vid);
|
|
|
|
}
|
|
|
|
|
2021-11-15 08:01:14 +00:00
|
|
|
#if RTE_VERSION >= RTE_VERSION_NUM(21, 11, 0, 0)
|
|
|
|
static const struct rte_vhost_device_ops g_spdk_vhost_ops = {
|
|
|
|
#else
|
2019-12-10 04:41:55 +00:00
|
|
|
static const struct vhost_device_ops g_spdk_vhost_ops = {
|
2021-11-15 08:01:14 +00:00
|
|
|
#endif
|
2019-09-27 14:13:04 +00:00
|
|
|
.new_device = start_device,
|
|
|
|
.destroy_device = stop_device,
|
|
|
|
.new_connection = new_connection,
|
|
|
|
.destroy_connection = destroy_connection,
|
|
|
|
};
|
2019-02-23 11:59:34 +00:00
|
|
|
|
|
|
|
static enum rte_vhost_msg_result
|
2020-05-10 01:14:04 +00:00
|
|
|
extern_vhost_pre_msg_handler(int vid, void *_msg)
|
2019-02-23 11:59:34 +00:00
|
|
|
{
|
|
|
|
struct vhost_user_msg *msg = _msg;
|
|
|
|
struct spdk_vhost_session *vsession;
|
|
|
|
|
2019-07-20 21:06:19 +00:00
|
|
|
vsession = vhost_session_find_by_vid(vid);
|
2019-02-23 11:59:34 +00:00
|
|
|
if (vsession == NULL) {
|
|
|
|
SPDK_ERRLOG("Received a message to unitialized session (vid %d).\n", vid);
|
|
|
|
assert(false);
|
|
|
|
return RTE_VHOST_MSG_RESULT_ERR;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (msg->request) {
|
2019-03-04 22:44:43 +00:00
|
|
|
case VHOST_USER_GET_VRING_BASE:
|
2019-04-29 07:26:10 +00:00
|
|
|
if (vsession->forced_polling && vsession->started) {
|
2019-03-04 22:44:43 +00:00
|
|
|
/* Our queue is stopped for whatever reason, but we may still
|
|
|
|
* need to poll it after it's initialized again.
|
|
|
|
*/
|
|
|
|
g_spdk_vhost_ops.destroy_device(vid);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VHOST_USER_SET_VRING_BASE:
|
|
|
|
case VHOST_USER_SET_VRING_ADDR:
|
|
|
|
case VHOST_USER_SET_VRING_NUM:
|
2019-04-29 07:26:10 +00:00
|
|
|
if (vsession->forced_polling && vsession->started) {
|
2019-03-04 22:44:43 +00:00
|
|
|
/* Additional queues are being initialized, so we either processed
|
|
|
|
* enough I/Os and are switching from SeaBIOS to the OS now, or
|
|
|
|
* we were never in SeaBIOS in the first place. Either way, we
|
|
|
|
* don't need our workaround anymore.
|
|
|
|
*/
|
|
|
|
g_spdk_vhost_ops.destroy_device(vid);
|
|
|
|
vsession->forced_polling = false;
|
|
|
|
}
|
|
|
|
break;
|
2020-09-02 05:43:45 +00:00
|
|
|
case VHOST_USER_SET_VRING_KICK:
|
|
|
|
/* rte_vhost(after 20.08) will call new_device after one active vring is
|
|
|
|
* configured, we will start the session before all vrings are available,
|
|
|
|
* so for each new vring, if the session is started, we need to restart it
|
|
|
|
* again.
|
|
|
|
*/
|
2019-03-11 08:12:57 +00:00
|
|
|
case VHOST_USER_SET_VRING_CALL:
|
|
|
|
/* rte_vhost will close the previous callfd and won't notify
|
|
|
|
* us about any change. This will effectively make SPDK fail
|
|
|
|
* to deliver any subsequent interrupts until a session is
|
|
|
|
* restarted. We stop the session here before closing the previous
|
|
|
|
* fd (so that all interrupts must have been delivered by the
|
|
|
|
* time the descriptor is closed) and start right after (which
|
|
|
|
* will make SPDK retrieve the latest, up-to-date callfd from
|
|
|
|
* rte_vhost.
|
|
|
|
*/
|
2019-02-23 11:59:34 +00:00
|
|
|
case VHOST_USER_SET_MEM_TABLE:
|
|
|
|
/* rte_vhost will unmap previous memory that SPDK may still
|
|
|
|
* have pending DMA operations on. We can't let that happen,
|
|
|
|
* so stop the device before letting rte_vhost unmap anything.
|
|
|
|
* This will block until all pending I/Os are finished.
|
|
|
|
* We will start the device again from the post-processing
|
|
|
|
* message handler.
|
|
|
|
*/
|
2019-04-29 07:26:10 +00:00
|
|
|
if (vsession->started) {
|
2019-02-23 11:59:34 +00:00
|
|
|
g_spdk_vhost_ops.destroy_device(vid);
|
|
|
|
vsession->needs_restart = true;
|
|
|
|
}
|
|
|
|
break;
|
2019-03-04 21:34:44 +00:00
|
|
|
case VHOST_USER_GET_CONFIG: {
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
spdk_vhost_lock();
|
|
|
|
if (vsession->vdev->backend->vhost_get_config) {
|
|
|
|
rc = vsession->vdev->backend->vhost_get_config(vsession->vdev,
|
2019-06-11 07:43:38 +00:00
|
|
|
msg->payload.cfg.region, msg->payload.cfg.size);
|
2019-03-04 21:34:44 +00:00
|
|
|
if (rc != 0) {
|
|
|
|
msg->size = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spdk_vhost_unlock();
|
|
|
|
|
|
|
|
return RTE_VHOST_MSG_RESULT_REPLY;
|
|
|
|
}
|
|
|
|
case VHOST_USER_SET_CONFIG: {
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
spdk_vhost_lock();
|
|
|
|
if (vsession->vdev->backend->vhost_set_config) {
|
|
|
|
rc = vsession->vdev->backend->vhost_set_config(vsession->vdev,
|
2019-06-11 07:43:38 +00:00
|
|
|
msg->payload.cfg.region, msg->payload.cfg.offset,
|
|
|
|
msg->payload.cfg.size, msg->payload.cfg.flags);
|
2019-03-04 21:34:44 +00:00
|
|
|
}
|
|
|
|
spdk_vhost_unlock();
|
|
|
|
|
|
|
|
return rc == 0 ? RTE_VHOST_MSG_RESULT_OK : RTE_VHOST_MSG_RESULT_ERR;
|
|
|
|
}
|
2019-02-23 11:59:34 +00:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return RTE_VHOST_MSG_RESULT_NOT_HANDLED;
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum rte_vhost_msg_result
|
2020-05-10 01:14:04 +00:00
|
|
|
extern_vhost_post_msg_handler(int vid, void *_msg)
|
2019-02-23 11:59:34 +00:00
|
|
|
{
|
2019-03-04 22:44:43 +00:00
|
|
|
struct vhost_user_msg *msg = _msg;
|
2019-02-23 11:59:34 +00:00
|
|
|
struct spdk_vhost_session *vsession;
|
|
|
|
|
2019-07-20 21:06:19 +00:00
|
|
|
vsession = vhost_session_find_by_vid(vid);
|
2019-02-23 11:59:34 +00:00
|
|
|
if (vsession == NULL) {
|
|
|
|
SPDK_ERRLOG("Received a message to unitialized session (vid %d).\n", vid);
|
|
|
|
assert(false);
|
|
|
|
return RTE_VHOST_MSG_RESULT_ERR;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (vsession->needs_restart) {
|
|
|
|
g_spdk_vhost_ops.new_device(vid);
|
|
|
|
vsession->needs_restart = false;
|
2019-03-04 22:44:43 +00:00
|
|
|
return RTE_VHOST_MSG_RESULT_NOT_HANDLED;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (msg->request) {
|
|
|
|
case VHOST_USER_SET_FEATURES:
|
|
|
|
/* rte_vhost requires all queues to be fully initialized in order
|
|
|
|
* to start I/O processing. This behavior is not compliant with the
|
|
|
|
* vhost-user specification and doesn't work with QEMU 2.12+, which
|
|
|
|
* will only initialize 1 I/O queue for the SeaBIOS boot.
|
|
|
|
* Theoretically, we should start polling each virtqueue individually
|
|
|
|
* after receiving its SET_VRING_KICK message, but rte_vhost is not
|
|
|
|
* designed to poll individual queues. So here we use a workaround
|
|
|
|
* to detect when the vhost session could be potentially at that SeaBIOS
|
|
|
|
* stage and we mark it to start polling as soon as its first virtqueue
|
|
|
|
* gets initialized. This doesn't hurt any non-QEMU vhost slaves
|
|
|
|
* and allows QEMU 2.12+ to boot correctly. SET_FEATURES could be sent
|
|
|
|
* at any time, but QEMU will send it at least once on SeaBIOS
|
|
|
|
* initialization - whenever powered-up or rebooted.
|
|
|
|
*/
|
|
|
|
vsession->forced_polling = true;
|
|
|
|
break;
|
|
|
|
case VHOST_USER_SET_VRING_KICK:
|
|
|
|
/* vhost-user spec tells us to start polling a queue after receiving
|
|
|
|
* its SET_VRING_KICK message. Let's do it!
|
|
|
|
*/
|
2019-04-29 07:26:10 +00:00
|
|
|
if (vsession->forced_polling && !vsession->started) {
|
2019-03-04 22:44:43 +00:00
|
|
|
g_spdk_vhost_ops.new_device(vid);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
2019-02-23 11:59:34 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return RTE_VHOST_MSG_RESULT_NOT_HANDLED;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct rte_vhost_user_extern_ops g_spdk_extern_vhost_ops = {
|
2020-05-10 01:14:04 +00:00
|
|
|
.pre_msg_handle = extern_vhost_pre_msg_handler,
|
|
|
|
.post_msg_handle = extern_vhost_post_msg_handler,
|
2019-02-23 11:59:34 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
void
|
2019-07-20 21:06:19 +00:00
|
|
|
vhost_session_install_rte_compat_hooks(struct spdk_vhost_session *vsession)
|
2019-02-23 11:59:34 +00:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = rte_vhost_extern_callback_register(vsession->vid, &g_spdk_extern_vhost_ops, NULL);
|
|
|
|
if (rc != 0) {
|
|
|
|
SPDK_ERRLOG("rte_vhost_extern_callback_register() failed for vid = %d\n",
|
|
|
|
vsession->vid);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-08-09 01:32:06 +00:00
|
|
|
int
|
|
|
|
vhost_register_unix_socket(const char *path, const char *ctrl_name,
|
2019-12-25 10:01:18 +00:00
|
|
|
uint64_t virtio_features, uint64_t disabled_features, uint64_t protocol_features)
|
2019-03-04 21:34:44 +00:00
|
|
|
{
|
2019-08-09 01:32:06 +00:00
|
|
|
struct stat file_stat;
|
2019-12-25 10:01:18 +00:00
|
|
|
uint64_t features = 0;
|
2019-08-09 01:32:06 +00:00
|
|
|
|
|
|
|
/* Register vhost driver to handle vhost messages. */
|
|
|
|
if (stat(path, &file_stat) != -1) {
|
|
|
|
if (!S_ISSOCK(file_stat.st_mode)) {
|
|
|
|
SPDK_ERRLOG("Cannot create a domain socket at path \"%s\": "
|
|
|
|
"The file already exists and is not a socket.\n",
|
|
|
|
path);
|
|
|
|
return -EIO;
|
|
|
|
} else if (unlink(path) != 0) {
|
|
|
|
SPDK_ERRLOG("Cannot create a domain socket at path \"%s\": "
|
|
|
|
"The socket already exists and failed to unlink.\n",
|
|
|
|
path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-02-09 07:17:24 +00:00
|
|
|
#if RTE_VERSION < RTE_VERSION_NUM(20, 8, 0, 0)
|
|
|
|
if (rte_vhost_driver_register(path, 0) != 0) {
|
|
|
|
#else
|
vhost/compat: add RTE_VHOST_USER_ASYNC_COPY flag when used IOVA_PA mode
Recently, we discovered that under the SPDK + UIO mode, it is possible that vm may be wrong when doing io.
such as:
[root@VM_6_151_centos ~]# mkfs.xfs /dev/vdc
meta-data=/dev/vdc isize=512 agcount=4, agsize=234421142 blks
= sectsz=4096 attr=2, projid32bit=1
= crc=1 finobt=0, sparse=0
data = bsize=4096 blocks=937684566, imaxpct=5
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0 ftype=1
log =internal log bsize=4096 blocks=457853, version=2
= sectsz=4096 sunit=1 blks, lazy-count=1
realtime =none extsz=4096 blocks=0, rtextents=0
bad magic number
bad magic number
Metadata corruption detected at xfs_sb block 0x0/0x1000
libxfs_writebufr: write verifer failed on xfs_sb bno 0x0/0x1000
the github issue link: https://github.com/spdk/spdk/issues/1738
After investigation, we found as below:
The qemu set to VHOST_USER_SET_MEM_TABLE then call vhost_user_set_mem_table(dpdk version spdk-20.11)->mmap(without MAP_POPULATE)
the mmap will only return the virtual address not map the virtual address to the physical address actually.
after call vtophys_notify->vtophys_get_paddr_pagemap, we will get a wrong physical(the virtual address we not access)
So this patch is to set MAP_POPULATE during we use SPDK + UIO.
Signed-off-by: andypma <andypma@tencent.com>
Reviewed-by: Zhigang Lu <tonnylu@tencent.com>
Reviewed-by: Xun Ni <richardni@tencent.com>
Reviewed-by: YuZhoujian <windyu@tencent.com>
Reviewed-by: LuWeiKang <luweikang@tencent.com>
Change-Id: Ib921b6d7381f46bb5894ed787cef52e02524197a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5970
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2021-01-15 09:16:30 +00:00
|
|
|
if (rte_vhost_driver_register(path, RTE_VHOST_USER_ASYNC_COPY) != 0) {
|
2021-02-09 07:17:24 +00:00
|
|
|
#endif
|
2019-08-09 01:32:06 +00:00
|
|
|
SPDK_ERRLOG("Could not register controller %s with vhost library\n", ctrl_name);
|
|
|
|
SPDK_ERRLOG("Check if domain socket %s already exists\n", path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
if (rte_vhost_driver_set_features(path, virtio_features) ||
|
|
|
|
rte_vhost_driver_disable_features(path, disabled_features)) {
|
|
|
|
SPDK_ERRLOG("Couldn't set vhost features for controller %s\n", ctrl_name);
|
|
|
|
|
|
|
|
rte_vhost_driver_unregister(path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rte_vhost_driver_callback_register(path, &g_spdk_vhost_ops) != 0) {
|
|
|
|
rte_vhost_driver_unregister(path);
|
|
|
|
SPDK_ERRLOG("Couldn't register callbacks for controller %s\n", ctrl_name);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
2019-12-25 10:01:18 +00:00
|
|
|
rte_vhost_driver_get_protocol_features(path, &features);
|
|
|
|
features |= protocol_features;
|
|
|
|
rte_vhost_driver_set_protocol_features(path, features);
|
2019-08-09 01:32:06 +00:00
|
|
|
|
|
|
|
if (rte_vhost_driver_start(path) != 0) {
|
|
|
|
SPDK_ERRLOG("Failed to start vhost driver for controller %s (%d): %s\n",
|
|
|
|
ctrl_name, errno, spdk_strerror(errno));
|
|
|
|
rte_vhost_driver_unregister(path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2019-10-03 16:36:30 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
vhost_get_mem_table(int vid, struct rte_vhost_memory **mem)
|
|
|
|
{
|
|
|
|
return rte_vhost_get_mem_table(vid, mem);
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_driver_unregister(const char *path)
|
|
|
|
{
|
|
|
|
return rte_vhost_driver_unregister(path);
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_get_negotiated_features(int vid, uint64_t *negotiated_features)
|
|
|
|
{
|
|
|
|
return rte_vhost_get_negotiated_features(vid, negotiated_features);
|
|
|
|
}
|
2021-12-08 12:27:42 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
vhost_user_dev_set_coalescing(struct spdk_vhost_dev *vdev, uint32_t delay_base_us,
|
|
|
|
uint32_t iops_threshold)
|
|
|
|
{
|
|
|
|
uint64_t delay_time_base = delay_base_us * spdk_get_ticks_hz() / 1000000ULL;
|
|
|
|
uint32_t io_rate = iops_threshold * SPDK_VHOST_STATS_CHECK_INTERVAL_MS / 1000U;
|
|
|
|
|
|
|
|
if (delay_time_base >= UINT32_MAX) {
|
|
|
|
SPDK_ERRLOG("Delay time of %"PRIu32" is to big\n", delay_base_us);
|
|
|
|
return -EINVAL;
|
|
|
|
} else if (io_rate == 0) {
|
|
|
|
SPDK_ERRLOG("IOPS rate of %"PRIu32" is too low. Min is %u\n", io_rate,
|
|
|
|
1000U / SPDK_VHOST_STATS_CHECK_INTERVAL_MS);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
vdev->coalescing_delay_us = delay_base_us;
|
|
|
|
vdev->coalescing_iops_threshold = iops_threshold;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_user_session_set_coalescing(struct spdk_vhost_dev *vdev,
|
|
|
|
struct spdk_vhost_session *vsession, void *ctx)
|
|
|
|
{
|
|
|
|
vsession->coalescing_delay_time_base =
|
|
|
|
vdev->coalescing_delay_us * spdk_get_ticks_hz() / 1000000ULL;
|
|
|
|
vsession->coalescing_io_rate_threshold =
|
|
|
|
vdev->coalescing_iops_threshold * SPDK_VHOST_STATS_CHECK_INTERVAL_MS / 1000U;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
spdk_vhost_set_coalescing(struct spdk_vhost_dev *vdev, uint32_t delay_base_us,
|
|
|
|
uint32_t iops_threshold)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = vhost_user_dev_set_coalescing(vdev, delay_base_us, iops_threshold);
|
|
|
|
if (rc != 0) {
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
vhost_dev_foreach_session(vdev, vhost_user_session_set_coalescing, NULL, NULL);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
spdk_vhost_get_coalescing(struct spdk_vhost_dev *vdev, uint32_t *delay_base_us,
|
|
|
|
uint32_t *iops_threshold)
|
|
|
|
{
|
|
|
|
if (delay_base_us) {
|
|
|
|
*delay_base_us = vdev->coalescing_delay_us;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (iops_threshold) {
|
|
|
|
*iops_threshold = vdev->coalescing_iops_threshold;
|
|
|
|
}
|
|
|
|
}
|
2021-12-08 10:47:32 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
spdk_vhost_set_socket_path(const char *basename)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (basename && strlen(basename) > 0) {
|
|
|
|
ret = snprintf(g_vhost_user_dev_dirname, sizeof(g_vhost_user_dev_dirname) - 2, "%s", basename);
|
|
|
|
if (ret <= 0) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
if ((size_t)ret >= sizeof(g_vhost_user_dev_dirname) - 2) {
|
|
|
|
SPDK_ERRLOG("Char dev dir path length %d is too long\n", ret);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (g_vhost_user_dev_dirname[ret - 1] != '/') {
|
|
|
|
g_vhost_user_dev_dirname[ret] = '/';
|
|
|
|
g_vhost_user_dev_dirname[ret + 1] = '\0';
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2022-01-12 14:25:38 +00:00
|
|
|
|
|
|
|
static void
|
|
|
|
vhost_dev_thread_exit(void *arg1)
|
|
|
|
{
|
|
|
|
spdk_thread_exit(spdk_get_thread());
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_user_dev_register(struct spdk_vhost_dev *vdev, const char *name, struct spdk_cpuset *cpumask,
|
|
|
|
const struct spdk_vhost_dev_backend *backend)
|
|
|
|
{
|
|
|
|
char path[PATH_MAX];
|
|
|
|
|
|
|
|
if (snprintf(path, sizeof(path), "%s%s", g_vhost_user_dev_dirname, name) >= (int)sizeof(path)) {
|
|
|
|
SPDK_ERRLOG("Resulting socket path for controller %s is too long: %s%s\n",
|
|
|
|
name,g_vhost_user_dev_dirname, name);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
vdev->path = strdup(path);
|
|
|
|
if (vdev->path == NULL) {
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
vdev->thread = spdk_thread_create(vdev->name, cpumask);
|
|
|
|
if (vdev->thread == NULL) {
|
|
|
|
free(vdev->path);
|
|
|
|
SPDK_ERRLOG("Failed to create thread for vhost controller %s.\n", name);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
vdev->registered = true;
|
|
|
|
vdev->backend = backend;
|
|
|
|
TAILQ_INIT(&vdev->vsessions);
|
|
|
|
|
|
|
|
vhost_user_dev_set_coalescing(vdev, SPDK_VHOST_COALESCING_DELAY_BASE_US,
|
|
|
|
SPDK_VHOST_VQ_IOPS_COALESCING_THRESHOLD);
|
|
|
|
|
|
|
|
if (vhost_register_unix_socket(path, name, vdev->virtio_features, vdev->disabled_features,
|
|
|
|
vdev->protocol_features)) {
|
|
|
|
spdk_thread_send_msg(vdev->thread, vhost_dev_thread_exit, NULL);
|
|
|
|
free(vdev->path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_user_dev_unregister(struct spdk_vhost_dev *vdev)
|
|
|
|
{
|
|
|
|
if (!TAILQ_EMPTY(&vdev->vsessions)) {
|
|
|
|
SPDK_ERRLOG("Controller %s has still valid connection.\n", vdev->name);
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (vdev->registered && vhost_driver_unregister(vdev->path) != 0) {
|
|
|
|
SPDK_ERRLOG("Could not unregister controller %s with vhost library\n"
|
|
|
|
"Check if domain socket %s still exists\n",
|
|
|
|
vdev->name, vdev->path);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
spdk_thread_send_msg(vdev->thread, vhost_dev_thread_exit, NULL);
|
|
|
|
free(vdev->path);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool g_vhost_user_started = false;
|
|
|
|
|
|
|
|
int
|
|
|
|
vhost_user_init(void)
|
|
|
|
{
|
|
|
|
size_t len;
|
|
|
|
|
|
|
|
if (g_vhost_user_started) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (g_vhost_user_dev_dirname[0] == '\0') {
|
|
|
|
if (getcwd(g_vhost_user_dev_dirname, sizeof(g_vhost_user_dev_dirname) - 1) == NULL) {
|
|
|
|
SPDK_ERRLOG("getcwd failed (%d): %s\n", errno, spdk_strerror(errno));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
len = strlen(g_vhost_user_dev_dirname);
|
|
|
|
if (g_vhost_user_dev_dirname[len - 1] != '/') {
|
|
|
|
g_vhost_user_dev_dirname[len] = '/';
|
|
|
|
g_vhost_user_dev_dirname[len + 1] = '\0';
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
g_vhost_user_started = true;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *
|
|
|
|
vhost_user_session_shutdown(void *arg)
|
|
|
|
{
|
|
|
|
struct spdk_vhost_dev *vdev = NULL;
|
|
|
|
struct spdk_vhost_session *vsession;
|
|
|
|
vhost_fini_cb vhost_cb = arg;
|
|
|
|
|
|
|
|
for (vdev = spdk_vhost_dev_next(NULL); vdev != NULL;
|
|
|
|
vdev = spdk_vhost_dev_next(vdev)) {
|
|
|
|
spdk_vhost_lock();
|
|
|
|
TAILQ_FOREACH(vsession, &vdev->vsessions, tailq) {
|
|
|
|
if (vsession->started) {
|
|
|
|
_stop_session(vsession);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spdk_vhost_unlock();
|
|
|
|
vhost_driver_unregister(vdev->path);
|
|
|
|
vdev->registered = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
SPDK_INFOLOG(vhost, "Exiting\n");
|
|
|
|
spdk_thread_send_msg(g_vhost_init_thread, vhost_cb, NULL);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
vhost_user_fini(vhost_fini_cb vhost_cb)
|
|
|
|
{
|
|
|
|
pthread_t tid;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (!g_vhost_user_started) {
|
|
|
|
vhost_cb(NULL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
g_vhost_user_started = false;
|
|
|
|
|
|
|
|
/* rte_vhost API for removing sockets is not asynchronous. Since it may call SPDK
|
|
|
|
* ops for stopping a device or removing a connection, we need to call it from
|
|
|
|
* a separate thread to avoid deadlock.
|
|
|
|
*/
|
|
|
|
rc = pthread_create(&tid, NULL, &vhost_user_session_shutdown, vhost_cb);
|
|
|
|
if (rc < 0) {
|
|
|
|
SPDK_ERRLOG("Failed to start session shutdown thread (%d): %s\n", rc, spdk_strerror(rc));
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
pthread_detach(tid);
|
|
|
|
}
|