d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lib/iscsi: Remove unimplemented internal API from tgt_node.h

Browse Source 
spdk_iscsi_tgt_node_reset() is not implemented and the code to
call it is commented out. We will have to implement them from scratch
if we do. So remove them in this patch.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I63618b0f8857cb23b57f5a92ec363a91c1d5a912
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1885
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Seth Howell <seth.howell@intel.com>
This commit is contained in:
Shuhei Matsumoto 2020-04-16 06:00:31 +09:00 committed by Tomasz Zawadzki
parent 356cb2332c
commit 040095db86
2 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/iscsi/iscsi.c
View File

@ -3718,33 +3718,12 @@ iscsi_pdu_hdr_op_task(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu)
case ISCSI_TASK_FUNC_TARGET_WARM_RESET:
SPDK_NOTICELOG("TARGET_WARM_RESET (Unsupported)\n");
#if 0
spdk_iscsi_drop_conns(conn, conn->initiator_name, 1 /* drop all */);
rc = spdk_iscsi_tgt_node_reset(conn->sess->target, lun);
if (rc < 0) {
SPDK_ERRLOG("tgt_node reset failed\n");
}
#else
task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;
#endif
break;
case ISCSI_TASK_FUNC_TARGET_COLD_RESET:
SPDK_NOTICELOG("TARGET_COLD_RESET\n");
#if 0
spdk_iscsi_drop_conns(conn, conn->initiator_name, 1 /* drop all */);
rc = spdk_iscsi_tgt_node_reset(conn->sess->target, lun);
if (rc < 0) {
SPDK_ERRLOG("tgt_node reset failed\n");
}
conn->state = ISCSI_CONN_STATE_EXITING;
#else
SPDK_NOTICELOG("TARGET_COLD_RESET (Unsupported)\n");
task->scsi.response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;
#endif
break;
case ISCSI_TASK_FUNC_TASK_REASSIGN:

2
lib/iscsi/tgt_node.h
View File

@ -132,8 +132,6 @@ bool spdk_iscsi_tgt_node_access(struct spdk_iscsi_conn *conn,
struct spdk_iscsi_tgt_node *target, const char *iqn,
const char *addr);
struct spdk_iscsi_tgt_node *spdk_iscsi_find_tgt_node(const char *target_name);
int spdk_iscsi_tgt_node_reset(struct spdk_iscsi_tgt_node *target,
uint64_t lun);
int spdk_iscsi_tgt_node_cleanup_luns(struct spdk_iscsi_conn *conn,
struct spdk_iscsi_tgt_node *target);
void spdk_iscsi_tgt_node_delete_map(struct spdk_iscsi_portal_grp *portal_group,