d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

spdk_trace: remove fudge factor parameter

Browse Source 
This was added a very long time back to debug this trace
app itself - it's no longer useful.  Plus removing it
reclaims the -f flag which we'll use next to specify
a filename for decoding a tracepoint file offline.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I4fb2352187e6f89e0bd77d01589762f734e4d359

Reviewed-on: https://review.gerrithub.io/424283
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Jim Harris 2018-08-31 15:31:31 -07:00 committed by Ben Walker
parent 8b6826536c
commit 0fd41a7c34
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/trace/trace.cpp
View File

@ -81,7 +81,6 @@ struct object_stats g_stats[SPDK_TRACE_MAX_OBJECT];
static char *exe_name;
static int verbose = 1;
static int g_fudge_factor = 20;
static uint64_t tsc_rate;
static uint64_t first_tsc = 0x0;
@ -245,12 +244,10 @@ populate_events(struct spdk_trace_history *history)
}
}
first += g_fudge_factor;
if (first >= num_entries) {
first -= num_entries;
}
last -= g_fudge_factor;
if (last < 0) {
last += num_entries;
}
@ -295,8 +292,6 @@ static void usage(void)
fprintf(stderr, " option = '-q' to disable verbose mode\n");
fprintf(stderr, " '-s' to specify spdk_trace shm name\n");
fprintf(stderr, " '-c' to display single lcore history\n");
fprintf(stderr, " '-f' to specify number of events to ignore at\n");
fprintf(stderr, " beginning and end of trace (default: 20)\n");
fprintf(stderr, " '-i' to specify the shared memory ID\n");
fprintf(stderr, " '-p' to specify the trace PID\n");
fprintf(stderr, " (One of -i or -p must be specified)\n");
@ -326,9 +321,6 @@ int main(int argc, char **argv)
exit(1);
}
break;
case 'f':
g_fudge_factor = atoi(optarg);
break;
case 'i':
shm_id = atoi(optarg);
break;