From 164bfddf245d6b4413e8420130d7f8d8b62b6838 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Wed, 23 Jun 2021 17:11:48 +0000 Subject: [PATCH] nvmf: don't set aerl=0 for non-discovery controllers Commit b7cc4dd added support multiple AERs, but didn't remove the code that hardcodes aerl=0 for non-discovery controllers. So even though the target now supports multiple AERs, we never indicate that for non-discovery controllers. The spec also recommends that implementations support a minimum of 4 AERs - so the current behavior is not recommended. It seems that at least on Windows (when testing with vfio-user transport) we see the limit get exceeded which results in ERRLOGs. Let's keep the ERRLOG there for now, assuming that once we report we support 4 AERs that Windows won't try to send more than that. Fixes issue #2000. Signed-off-by: Jim Harris Change-Id: I6a07a6f37aaa6e531ae2cf1e1c46da036b00785b Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8488 Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot Reviewed-by: Paul Luse Reviewed-by: Changpeng Liu Reviewed-by: Reviewed-by: Aleksey Marchuk --- lib/nvmf/ctrlr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index e83db68b3f..678e8ea995 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -2318,7 +2318,6 @@ spdk_nvmf_ctrlr_identify_ctrlr(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_c cdata->ctratt.host_id_exhid_supported = 1; /* TODO: Concurrent execution of multiple abort commands. */ cdata->acl = 0; - cdata->aerl = 0; cdata->frmw.slot1_ro = 1; cdata->frmw.num_slots = 1;