d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test/blobfs: Fix typo in the mount check

Browse Source 
The actual check was ORing the execution of mount instead of sending
its stdout to grep - in case mount returned with != 0, this would
block execution of the entire script as grep would wait for input on
its stdin still attached to a terminal.

Also, quote $mount_dir to avoid potential word splitting.

Change-Id: Iea531eef0af79a3742e0a954ea6188e304d0d14a
Signed-off-by: Michal Berger <michallinuxstuff@gmail.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/483433
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Michal Berger 2020-01-31 08:07:41 +01:00 committed by Tomasz Zawadzki
parent e69baea132
commit 1c06235ab3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/blobfs/blobfs.sh
View File

@ -97,7 +97,7 @@ function blobfs_fuse_test() {
waitforlisten $blobfs_pid /var/tmp/spdk.sock
# check mount status
mount || grep $mount_dir
mount | grep "$mount_dir"
# create a rand file in mount dir
dd if=/dev/urandom of=${mount_dir}/rand_file bs=4k count=32