d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test/iscsi: add target node config parsing test

Browse Source 
Change-Id: I39d74043e73aef9e51aca342308b0ec774a9c481
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-08-16 15:23:35 -07:00
parent b4a15dfb46
commit 1d737a8dc0
6 changed files with 287 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/lib/iscsi/Makefile
View File

@ -34,7 +34,7 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
DIRS-y = param
DIRS-y = param target_node
.PHONY: all clean $(DIRS-y)

4
test/lib/iscsi/iscsi.sh
View File

@ -12,4 +12,8 @@ timing_enter param
$testdir/param/param_ut
timing_exit param
timing_enter target_node
$testdir/target_node/target_node_ut $testdir/target_node/target_node.conf
timing_exit target_node
timing_exit iscsi

1
test/lib/iscsi/target_node/.gitignore vendored Normal file
View File

@ -0,0 +1 @@
target_node_ut

59
test/lib/iscsi/target_node/Makefile Normal file
View File

@ -0,0 +1,59 @@
#
# BSD LICENSE
#
# Copyright (c) Intel Corporation.
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Intel Corporation nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
SPDK_LIBS += $(SPDK_ROOT_DIR)/lib/log/libspdk_log.a \
$(SPDK_ROOT_DIR)/lib/conf/libspdk_conf.a \
$(SPDK_ROOT_DIR)/lib/util/libspdk_util.a \
$(SPDK_ROOT_DIR)/lib/cunit/libspdk_cunit.a
CFLAGS += $(DPDK_INC)
CFLAGS += -I$(SPDK_ROOT_DIR)/test
CFLAGS += -I$(SPDK_ROOT_DIR)/lib
LIBS += $(SPDK_LIBS)
LIBS += -lcunit
APP = target_node_ut
C_SRCS = target_node_ut.c
all: $(APP)
$(APP): $(OBJS) $(SPDK_LIBS)
$(LINK_C)
clean:
$(CLEAN_C) $(APP)
include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk

95
test/lib/iscsi/target_node/target_node.conf Normal file
View File

@ -0,0 +1,95 @@
[Global]
# Test that parsing fails if there is no TargetName
[Failure0]
TargetAlias "Data Disk1"
Mapping PortalGroup1 InitiatorGroup1
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if there is no Mapping
[Failure1]
TargetName target1
TargetAlias "Data Disk1"
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if Mapping does not define Portal or InitiatorGroup
[Failure2]
TargetName target1
TargetAlias "Data Disk1"
Mapping
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if Mapping does not define InitiatorGroup
[Failure3]
TargetName target1
TargetAlias "Data Disk1"
Mapping PortalGroup1
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if Mapping switches PortalGroup/InitiatorGroup order
[Failure4]
TargetName target1
TargetAlias "Data Disk1"
Mapping InitiatorGroup1 PortalGroup1
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if Mapping uses invalid InitiatorGroup0
[Failure5]
TargetName target1
TargetAlias "Data Disk1"
Mapping PortalGroup1 InitiatorGroup0
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if Mapping uses invalid PortalGroup0
[Failure6]
TargetName target1
TargetAlias "Data Disk1"
Mapping PortalGroup0 InitiatorGroup1
AuthMethod Auto
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1
# Test that parsing fails if AuthMethod is invalid
[Failure7]
TargetName target1
TargetAlias "Data Disk1"
Mapping PortalGroup1 InitiatorGroup1
AuthMethod SomeGarbage
AuthGroup AuthGroup1
UseDigest Auto
QueueDepth 128
LUN0 Malloc0
LUN1 Malloc1

127
test/lib/iscsi/target_node/target_node_ut.c Normal file
View File

@ -0,0 +1,127 @@
/*-
* BSD LICENSE
*
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include "spdk/scsi.h"
#include "CUnit/Basic.h"
#include "../common.c"
#include "iscsi/tgt_node.c"
const char *config_file;
bool
spdk_sock_is_ipv6(int sock)
{
return false;
}
bool
spdk_sock_is_ipv4(int sock)
{
return false;
}
struct spdk_iscsi_portal_grp *
spdk_iscsi_portal_grp_find_by_tag(int tag)
{
return NULL;
}
static void
config_file_fail_cases(void)
{
struct spdk_conf *config;
struct spdk_conf_section *sp;
char section_name[64];
int section_index;
int rc;
config = spdk_conf_allocate();
rc = spdk_conf_read(config, config_file);
CU_ASSERT(rc == 0);
section_index = 0;
while (true) {
sprintf(section_name, "Failure%d", section_index);
sp = spdk_conf_find_section(config, section_name);
if (sp == NULL) {
break;
}
rc = spdk_cf_add_iscsi_tgt_node(sp);
CU_ASSERT(rc < 0);
section_index++;
}
}
int
main(int argc, char **argv)
{
CU_pSuite suite = NULL;
unsigned int num_failures;
if (argc < 2) {
fprintf(stderr, "usage: %s <config file>\n", argv[0]);
exit(1);
}
if (CU_initialize_registry() != CUE_SUCCESS) {
return CU_get_error();
}
config_file = argv[1];
suite = CU_add_suite("iscsi_target_node_suite", NULL, NULL);
if (suite == NULL) {
CU_cleanup_registry();
return CU_get_error();
}
if (
CU_add_test(suite, "config file fail cases", config_file_fail_cases) == NULL
) {
CU_cleanup_registry();
return CU_get_error();
}
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
return num_failures;
}