From 238251a10b2b7fc915ea7b17c1986d244c6da8db Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Thu, 15 Oct 2020 16:55:40 +0200 Subject: [PATCH] sync_dev_uevents: Break from the loop if kernel seqnum matches mdev's Change-Id: I68b1edf48eb7b243647b3e980d989c580015f812 Signed-off-by: Michal Berger Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4710 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- scripts/sync_dev_uevents.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/sync_dev_uevents.sh b/scripts/sync_dev_uevents.sh index b7b2f76988..5537c26ef2 100755 --- a/scripts/sync_dev_uevents.sh +++ b/scripts/sync_dev_uevents.sh @@ -152,10 +152,8 @@ elif [[ -e /sys/kernel/uevent_helper ]]; then # mdev keeps count of the seqnums on its own on each execution # and saves the count under /dev/mdev.seq. This is then set to # + 1 after the uevents finally settled. - while ((timeout--)); do - if (($(< /sys/kernel/uevent_seqnum) + 1 != $(< /dev/mdev.seq))); then - sleep 1s - fi + while ((timeout-- && $(< /sys/kernel/uevent_seqnum) + 1 != $(< /dev/mdev.seq))); do + sleep 1s done if ((timeout < 0)); then printf '* Events not synced in time, %s devices (%s) may be missing\n' \