d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "shared_lib: add as_needed to the libspdk.so linker script"

Browse Source 
This reverts commit 346fefc364.
That commit breaks the shared object build when linking against the
implicit top level linker script. It makes it so that none of the
constructor functions get properly linked in.

Change-Id: I3477acbd86f44b6d5e949eb6725ca4c1b71a55b5
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462149
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Seth Howell 2019-07-17 01:04:32 -07:00 committed by Changpeng Liu
parent 4edb785f49
commit 266ca94013
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shared_lib/Makefile
View File

@ -47,7 +47,7 @@ SPDK_SHARED_LIBS := $(filter-out $(IGNORED_LIBS), $(sort $(notdir $(wildcard $(S
$(SHARED_REALNAME_LIB):
$(Q)echo " SO $(notdir $@)"; \
echo "GROUP ( AS_NEEDED ( $(SPDK_SHARED_LIBS) ) )" > $(SHARED_REALNAME_LIB)
echo "GROUP ( $(SPDK_SHARED_LIBS) )" > $(SHARED_REALNAME_LIB)
$(SHARED_LINKED_LIB) : $(SHARED_REALNAME_LIB)
$(Q)echo " SYMLINK $(notdir $@)"; $(BUILD_LINKERNAME_LIB)