From 26f6c2a03d7a54a4a79fc4dc5efec427422835a8 Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Fri, 26 Jul 2019 06:52:23 +0200 Subject: [PATCH] ut/bdev: silence scan-build warnings about histogram memory leaks bdev_ut.c:1863:2: warning: Potential leak of memory pointed to by 'histogram' poll_threads(); ^~~~~~~~~~~~~~ We used to free g_histogram instead of histogram. Those should be the same thing, but scan-build gets confused. Change the code to free histogram - this should also make it slightly easier to read. Change-Id: Ifaad1c2d9c7f9cc1a106f6edf3d22b54e42fe867 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463256 Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- test/unit/lib/bdev/bdev.c/bdev_ut.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/lib/bdev/bdev.c/bdev_ut.c b/test/unit/lib/bdev/bdev.c/bdev_ut.c index a8e3dbdcb7..eb63566b07 100644 --- a/test/unit/lib/bdev/bdev.c/bdev_ut.c +++ b/test/unit/lib/bdev/bdev.c/bdev_ut.c @@ -1863,7 +1863,7 @@ bdev_histograms(void) poll_threads(); CU_ASSERT(g_status == -EFAULT); - spdk_histogram_data_free(g_histogram); + spdk_histogram_data_free(histogram); spdk_put_io_channel(ch); spdk_bdev_close(desc); free_bdev(bdev);