d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pmem: print logs on debug build

Browse Source 
Change-Id: I6eb8cb0d29f86225116d8cae2ee4c19aa65dcc18
Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-on: https://review.gerrithub.io/434155
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
This commit is contained in:
Pawel Wodkowski 2018-11-14 10:16:28 +01:00 committed by Jim Harris
parent 760bb7e862
commit 2a8084018c
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/bdev/pmem/bdev_pmem.c
View File

@ -38,6 +38,7 @@
#include "spdk/rpc.h"
#include "spdk/bdev_module.h"
#include "spdk_internal/log.h"
#include "spdk/config.h"
#include "bdev_pmem.h"
#include "libpmemblk.h"
@ -442,6 +443,9 @@ bdev_pmem_initialize(void)
return -1;
}
#ifdef SPDK_CONFIG_DEBUG
setenv("PMEMBLK_LOG_LEVEL", "1", 1);
#endif
spdk_io_device_register(&g_pmem_disks, bdev_pmem_create_cb, bdev_pmem_destroy_cb, 0, "pmem_bdev");
bdev_pmem_read_conf();

10
lib/bdev/pmem/bdev_pmem_rpc.c
View File

@ -205,6 +205,9 @@ spdk_rpc_create_pmem_pool(struct spdk_jsonrpc_request *request,
pbp = pmemblk_create(req.pmem_file, req.block_size, pool_size, 0666);
if (pbp == NULL) {
const char *msg = pmemblk_errormsg();
SPDK_ERRLOG("pmemblk_create() failed: %s\n", msg ? msg : "(logs disabled)");
goto invalid;
}
@ -317,6 +320,7 @@ spdk_rpc_delete_pmem_pool(struct spdk_jsonrpc_request *request,
{
struct rpc_delete_pmem_pool req = {};
struct spdk_json_write_ctx *w;
int rc;
if (spdk_json_decode_object(params, rpc_delete_pmem_pool_decoders,
SPDK_COUNTOF(rpc_delete_pmem_pool_decoders),
@ -326,7 +330,11 @@ spdk_rpc_delete_pmem_pool(struct spdk_jsonrpc_request *request,
}
/* Check if file is actually pmem pool */
if (pmemblk_check(req.pmem_file, 0) != 1) {
rc = pmemblk_check(req.pmem_file, 0);
if (rc != 1) {
const char *msg = pmemblk_errormsg();
SPDK_ERRLOG("pmemblk_check() failed (%d): %s\n", rc, msg ? msg : "(logs disabled)");
goto invalid;
}