d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

nvmf: Support concurrent execution of multiple abort commands

Browse Source 
We did not have any practical limitation to support concurrent
execution of multiple abort commands.

NVMe specification recommends that implementations support a minimum
of four abort commands.

Let's follow the NVMe specification.

As stated in the head, we do not have any limitation, and we do not
have to check if abort commands exceeds ACL or not.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I31e066fadcb5d619d0c50c895c4cb64520b33513
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11232
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Shuhei Matsumoto 2022-01-25 17:08:49 +09:00 committed by Jim Harris
parent 6b9a980795
commit 2a99dbc792
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/nvmf/ctrlr.c
View File

@ -65,6 +65,8 @@
#define ANA_TRANSITION_TIME_IN_SEC 10 #define ANA_TRANSITION_TIME_IN_SEC 10
#define NVMF_ABORT_COMMAND_LIMIT 3
/* /*
* Support for custom admin command handlers * Support for custom admin command handlers
*/ */
@ -2683,8 +2685,10 @@ spdk_nvmf_ctrlr_identify_ctrlr(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_c
cdata->oaes.ana_change_notices = 1; cdata->oaes.ana_change_notices = 1;
} }
cdata->ctratt.host_id_exhid_supported = 1; cdata->ctratt.host_id_exhid_supported = 1;
/* TODO: Concurrent execution of multiple abort commands. */ /* We do not have any actual limitation to the number of abort commands.
cdata->acl = 0; * We follow the recommendation by the NVMe specification.
*/
cdata->acl = NVMF_ABORT_COMMAND_LIMIT;
cdata->frmw.slot1_ro = 1; cdata->frmw.slot1_ro = 1;
cdata->frmw.num_slots = 1; cdata->frmw.num_slots = 1;