From 3021eb3ce337159b3ae5fb5ebb294ccb4eebe4fb Mon Sep 17 00:00:00 2001 From: GangCao Date: Fri, 12 Nov 2021 13:31:55 -0500 Subject: [PATCH] module/bdev: move the NULL check before dereference To fix the Klocwork issue. Change-Id: I9512f1303890b00964a902e28df2395856d3ed32 Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10200 Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Reviewed-by: Shuhei Matsumoto Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk Reviewed-by: Dong Yi --- module/bdev/nvme/bdev_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/bdev/nvme/bdev_nvme.c b/module/bdev/nvme/bdev_nvme.c index 8e4c686627..e350082fe2 100644 --- a/module/bdev/nvme/bdev_nvme.c +++ b/module/bdev/nvme/bdev_nvme.c @@ -873,9 +873,9 @@ bdev_nvme_io_complete_nvme_status(struct nvme_bdev_io *bio, } nbdev_ch = spdk_io_channel_get_ctx(spdk_bdev_io_get_io_channel(bdev_io)); - nvme_ctrlr = nvme_ctrlr_channel_get_ctrlr(bio->io_path->ctrlr_ch); assert(bio->io_path != NULL); + nvme_ctrlr = nvme_ctrlr_channel_get_ctrlr(bio->io_path->ctrlr_ch); if (spdk_nvme_cpl_is_path_error(cpl) || spdk_nvme_cpl_is_aborted_sq_deletion(cpl) ||