spdkcli: add split bdev functionality

Change-Id: Iad79cc74e9590d4865eadb9d2ca428257f42fdc2
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/414951
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>

scripts/spdkcli/ui_node.py

@@ -52,6 +52,7 @@ class UIBdevs(UINode):
         UIAIOBdev(self)
         UILvolBdev(self)
         UINvmeBdev(self)
+        UISplitBdev(self)
 
     def ui_command_delete(self, name):
         """
@@ -131,6 +132,36 @@ class UIBdev(UINode):
         self.get_root().refresh()
         self.refresh()
 
+    def ui_command_split_bdev(self, base_bdev, split_count, split_size_mb=None):
+        """
+        Construct split block devices from a base bdev.
+
+        Arguments:
+        base_bdev - Name of bdev to split
+        split_count -  Number of split bdevs to create
+        split_size_mb- Size of each split volume in MiB (optional)
+        """
+
+        split_count = self.ui_eval_param(split_count, "number", None)
+        split_size_mb = self.ui_eval_param(split_size_mb, "number", None)
+
+        ret_name = self.get_root().split_bdev(base_bdev=base_bdev,
+                                              split_count=split_count,
+                                              split_size_mb=split_size_mb)
+        self.shell.log.info(ret_name)
+        self.parent.refresh()
+        self.refresh()
+
+    def ui_command_destruct_split_bdev(self, base_bdev):
+        """Destroy split block devices associated with base bdev.
+
+        Args:
+            base_bdev: name of previously split bdev
+        """
+        self.get_root().destruct_split_bdev(base_bdev=base_bdev)
+        self.parent.refresh()
+        self.refresh()
+
     def summary(self):
         return "Bdevs: %d" % len(self.children), None
 
@@ -244,6 +275,11 @@ class UINvmeBdev(UIBdev):
         self.refresh()
 
 
+class UISplitBdev(UIBdev):
+    def __init__(self, parent):
+        UIBdev.__init__(self, "Split_Disk", parent)
+
+
 class UIBdevObj(UINode):
     def __init__(self, bdev, parent):
         self.bdev = bdev

scripts/spdkcli/ui_root.py

@@ -27,7 +27,7 @@ class UIRoot(UINode):
     def get_bdevs(self, bdev_type):
         self.current_bdevs = rpc.bdev.get_bdevs(self.client)
         # Following replace needs to be done in order for some of the bdev
-        # listings to work.
+        # listings to work: logical volumes, split disk.
         # For example logical volumes: listing in menu is "Logical_Volume"
         # (cannot have space), but the product name in SPDK is "Logical Volume"
         bdev_type = bdev_type.replace("_", " ")
@@ -36,6 +36,13 @@ class UIRoot(UINode):
             test = Bdev(bdev)
             yield test
 
+    def split_bdev(self, **kwargs):
+        response = rpc.bdev.construct_split_vbdev(self.client, **kwargs)
+        return self.print_array(response)
+
+    def destruct_split_bdev(self, **kwargs):
+        rpc.bdev.destruct_split_vbdev(self.client, **kwargs)
+
     def delete_bdev(self, name):
         rpc.bdev.delete_bdev(self.client, bdev_name=name)