d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

nvmf: remove spdk_nvmf_construct_subsystem()

Browse Source 
After the previous cleanup patches, this function was just calling
nvmf_tgt_create_subsystem() with no other functionality.

Change-Id: I1b20887cade7496093e0b69778df30f818eeb764
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/403379
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Daniel Verkamp 2018-03-09 17:06:25 -07:00
parent 1d48012929
commit 3f987aa84d
3 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/event/subsystems/nvmf/conf.c
View File

@ -183,7 +183,7 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp)
return -1;
}
subsystem = spdk_nvmf_construct_subsystem(nqn);
subsystem = nvmf_tgt_create_subsystem(nqn, SPDK_NVMF_SUBTYPE_NVME, 0);
if (subsystem == NULL) {
goto done;
}
@ -354,22 +354,3 @@ spdk_nvmf_parse_conf(void)
return 0;
}
struct spdk_nvmf_subsystem *
spdk_nvmf_construct_subsystem(const char *name)
{
struct spdk_nvmf_subsystem *subsystem;
if (name == NULL) {
SPDK_ERRLOG("No NQN specified for subsystem\n");
return NULL;
}
subsystem = nvmf_tgt_create_subsystem(name, SPDK_NVMF_SUBTYPE_NVME, 0);
if (subsystem == NULL) {
SPDK_ERRLOG("Subsystem creation failed\n");
return NULL;
}
return subsystem;
}

2
lib/event/subsystems/nvmf/event_nvmf.h
View File

@ -77,6 +77,4 @@ int spdk_nvmf_parse_conf(void);
struct spdk_nvmf_subsystem *nvmf_tgt_create_subsystem(const char *name,
enum spdk_nvmf_subtype subtype, uint32_t num_ns);
struct spdk_nvmf_subsystem *spdk_nvmf_construct_subsystem(const char *name);
#endif

2
lib/event/subsystems/nvmf/nvmf_rpc.c
View File

@ -605,7 +605,7 @@ spdk_rpc_construct_nvmf_subsystem(struct spdk_jsonrpc_request *request,
SPDK_NOTICELOG("Ignoring it and continuing.\n");
}
subsystem = spdk_nvmf_construct_subsystem(req.nqn);
subsystem = nvmf_tgt_create_subsystem(req.nqn, SPDK_NVMF_SUBTYPE_NVME, 0);
if (!subsystem) {
goto invalid;
}