test/nvmf: simplify more of the nvmf test scripts
This should cover all of the cases that we want to changes for now - where it was doing an unnecessarily loop over just one malloc bdev. A few cases remain, but I'm planning to strengthen those tests with more bdevs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I16f9e82b4a551bcf1f491fc506e11c0ee98b60d9 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/452917 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
parent
1ddf2b5e20
commit
41456afc3c
@ -35,12 +35,9 @@ waitforlisten $nvmfpid
|
||||
$rpc_py nvmf_create_transport -t RDMA -u 8192 -p 4
|
||||
timing_exit start_nvmf_tgt
|
||||
|
||||
bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE)"
|
||||
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc0
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001
|
||||
for bdev in $bdevs; do
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 $bdev
|
||||
done
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t rdma -a $NVMF_FIRST_TARGET_IP -s 4420
|
||||
|
||||
echo "[Nvme]" > $testdir/bdevperf.conf
|
||||
|
@ -33,16 +33,13 @@ waitforlisten $nvmfpid
|
||||
$rpc_py nvmf_create_transport -t RDMA -u 8192 -p 4
|
||||
timing_exit start_nvmf_tgt
|
||||
|
||||
bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE)"
|
||||
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc0
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001
|
||||
for bdev in $bdevs; do
|
||||
# NOTE: This will assign the same NGUID and EUI64 to all bdevs,
|
||||
# but currently we only have one (see above), so this is OK.
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 "$bdev" \
|
||||
--nguid "ABCDEF0123456789ABCDEF0123456789" \
|
||||
--eui64 "ABCDEF0123456789"
|
||||
done
|
||||
# NOTE: This will assign the same NGUID and EUI64 to all bdevs,
|
||||
# but currently we only have one (see above), so this is OK.
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0 \
|
||||
--nguid "ABCDEF0123456789ABCDEF0123456789" \
|
||||
--eui64 "ABCDEF0123456789"
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t RDMA -a $NVMF_FIRST_TARGET_IP -s 4420
|
||||
|
||||
$rpc_py get_nvmf_subsystems
|
||||
|
@ -48,11 +48,9 @@ modprobe -v nvme-rdma
|
||||
|
||||
for i in `seq 1 $NVMF_SUBSYS`
|
||||
do
|
||||
bdevs="$($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE)"
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc$i
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode$i -a -s SPDK$i
|
||||
for bdev in $bdevs; do
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode$i $bdev
|
||||
done
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode$i Malloc$i
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode$i -t rdma -a $NVMF_FIRST_TARGET_IP -s $NVMF_PORT
|
||||
done
|
||||
|
||||
|
@ -37,29 +37,25 @@ $rpc_py nvmf_create_transport -t RDMA -u 8192 -p 4
|
||||
timing_exit start_nvmf_tgt
|
||||
|
||||
# Create subsystems
|
||||
bdevs="$($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE)"
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc0
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK1
|
||||
for bdev in $bdevs; do
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 $bdev
|
||||
done
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t RDMA -a $NVMF_FIRST_TARGET_IP -s "$NVMF_PORT"
|
||||
|
||||
echo "test case1: single bdev can't be used in multiple subsystems"
|
||||
set +e
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode2 -a -s SPDK2
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode2 -t RDMA -a $NVMF_FIRST_TARGET_IP -s "$NVMF_PORT"
|
||||
for bdev in $bdevs; do
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode2 $bdev
|
||||
nmic_status=$?
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode2 Malloc0
|
||||
nmic_status=$?
|
||||
|
||||
if [ $nmic_status -eq 0 ]; then
|
||||
echo " Adding namespace passed - failure expected."
|
||||
killprocess $pid
|
||||
exit 1
|
||||
else
|
||||
echo " Adding namespace failed - expected result."
|
||||
fi
|
||||
done
|
||||
if [ $nmic_status -eq 0 ]; then
|
||||
echo " Adding namespace passed - failure expected."
|
||||
killprocess $pid
|
||||
exit 1
|
||||
else
|
||||
echo " Adding namespace failed - expected result."
|
||||
fi
|
||||
set -e
|
||||
|
||||
modprobe -v nvme-rdma
|
||||
|
@ -41,15 +41,14 @@ waitforlisten $nvmfpid
|
||||
$rpc_py nvmf_create_transport -t RDMA -u 8192 -p 4
|
||||
timing_exit start_nvmf_tgt
|
||||
|
||||
bdevs="$($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE) "
|
||||
bdevs+="$($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE)"
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc0
|
||||
$rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc1
|
||||
|
||||
modprobe -v nvme-rdma
|
||||
|
||||
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001 -d SPDK_Controller1
|
||||
for bdev in $bdevs; do
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 $bdev
|
||||
done
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0
|
||||
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc1
|
||||
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t rdma -a $NVMF_FIRST_TARGET_IP -s $NVMF_PORT
|
||||
|
||||
nvme connect -t rdma -n "nqn.2016-06.io.spdk:cnode1" -a "$NVMF_FIRST_TARGET_IP" -s "$NVMF_PORT"
|
||||
|
Loading…
x
Reference in New Issue
Block a user