d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bdev/null: fix RPC string memory leak

Browse Source 
The uuid string was not freed.  Factor out the free() calls into a
helper function and add a free of uuid.

Change-Id: I2f5f794e240fcdb07f346b892ea4dec46dc9bdb6
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/406665
Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Daniel Verkamp 2018-04-05 14:45:16 -07:00 committed by Jim Harris
parent aa3345346c
commit 415933c879
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/bdev/null/bdev_null_rpc.c
View File

@ -46,6 +46,13 @@ struct rpc_construct_null {
uint32_t block_size;
};
static void
free_rpc_construct_null(struct rpc_construct_null *req)
{
free(req->name);
free(req->uuid);
}
static const struct spdk_json_object_decoder rpc_construct_null_decoders[] = {
{"name", offsetof(struct rpc_construct_null, name), spdk_json_decode_string},
{"uuid", offsetof(struct rpc_construct_null, uuid), spdk_json_decode_string, true},
@ -84,7 +91,7 @@ spdk_rpc_construct_null_bdev(struct spdk_jsonrpc_request *request,
w = spdk_jsonrpc_begin_result(request);
if (w == NULL) {
free(req.name);
free_rpc_construct_null(&req);
return;
}
@ -92,11 +99,11 @@ spdk_rpc_construct_null_bdev(struct spdk_jsonrpc_request *request,
spdk_json_write_string(w, bdev->name);
spdk_json_write_array_end(w);
spdk_jsonrpc_end_result(request, w);
free(req.name);
free_rpc_construct_null(&req);
return;
invalid:
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, "Invalid parameters");
free(req.name);
free_rpc_construct_null(&req);
}
SPDK_RPC_REGISTER("construct_null_bdev", spdk_rpc_construct_null_bdev)