d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

qat_setup: Fix logic check against service's exit status

Browse Source 
service is a plain Bash wrapper which either executes systemctl or
rc sysvinit scripts directly, hence its exit status should follow
standard logic - 0 for success != 0 for failure.

Reverse the check to not complain about service failure when it
was actually successfully started.

Change-Id: I29dd22c884157182549ebcc2ab4097eb098d7d3b
Signed-off-by: Michal Berger <michalx.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1603
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Michal Berger 2020-03-31 13:49:27 +02:00 committed by Tomasz Zawadzki
parent eb341e7d32
commit 576602acc4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/qat_setup.sh
View File

@ -35,7 +35,7 @@ if $bad_driver; then
fi
# try starting the qat service. If this doesn't work, just treat it as a warning for now.
if service qat_service start; then
if ! service qat_service start; then
echo "failed to start the qat service. Something may be wrong with your 01.org driver."
fi