From 58f7449e152c3ab75e7eb005bc044ad591ccba7d Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Mon, 1 Jul 2019 11:40:20 -0400 Subject: [PATCH] rdma:Fix gcc9 compile warning on Fedora30. Compile reports that device->map is not initialized. In file included from rdma_ut.c:37: /home/vagrant/spdk_repo/spdk/lib/nvmf/rdma.c:1542:44: warning: 1st function call argument is an uninitialized value wr->sg_list[i].lkey = ((struct ibv_mr *)spdk_mem_map_translate(device->map, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/vagrant/spdk_repo/spdk/lib/nvmf/rdma.c:1545:26: warning: 1st function call argument is an uninitialized value wr->sg_list[i].lkey = spdk_mem_map_translate(device->map, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So add this to initialize memory map. Change-Id: Ia6f6153a1558861b4283637dac47439651b043c7 Signed-off-by: yidong0635 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459927 Tested-by: SPDK CI Jenkins Reviewed-by: Hailiang Wang Reviewed-by: Tomasz Zawadzki Reviewed-by: Paul Luse Reviewed-by: Shuhei Matsumoto Reviewed-by: Changpeng Liu --- test/unit/lib/nvmf/rdma.c/rdma_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/nvmf/rdma.c/rdma_ut.c b/test/unit/lib/nvmf/rdma.c/rdma_ut.c index f859a32a4f..b05bcf0777 100644 --- a/test/unit/lib/nvmf/rdma.c/rdma_ut.c +++ b/test/unit/lib/nvmf/rdma.c/rdma_ut.c @@ -160,6 +160,7 @@ test_spdk_nvmf_rdma_request_parse_sgl(void) reset_nvmf_rdma_request(&rdma_req); sgl->keyed.length = rtransport.transport.opts.io_unit_size / 2; + device.map = (void *)0x0; rc = spdk_nvmf_rdma_request_parse_sgl(&rtransport, &device, &rdma_req); CU_ASSERT(rc == 0); CU_ASSERT(rdma_req.data_from_pool == true);