From 5a597c6f164fef6bb979cb76594ebd557feb942c Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Tue, 7 Nov 2017 09:39:15 +0100 Subject: [PATCH] bs_dev: Add notice log when device does not support unmap Previously lack of support for specific bdev was not known to user. This impacts all unmap operations, such as initialization of blobstore. It should be useful to user to know it will take longer Signed-off-by: Tomasz Zawadzki Change-Id: I89bf3bc0342558fda9a8964fb5cb1daa3a8ed79e Reviewed-on: https://review.gerrithub.io/385999 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris --- lib/blob/bdev/blob_bdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/blob/bdev/blob_bdev.c b/lib/blob/bdev/blob_bdev.c index 6d1c4ef898..4fa1343980 100644 --- a/lib/blob/bdev/blob_bdev.c +++ b/lib/blob/bdev/blob_bdev.c @@ -234,6 +234,8 @@ spdk_bdev_create_bs_dev(struct spdk_bdev *bdev, spdk_bdev_remove_cb_t remove_cb, * This will always work, since bdev implements write_zeroes on top of write * if the device doesn't natively support write_zeroes. */ + SPDK_NOTICELOG("Bdev %s does not support unmap, write_zeroes will be used instead.\n", + bdev->name); b->bs_dev.unmap = bdev_blob_write_zeroes; }