From 66d101ffee95aa9ba6897997a32dc58f503e4126 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Sat, 14 Oct 2017 11:48:13 +0200 Subject: [PATCH] rte_virtio: remove virtqueue_notify() Simplified some code. Change-Id: I9fc42da93a4c2df3714775d73508de118a5e6b1a Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/382618 Reviewed-by: Jim Harris Reviewed-by: Daniel Verkamp Tested-by: SPDK Automated Test System --- lib/bdev/virtio/rte_virtio/virtio_queue.c | 2 +- lib/bdev/virtio/rte_virtio/virtio_queue.h | 11 ----------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/lib/bdev/virtio/rte_virtio/virtio_queue.c b/lib/bdev/virtio/rte_virtio/virtio_queue.c index 3f9f65106e..f4153b5dbb 100644 --- a/lib/bdev/virtio/rte_virtio/virtio_queue.c +++ b/lib/bdev/virtio/rte_virtio/virtio_queue.c @@ -243,7 +243,7 @@ virtio_xmit_pkts(struct virtqueue *vq, struct virtio_req *req) vq_update_avail_idx(vq); if (spdk_unlikely(virtqueue_kick_prepare(vq))) { - virtqueue_notify(vq); + vtpci_ops(vdev)->notify_queue(vdev, vq); PMD_TX_LOG(DEBUG, "Notified backend after xmit"); } diff --git a/lib/bdev/virtio/rte_virtio/virtio_queue.h b/lib/bdev/virtio/rte_virtio/virtio_queue.h index 2ebe9690d1..d342c93559 100644 --- a/lib/bdev/virtio/rte_virtio/virtio_queue.h +++ b/lib/bdev/virtio/rte_virtio/virtio_queue.h @@ -169,15 +169,4 @@ virtqueue_kick_prepare(struct virtqueue *vq) return !(vq->vq_ring.used->flags & VRING_USED_F_NO_NOTIFY); } -static inline void -virtqueue_notify(struct virtqueue *vq) -{ - /* - * Ensure updated avail->idx is visible to host. - * For virtio on IA, the notificaiton is through io port operation - * which is a serialization instruction itself. - */ - vtpci_ops(vq->vdev)->notify_queue(vq->vdev, vq); -} - #endif /* _VIRTQUEUE_H_ */