d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

scripts/rpc: Some params of iSCSI methods are non-optional against intention

Browse Source 
Change-Id: I051af6dbba1064633722b7e3b49787213343b581
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/418784
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Shuhei Matsumoto 2018-07-10 17:18:01 +09:00 committed by Jim Harris
parent 65165d795d
commit 75646dbe37
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/rpc/iscsi.py
View File

@ -258,7 +258,12 @@ def add_initiators_to_initiator_group(
Returns:
True or False
"""
params = {'tag': tag, 'initiators': initiators, 'netmasks': netmasks}
params = {'tag': tag}
if initiators:
params['initiators'] = initiators
if netmasks:
params['netmasks'] = netmasks
return client.call('add_initiators_to_initiator_group', params)
@ -274,7 +279,12 @@ def delete_initiators_from_initiator_group(
Returns:
True or False
"""
params = {'tag': tag, 'initiators': initiators, 'netmasks': netmasks}
params = {'tag': tag}
if initiators:
params['initiators'] = initiators
if netmasks:
params['netmasks'] = netmasks
return client.call('delete_initiators_from_initiator_group', params)