d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

nvme/test: avoid clang warnings in nvme_ns_cmd_ut

Browse Source 
Initialize the full nvme_namespace structure in prepare_for_test() so
that e.g. ns->id is not used uninitialized.

Also check for request allocation failure - if the request is NULL, we
can't run the rest of the tests that dereference request without
crashing.

Change-Id: I3010ca3e81f153a4d0201498a14a963c2b9e960d
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2015-09-24 12:59:55 -07:00 committed by Gerrit Code Review
parent 4ac57251d5
commit 766afaaacc
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/lib/nvme/unit/nvme_ns_cmd_c/nvme_ns_cmd_ut.c
View File

@ -94,6 +94,7 @@ prepare_for_test(struct nvme_namespace *ns, struct nvme_controller *ctrlr,
uint32_t stripe_size)
{
ctrlr->max_xfer_size = max_xfer_size;
memset(ns, 0, sizeof(*ns));
ns->ctrlr = ctrlr;
ns->sector_size = sector_size;
ns->stripe_size = stripe_size;
@ -122,8 +123,11 @@ split_test(void)
CU_ASSERT(rc == 0);
CU_ASSERT(g_request != NULL);
CU_ASSERT(g_request->num_children == 0);
if (g_request == NULL) {
return; /* can't run the rest of the tests without crashing if this failed */
}
CU_ASSERT(g_request->num_children == 0);
nvme_free_request(g_request);
}
@ -147,6 +151,10 @@ split_test2(void)
CU_ASSERT(rc == 0);
CU_ASSERT(g_request != NULL);
if (g_request == NULL) {
return; /* can't run the rest of the tests without crashing if this failed */
}
CU_ASSERT(g_request->num_children == 2);
child = TAILQ_FIRST(&g_request->children);