d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dpdkbuild: fix CONFIG_RTE_BUILD_SHARED_LIB

Browse Source 
We commented out this build option in our DPDK fork,
but DPDK makefiles check its value specifically against
'n' to set linking flags properly. It's currently unset,
so it fails both == 'n' and == 'y' checks, which fails
the build. Shared lib build has some issues on FreeBSD
right now, so to fix the immediate problem, just define
the shared lib option to 'n' for now.

This matches the original behavior. We've always built
DPDK as a static library.

Change-Id: I5a880b777153cc169c3a135d412aa2014f4de8e0
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463290
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Darek Stojaczyk 2019-07-26 10:59:39 +02:00 committed by Ben Walker
parent ba3db1d2ea
commit 84420e8300
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dpdkbuild/Makefile
View File

@ -40,6 +40,12 @@ DPDK_FRAMEWORK = n
DPDK_OPTS =
DPDK_CFLAGS =
# We commented out this build option in our DPDK fork, but DPDK makefiles check
# its value specifically against 'n' to set linking flags properly. Set it here
# to 'n' for now.
# TODO allow DPDK to be built as shared library
DPDK_OPTS += CONFIG_RTE_BUILD_SHARED_LIB=n
ifeq ($(CONFIG_CRYPTO),y)
DPDK_FRAMEWORK = y
DPDK_OPTS += CONFIG_RTE_LIBRTE_PMD_AESNI_MB=y