d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test: Shellcheck - correct rule: Useless echo?

Browse Source 
Correct shellcheck rule SC2116: Useless echo?
Instead of 'cmd $(echo foo)', just use 'cmd foo'.

Signed-off-by: Maciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: I940eb1ec72ba00ecb89ca770300f5d37e90e8a86
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471452
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Maciej Wawryk 2019-10-16 09:13:42 +02:00 committed by Jim Harris
parent 64d0c173cd
commit a8dee6d1b9
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/check_format.sh
View File

@ -242,7 +242,7 @@ if hash shellcheck 2>/dev/null; then
# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.
SHCK_EXCLUDE="SC1083,SC2002,SC2004,\
SC2010,SC2012,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\
SC2097,SC2098,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\
SC2097,SC2098,SC2115,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\
SC2129,SC2140,SC2142,SC2143,SC2148,SC2152,SC2153,SC2154,SC2155,\
SC2162,SC2164,SC2165,SC2166,SC2167,\
SC2230"

8
test/json_config/json_config.sh
View File

@ -45,13 +45,11 @@ function tgt_check_notification_types() {
timing_enter $FUNCNAME
local ret=0
local enabled_types="
bdev_register
bdev_unregister
"
local enabled_types="bdev_register
bdev_unregister "
get_types=$(tgt_rpc notify_get_types | jq -r '.[]')
if [ "$(echo $enabled_types)" != "$(echo $get_types)" ]; then
if [ $enabled_types != $get_types ]; then
echo "ERROR: expected types:" $enabled_types ", but got:" $get_types
ret=1
fi