From ab8b25793b2c1cea1aba51598675b89b10c5f3df Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Thu, 4 Nov 2021 22:52:45 +0800 Subject: [PATCH] nvme/compliance: add a case to check NPWG and NWOS in IDENTIFY NS Change-Id: Ie5ba6f86d7c99e20f56a11fc1623ce74bf5c6bc9 Signed-off-by: Changpeng Liu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10110 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris --- test/nvme/compliance/nvme_compliance.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/test/nvme/compliance/nvme_compliance.c b/test/nvme/compliance/nvme_compliance.c index 40ea06494a..2440ca11fd 100644 --- a/test/nvme/compliance/nvme_compliance.c +++ b/test/nvme/compliance/nvme_compliance.c @@ -915,7 +915,9 @@ identify_ns(void) struct spdk_nvme_cmd cmd; const struct spdk_nvme_ctrlr_data *cdata; struct spdk_nvme_ns_data *ns_data; + struct spdk_nvme_ns *ns; uint32_t i, active_nsid, inactive_nsid; + uint32_t nows, npwg, max_xfer_size; struct status s; int rc; @@ -979,6 +981,19 @@ identify_ns(void) wait_for_admin_completion(&s, ctrlr); CU_ASSERT(!spdk_nvme_cpl_is_error(&s.cpl)); + + max_xfer_size = spdk_nvme_ctrlr_get_max_xfer_size(ctrlr); + ns = spdk_nvme_ctrlr_get_ns(ctrlr, active_nsid); + SPDK_CU_ASSERT_FATAL(ns != NULL); + + if (ns_data->nsfeat.optperf) { + npwg = ns_data->npwg + 1; + nows = ns_data->nows + 1; + + CU_ASSERT(npwg * spdk_nvme_ns_get_sector_size(ns) <= max_xfer_size); + CU_ASSERT(nows * spdk_nvme_ns_get_sector_size(ns) <= max_xfer_size); + CU_ASSERT(nows % npwg == 0); + } } /* NSID is inactive, valid and should contain zeroed data */