d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lib/event: remove _spdk_scheduler_disable()

Browse Source 
Remove _spdk_scheduler_disable() to avoid confusion as there is
no spdk_scheduler_enable function. Since spdk_scheduler_disable
sets scheduler period to 0, use spdk_scheduler_period_set(0) instead.

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I4f1390a635f80e8b92775aa4be2e37f5b95467f8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7448
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Krzysztof Karas 2021-04-16 10:04:40 +02:00 committed by Tomasz Zawadzki
parent fba4a97dec
commit ae74e70eff
4 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/spdk_internal/event.h
View File

@ -342,11 +342,6 @@ struct spdk_scheduler *_spdk_scheduler_get(void);
*/
void _spdk_scheduler_period_set(uint64_t period);
/**
* Disable the scheduler.
*/
void _spdk_scheduler_disable(void);
/**
* Get period of currently set scheduler.
*/

2
lib/event/app.c
View File

@ -617,7 +617,7 @@ app_stop(void *arg1)
spdk_rpc_finish();
g_spdk_app.stopped = true;
_spdk_scheduler_disable();
_spdk_scheduler_period_set(0);
_start_subsystem_fini(NULL);
}

6
lib/event/reactor.c
View File

@ -154,12 +154,6 @@ _spdk_scheduler_period_set(uint64_t period)
g_scheduler_period = period * spdk_get_ticks_hz() / SPDK_SEC_TO_USEC;
}
void
_spdk_scheduler_disable(void)
{
g_scheduler_period = 0;
}
void
_spdk_scheduler_list_add(struct spdk_scheduler *scheduler)
{

2
test/unit/lib/event/app.c/app_ut.c
View File

@ -58,7 +58,7 @@ DEFINE_STUB_V(spdk_reactors_start, (void));
DEFINE_STUB_V(spdk_reactors_stop, (void *arg1));
DEFINE_STUB(spdk_reactors_init, int, (void), 0);
DEFINE_STUB_V(spdk_reactors_fini, (void));
DEFINE_STUB_V(_spdk_scheduler_disable, (void));
DEFINE_STUB_V(_spdk_scheduler_period_set, (uint64_t period));
bool g_scheduling_in_progress;
static void