From b33a298dd794a6dea8586ceff0014bacc4fdc3f8 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Fri, 27 Jan 2017 15:02:17 -0700 Subject: [PATCH] test/nvmf: drop unnecessary chmod of /dev/nvme-fabrics The autotest.sh script is already running as root, so we should not need to change the permissions on /dev/nvme-fabrics. This block has just been cargo-culted across the various NVMe-oF test scripts. Change-Id: I078ebf102d3fc354e42be9c6f1fc37481ffae291 Signed-off-by: Daniel Verkamp --- test/nvmf/discovery/discovery.sh | 4 ---- test/nvmf/filesystem/filesystem.sh | 4 ---- test/nvmf/fio/fio.sh | 4 ---- test/nvmf/nvme_cli/nvme_cli.sh | 4 ---- 4 files changed, 16 deletions(-) diff --git a/test/nvmf/discovery/discovery.sh b/test/nvmf/discovery/discovery.sh index 96614dd268..b966cb797c 100755 --- a/test/nvmf/discovery/discovery.sh +++ b/test/nvmf/discovery/discovery.sh @@ -37,10 +37,6 @@ bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SI modprobe -v nvme-rdma -if [ -e "/dev/nvme-fabrics" ]; then - chmod a+rw /dev/nvme-fabrics -fi - $rpc_py construct_nvmf_subsystem Direct nqn.2016-06.io.spdk:cnode1 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -p "*" $rpc_py construct_nvmf_subsystem Virtual nqn.2016-06.io.spdk:cnode2 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -s SPDK00000000000001 -n "$bdevs" diff --git a/test/nvmf/filesystem/filesystem.sh b/test/nvmf/filesystem/filesystem.sh index 66eac4d64e..9baa879ae1 100755 --- a/test/nvmf/filesystem/filesystem.sh +++ b/test/nvmf/filesystem/filesystem.sh @@ -32,10 +32,6 @@ bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SI modprobe -v nvme-rdma -if [ -e "/dev/nvme-fabrics" ]; then - chmod a+rw /dev/nvme-fabrics -fi - $rpc_py construct_nvmf_subsystem Direct nqn.2016-06.io.spdk:cnode1 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -p "*" $rpc_py construct_nvmf_subsystem Virtual nqn.2016-06.io.spdk:cnode2 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -s SPDK00000000000001 -n "$bdevs" diff --git a/test/nvmf/fio/fio.sh b/test/nvmf/fio/fio.sh index 05ce4a39e5..71c0e0efd2 100755 --- a/test/nvmf/fio/fio.sh +++ b/test/nvmf/fio/fio.sh @@ -32,10 +32,6 @@ bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SI modprobe -v nvme-rdma -if [ -e "/dev/nvme-fabrics" ]; then - chmod a+rw /dev/nvme-fabrics -fi - $rpc_py construct_nvmf_subsystem Direct nqn.2016-06.io.spdk:cnode1 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -p "*" $rpc_py construct_nvmf_subsystem Virtual nqn.2016-06.io.spdk:cnode2 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -s SPDK00000000000001 -n "$bdevs" diff --git a/test/nvmf/nvme_cli/nvme_cli.sh b/test/nvmf/nvme_cli/nvme_cli.sh index a209248ea8..a149231269 100755 --- a/test/nvmf/nvme_cli/nvme_cli.sh +++ b/test/nvmf/nvme_cli/nvme_cli.sh @@ -31,10 +31,6 @@ bdevs="$bdevs $($rpc_py construct_malloc_bdev $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SI modprobe -v nvme-rdma -if [ -e "/dev/nvme-fabrics" ]; then - chmod a+rw /dev/nvme-fabrics -fi - $rpc_py construct_nvmf_subsystem Direct nqn.2016-06.io.spdk:cnode1 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -p "*" $rpc_py construct_nvmf_subsystem Virtual nqn.2016-06.io.spdk:cnode2 'transport:RDMA traddr:192.168.100.8 trsvcid:4420' '' -s SPDK00000000000001 -n "$bdevs"