d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Fix performance degradation when the ns is formatted to use Protection Information

Browse Source 
Format of namespace is not changed during running but namespace
information is collected by identify command for every IO.

This caused much degradation of performance.

Hence call spdk_nvme_ns_get_data() and hold the pointer to the
buffer in which namespace information is stored  at registration
of namespace and use the pointer in both task_extended_lba_setup_pi()
and task_extended_lba_pi_verify().

Change-Id: I12461ccb763247bbb9ccbe34802805ace67d9400
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/424362
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Shuhei Matsumoto 2018-09-03 14:46:28 +09:00 committed by Jim Harris
parent d70941c3d5
commit cee0fef138
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
examples/nvme/perf/perf.c
View File

@ -83,6 +83,7 @@ struct ns_entry {
uint16_t apptag_mask;
uint16_t apptag;
char name[1024];
const struct spdk_nvme_ns_data *nsdata;
};
static const double g_latency_cutoffs[] = {
@ -267,6 +268,8 @@ register_ns(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_ns *ns)
g_max_io_size_blocks = entry->io_size_blocks;
}
entry->nsdata = spdk_nvme_ns_get_data(ns);
snprintf(entry->name, 44, "%-20.20s (%-20.20s)", cdata->mn, cdata->sn);
g_num_namespaces++;
@ -489,7 +492,6 @@ task_extended_lba_setup_pi(struct ns_entry *entry, struct perf_task *task, uint6
struct spdk_nvme_protection_info *pi;
uint32_t i, md_size, sector_size, pi_offset;
uint16_t crc16;
const struct spdk_nvme_ns_data *nsdata;
task->appmask = 0;
task->apptag = 0;
@ -515,12 +517,11 @@ task_extended_lba_setup_pi(struct ns_entry *entry, struct perf_task *task, uint6
sector_size = spdk_nvme_ns_get_sector_size(entry->u.nvme.ns);
md_size = spdk_nvme_ns_get_md_size(entry->u.nvme.ns);
nsdata = spdk_nvme_ns_get_data(entry->u.nvme.ns);
/* PI locates at the first 8 bytes of metadata,
* doesn't support now
*/
if (nsdata->dps.md_start) {
if (entry->nsdata->dps.md_start) {
return;
}
@ -560,7 +561,6 @@ task_extended_lba_pi_verify(struct ns_entry *entry, struct perf_task *task,
struct spdk_nvme_protection_info *pi;
uint32_t i, md_size, sector_size, pi_offset, ref_tag;
uint16_t crc16, guard, app_tag;
const struct spdk_nvme_ns_data *nsdata;
if (spdk_nvme_ns_get_pi_type(entry->u.nvme.ns) ==
SPDK_NVME_FMT_NVM_PROTECTION_DISABLE) {
@ -569,12 +569,11 @@ task_extended_lba_pi_verify(struct ns_entry *entry, struct perf_task *task,
sector_size = spdk_nvme_ns_get_sector_size(entry->u.nvme.ns);
md_size = spdk_nvme_ns_get_md_size(entry->u.nvme.ns);
nsdata = spdk_nvme_ns_get_data(entry->u.nvme.ns);
/* PI locates at the first 8 bytes of metadata,
* doesn't support now
*/
if (nsdata->dps.md_start) {
if (entry->nsdata->dps.md_start) {
return;
}