d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

framework: fix null deref if no tty

Browse Source 
Change-Id: I859a390e830d43e921244a8a482a63e5c8afe56c
Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
Reviewed-on: https://review.gerrithub.io/424016
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Takeshi Yoshimura 2018-08-30 08:47:56 +00:00 committed by Jim Harris
parent 33ccbba438
commit da395009fa
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/event/app.c
View File

@ -546,6 +546,7 @@ spdk_app_start(struct spdk_app_opts *opts, spdk_event_fn start_fn,
struct spdk_conf *config = NULL; struct spdk_conf *config = NULL;
int rc; int rc;
struct spdk_event *rpc_start_event; struct spdk_event *rpc_start_event;
char *tty;
if (!opts) { if (!opts) {
SPDK_ERRLOG("opts should not be NULL\n"); SPDK_ERRLOG("opts should not be NULL\n");
@ -557,9 +558,11 @@ spdk_app_start(struct spdk_app_opts *opts, spdk_event_fn start_fn,
return 1; return 1;
} }
tty = ttyname(STDERR_FILENO);
if (opts->print_level > SPDK_LOG_WARN && if (opts->print_level > SPDK_LOG_WARN &&
isatty(STDERR_FILENO) && isatty(STDERR_FILENO) &&
!strncmp(ttyname(STDERR_FILENO), "/dev/tty", strlen("/dev/tty"))) { tty &&
!strncmp(tty, "/dev/tty", strlen("/dev/tty"))) {
printf("Warning: printing stderr to console terminal without -q option specified.\n"); printf("Warning: printing stderr to console terminal without -q option specified.\n");
printf("Suggest using --silence-noticelog to disable logging to stderr and\n"); printf("Suggest using --silence-noticelog to disable logging to stderr and\n");
printf("monitor syslog, or redirect stderr to a file.\n"); printf("monitor syslog, or redirect stderr to a file.\n");