d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bdev: remove free_request bdev backend function

Browse Source 
This callback was only used for freeing buffers, but the buffers are now
managed by the bdev core, so none of the free_request callbacks actually
do anything.

Change-Id: Icfe2e6169e829159dda5e3d75a27d8f040de07c6
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-08-29 14:01:32 -07:00 committed by Ben Walker
parent 78b83fd7b2
commit efa06a2bab
5 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/spdk/bdev.h
View File

@ -140,9 +140,6 @@ struct spdk_bdev_fn_table {
/** Process the IO. */ /** Process the IO. */
void (*submit_request)(struct spdk_bdev_io *); void (*submit_request)(struct spdk_bdev_io *);
/** Release buf for read command. */
void (*free_request)(struct spdk_bdev_io *);
/** Check if the block device supports a specific I/O type. */ /** Check if the block device supports a specific I/O type. */
bool (*io_type_supported)(struct spdk_bdev *bdev, enum spdk_bdev_io_type); bool (*io_type_supported)(struct spdk_bdev *bdev, enum spdk_bdev_io_type);
}; };

5
lib/bdev/aio/blockdev_aio.c
View File

@ -273,10 +273,6 @@ static void blockdev_aio_submit_request(struct spdk_bdev_io *bdev_io)
} }
} }
static void blockdev_aio_free_request(struct spdk_bdev_io *bdev_io)
{
}
static bool static bool
blockdev_aio_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type) blockdev_aio_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)
{ {
@ -296,7 +292,6 @@ static struct spdk_bdev_fn_table aio_fn_table = {
.destruct = blockdev_aio_destruct, .destruct = blockdev_aio_destruct,
.check_io = blockdev_aio_check_io, .check_io = blockdev_aio_check_io,
.submit_request = blockdev_aio_submit_request, .submit_request = blockdev_aio_submit_request,
.free_request = blockdev_aio_free_request,
.io_type_supported = blockdev_aio_io_type_supported, .io_type_supported = blockdev_aio_io_type_supported,
}; };

9
lib/bdev/bdev.c
View File

@ -404,13 +404,6 @@ spdk_bdev_cleanup_pending_rbuf_io(struct spdk_bdev *bdev)
} }
} }
static void
spdk_bdev_io_free_request(struct spdk_bdev_io *bdev_io)
{
bdev_io->bdev->fn_table->free_request(bdev_io);
spdk_bdev_put_io(bdev_io);
}
static void static void
__submit_request(spdk_event_t event) __submit_request(spdk_event_t event)
{ {
@ -425,7 +418,7 @@ __submit_request(spdk_event_t event)
} }
bdev->fn_table->submit_request(bdev_io); bdev->fn_table->submit_request(bdev_io);
} else { } else {
spdk_bdev_io_free_request(bdev_io); spdk_bdev_put_io(bdev_io);
} }
} }

5
lib/bdev/malloc/blockdev_malloc.c
View File

@ -250,10 +250,6 @@ static void blockdev_malloc_submit_request(struct spdk_bdev_io *bdev_io)
} }
} }
static void blockdev_malloc_free_request(struct spdk_bdev_io *bdev_io)
{
}
static bool static bool
blockdev_malloc_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type) blockdev_malloc_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)
{ {
@ -274,7 +270,6 @@ static struct spdk_bdev_fn_table malloc_fn_table = {
.destruct = blockdev_malloc_destruct, .destruct = blockdev_malloc_destruct,
.check_io = blockdev_malloc_check_io, .check_io = blockdev_malloc_check_io,
.submit_request = blockdev_malloc_submit_request, .submit_request = blockdev_malloc_submit_request,
.free_request = blockdev_malloc_free_request,
.io_type_supported = blockdev_malloc_io_type_supported, .io_type_supported = blockdev_malloc_io_type_supported,
}; };

5
lib/bdev/nvme/blockdev_nvme.c
View File

@ -272,10 +272,6 @@ static void blockdev_nvme_submit_request(struct spdk_bdev_io *bdev_io)
} }
} }
static void blockdev_nvme_free_request(struct spdk_bdev_io *bdev_io)
{
}
static bool static bool
blockdev_nvme_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type) blockdev_nvme_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)
{ {
@ -302,7 +298,6 @@ static struct spdk_bdev_fn_table nvmelib_fn_table = {
.destruct = blockdev_nvme_destruct, .destruct = blockdev_nvme_destruct,
.check_io = blockdev_nvme_check_io, .check_io = blockdev_nvme_check_io,
.submit_request = blockdev_nvme_submit_request, .submit_request = blockdev_nvme_submit_request,
.free_request = blockdev_nvme_free_request,
.io_type_supported = blockdev_nvme_io_type_supported, .io_type_supported = blockdev_nvme_io_type_supported,
}; };