6c75f0a266
DPDK recently clarified some semantics on the rte_devargs 'data' and 'args' fields. This actually breaks our use of the 'data' field to store the 2 second timeout timestamp for delaying attach to newly inserted devices. Investigating this further, it does not seem our use of the 'data' field was valid - it just happened to work until now. We could use the 'args' field now. But knowing whether to use 'args' or 'data' would then be dependent on the DPDK version. We cannot use RTE_VERSION_NUM to decide, because this is a compile time decision, and it is possible in shared library use cases that we could actually link and execute against a different version of DPDK than we built against. So instead we will create our own env_devargs structure that will store these allowed_at timestamps. Currently it's just a linked list (which is exactly how DPDK does it) - we could make it more optimal with a hash table down the road, but this code only executes when we are doing PCI enumeration so it is not performance critical. Fixes #1904. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I3ee5d65ba90635b5a96b97dd0f4ab72a093fe8f7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7506 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: <dongx.yi@intel.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| led.c | ||
| Makefile | ||