8e85b675fc
When zcero copy send is enabled and used by initiator, it could significantly increase latency in some payloads. To enable more fine graing configuration of zero copy send feature, add new parameters enable_zerocopy_send_server and enable_zerocopy_send_client to spdk_sock_impl_opts to enable/disable zcopy for specific type of sockets. Exisiting enable_zerocopy_send parameter affects all types of sockets. Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Change-Id: I111c75608f8826980a56e210c076ab8ff16ddbdc Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7457 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Karol Latecki <karol.latecki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
210 lines
7.4 KiB
C
210 lines
7.4 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) 2020, 2021 Mellanox Technologies LTD. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "spdk/sock.h"
|
|
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/string.h"
|
|
|
|
#include "spdk/log.h"
|
|
|
|
|
|
static const struct spdk_json_object_decoder rpc_sock_impl_get_opts_decoders[] = {
|
|
{ "impl_name", 0, spdk_json_decode_string, false },
|
|
};
|
|
|
|
static void
|
|
rpc_sock_impl_get_options(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
char *impl_name = NULL;
|
|
struct spdk_sock_impl_opts sock_opts = {};
|
|
struct spdk_json_write_ctx *w;
|
|
size_t len;
|
|
int rc;
|
|
|
|
if (spdk_json_decode_object(params, rpc_sock_impl_get_opts_decoders,
|
|
SPDK_COUNTOF(rpc_sock_impl_get_opts_decoders), &impl_name)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object() failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
len = sizeof(sock_opts);
|
|
rc = spdk_sock_impl_get_opts(impl_name, &sock_opts, &len);
|
|
if (rc) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
spdk_json_write_object_begin(w);
|
|
spdk_json_write_named_uint32(w, "recv_buf_size", sock_opts.recv_buf_size);
|
|
spdk_json_write_named_uint32(w, "send_buf_size", sock_opts.send_buf_size);
|
|
spdk_json_write_named_bool(w, "enable_recv_pipe", sock_opts.enable_recv_pipe);
|
|
spdk_json_write_named_bool(w, "enable_zerocopy_send", sock_opts.enable_zerocopy_send);
|
|
spdk_json_write_named_bool(w, "enable_quickack", sock_opts.enable_quickack);
|
|
spdk_json_write_named_uint32(w, "enable_placement_id", sock_opts.enable_placement_id);
|
|
spdk_json_write_named_bool(w, "enable_zerocopy_send_server", sock_opts.enable_zerocopy_send_server);
|
|
spdk_json_write_named_bool(w, "enable_zerocopy_send_client", sock_opts.enable_zerocopy_send_client);
|
|
spdk_json_write_object_end(w);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
free(impl_name);
|
|
}
|
|
SPDK_RPC_REGISTER("sock_impl_get_options", rpc_sock_impl_get_options,
|
|
SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)
|
|
|
|
struct spdk_rpc_sock_impl_set_opts {
|
|
char *impl_name;
|
|
struct spdk_sock_impl_opts sock_opts;
|
|
};
|
|
|
|
static const struct spdk_json_object_decoder rpc_sock_impl_set_opts_decoders[] = {
|
|
{
|
|
"impl_name", offsetof(struct spdk_rpc_sock_impl_set_opts, impl_name),
|
|
spdk_json_decode_string, false
|
|
},
|
|
{
|
|
"recv_buf_size", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.recv_buf_size),
|
|
spdk_json_decode_uint32, true
|
|
},
|
|
{
|
|
"send_buf_size", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.send_buf_size),
|
|
spdk_json_decode_uint32, true
|
|
},
|
|
{
|
|
"enable_recv_pipe", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_recv_pipe),
|
|
spdk_json_decode_bool, true
|
|
},
|
|
{
|
|
"enable_zerocopy_send", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_zerocopy_send),
|
|
spdk_json_decode_bool, true
|
|
},
|
|
{
|
|
"enable_quickack", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_quickack),
|
|
spdk_json_decode_bool, true
|
|
},
|
|
{
|
|
"enable_placement_id", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_placement_id),
|
|
spdk_json_decode_uint32, true
|
|
},
|
|
{
|
|
"enable_zerocopy_send_server", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_zerocopy_send_server),
|
|
spdk_json_decode_bool, true
|
|
},
|
|
{
|
|
"enable_zerocopy_send_client", offsetof(struct spdk_rpc_sock_impl_set_opts, sock_opts.enable_zerocopy_send_client),
|
|
spdk_json_decode_bool, true
|
|
}
|
|
};
|
|
|
|
static void
|
|
rpc_sock_impl_set_options(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct spdk_rpc_sock_impl_set_opts opts = {};
|
|
size_t len;
|
|
int rc;
|
|
|
|
/* Get type */
|
|
if (spdk_json_decode_object(params, rpc_sock_impl_set_opts_decoders,
|
|
SPDK_COUNTOF(rpc_sock_impl_set_opts_decoders), &opts)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object() failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
/* Retrieve default opts for requested socket implementation */
|
|
len = sizeof(opts.sock_opts);
|
|
rc = spdk_sock_impl_get_opts(opts.impl_name, &opts.sock_opts, &len);
|
|
if (rc) {
|
|
free(opts.impl_name);
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
/* Decode opts */
|
|
if (spdk_json_decode_object(params, rpc_sock_impl_set_opts_decoders,
|
|
SPDK_COUNTOF(rpc_sock_impl_set_opts_decoders), &opts)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object() failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
rc = spdk_sock_impl_set_opts(opts.impl_name, &opts.sock_opts, sizeof(opts.sock_opts));
|
|
if (rc != 0) {
|
|
free(opts.impl_name);
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
free(opts.impl_name);
|
|
}
|
|
SPDK_RPC_REGISTER("sock_impl_set_options", rpc_sock_impl_set_options, SPDK_RPC_STARTUP)
|
|
|
|
static void
|
|
rpc_sock_set_default_impl(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
char *impl_name = NULL;
|
|
int rc;
|
|
|
|
/* Reuse get_opts decoder */
|
|
if (spdk_json_decode_object(params, rpc_sock_impl_get_opts_decoders,
|
|
SPDK_COUNTOF(rpc_sock_impl_get_opts_decoders), &impl_name)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object() failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
rc = spdk_sock_set_default_impl(impl_name);
|
|
if (rc) {
|
|
free(impl_name);
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
return;
|
|
}
|
|
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
free(impl_name);
|
|
}
|
|
SPDK_RPC_REGISTER("sock_set_default_impl", rpc_sock_set_default_impl, SPDK_RPC_STARTUP)
|