11f0a6ec0f
When nvmf_tgt application shuts down, it stops all subsystems, than destroyes poll groups and than destroyes nvmf_tgt. Part of nvmf_tgt destruction is destruction of subsystems and this process may require cross thread communication but since poll groups and threads are already destroyed, we may get segfaults. One possible solution is to change the order and destroy nvmf_tgt before destroying poll groups but it doesn't work since nvmf_tgt is registered as io_device and poll groups have its channel, so it can't be destroyed while poll groups exist. This patch adds a new state to nvmf_tgt state machine which destroys all subsystems before destroying poll groups and nvmf_tgt. It guarantees that all threads exist when subsystems are destroyed. Also rename state NVMF_TGT_FINI_FREE_RESOURCES to NVMF_TGT_FINI_DESTROY_TARGET, the new name better reflects the purpose of this state. Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Change-Id: I08971d78cc9ad70d43cd43c346fd74d35c8bda60 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9668 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> |
||
|---|---|---|
| .. | ||
| accel | ||
| bdev | ||
| blob | ||
| blobfs | ||
| env_dpdk | ||
| event | ||
| scheduler | ||
| sock | ||
| Makefile | ||