1b6d1c80f9
This patch improves management of base->management_channel in code and fixes potential issue described below. In situation when we want to create configuration like this: $rpc_py bdev_ocf_create C1 wt Malloc NonExisting $rpc_py bdev_ocf_create C2 wt Malloc Core In current code on C1 vbdev creation we are creating not fully initialized vbdev_ocf_base for cache (without management channel). On C2 creation, because in vbdev_ocf_volume_open we are looking for right base by name, we can grab cache base from C1 and then, there is possibility, to hit segmentation fault due to uninitialized mangament_channel. This patch moves initialisation of managemnet channel to attach base function and thanks to that we have guarrnte that each copy of cache base (we have copy in each parent in case of multicore cache) are valid. Signed-off-by: Marcin Dziegielewski <marcin.dziegielewski@intel.com> Change-Id: Iab1ced3a4bf8ba0fec947bbf77b55dc3620a58a7 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468131 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Vitaliy Mysak <vitaliy.mysak@intel.com>
66 lines
2.5 KiB
C
66 lines
2.5 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef VBDEV_OCF_CTX_H
|
|
#define VBDEV_OCF_CTX_H
|
|
|
|
#include <ocf/ocf.h>
|
|
#include "spdk/thread.h"
|
|
|
|
extern ocf_ctx_t vbdev_ocf_ctx;
|
|
|
|
#define OCF_WRITE_FLUSH 11
|
|
|
|
#define SPDK_OBJECT 1
|
|
|
|
/* Context of cache instance */
|
|
struct vbdev_ocf_cache_ctx {
|
|
ocf_queue_t mngt_queue;
|
|
ocf_queue_t cleaner_queue;
|
|
pthread_mutex_t lock;
|
|
env_atomic refcnt;
|
|
};
|
|
|
|
void vbdev_ocf_cache_ctx_put(struct vbdev_ocf_cache_ctx *ctx);
|
|
void vbdev_ocf_cache_ctx_get(struct vbdev_ocf_cache_ctx *ctx);
|
|
|
|
int vbdev_ocf_ctx_init(void);
|
|
void vbdev_ocf_ctx_cleanup(void);
|
|
|
|
/* Thread safe queue creation and deletion
|
|
* These are wrappers for original ocf_queue_create() and ocf_queue_put() */
|
|
int vbdev_ocf_queue_create(ocf_cache_t cache, ocf_queue_t *queue, const struct ocf_queue_ops *ops);
|
|
void vbdev_ocf_queue_put(ocf_queue_t queue);
|
|
|
|
#endif
|