numam-spdk
Go to file
Shuhei Matsumoto 22adcd1487 lib/iscsi: Fix orphaned PDUs when freeing PDUs and tasks for LUN hotplug
In _iscsi_conn_free_tasks(), we had parsed conn->write_pdu_list
and then parsed conn->queued_datain_tasks.  However when we parsed
conn->write_pdu_list, if there was any task in conn->queued_datain_tasks,
some PDUs were inserted conn->write_pdu_list.  Hence after parsing
conn->write_pdu_list, new PDUs were in conn->write_pdu_list as orphan.
Then orphaned PDUs were freed later but LUN was already freed and
critical failure occurred.

This patch swaps the order of conn->queued_datain_tasks and
conn->write_pdu_list, and add comment to explain the change.

Additionally, this patch adds unit test which fails if it runs
without this fix.

Fixes issue #1030.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Icb0ffbbbac70792a62939dc55a69df05d2ab9128
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475453
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-12-05 12:21:09 +00:00
.githooks githooks: limit the number of threads for pre-push hook 2019-08-07 12:30:38 +00:00
app env: add spdk_pci_device_get_type 2019-10-24 17:04:04 +00:00
build/lib build: consolidate library outputs in build/lib 2016-11-17 13:15:09 -07:00
doc bdev/rpc: Add current ticks to bdev_get_iostat RPC 2019-11-21 08:05:23 +00:00
dpdk@b5c9624957 dpdk: update submodule to include vhost compile fix 2019-10-31 04:54:10 +00:00
dpdkbuild Enable DPDK shared object build with SPDK shared object build. 2019-08-07 12:28:48 +00:00
etc/spdk nvmf/fc: Add listen address support in FC transport 2019-10-17 16:29:04 +00:00
examples test/nvmf: add a test for bad discovery ctrlr. 2019-11-18 13:06:49 +00:00
go go: empty Go package 2018-06-28 18:15:51 +00:00
include env: Check supported iommu address width before using iova-mode=va 2019-11-27 07:08:32 +00:00
intel-ipsec-mb@489ec6082a ipsec: move to version 0.52 2019-04-24 22:49:11 +00:00
ipsecbuild Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
isa-l@f3993f5c0b spdk: Upgrade isa-l to add support for aarch64 2019-11-04 12:26:00 +00:00
isalbuild Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
lib lib/iscsi: Fix orphaned PDUs when freeing PDUs and tasks for LUN hotplug 2019-12-05 12:21:09 +00:00
mk bdev/zone: Register/unregister zoned bdev 2019-11-15 20:27:14 +00:00
module bdev/nvme: explain the "populated" flag with a comment 2019-12-02 11:20:05 +00:00
ocf@6fb1a697a4 lib/bdev/ocf: update of ocf library to version 19.06 2019-10-22 17:22:41 +00:00
pkg version: 19.10 pre 2019-07-31 08:25:59 +00:00
scripts test: Shellcheck - move rule SC2120 to permanent exception list. 2019-12-04 15:22:07 +00:00
shared_lib Revert "shared_lib: add as_needed to the libspdk.so linker script" 2019-07-18 04:12:05 +00:00
test lib/iscsi: Fix orphaned PDUs when freeing PDUs and tasks for LUN hotplug 2019-12-05 12:21:09 +00:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore makefile: Add cc.flags.mk to .gitignore list 2019-05-15 18:44:59 +00:00
.gitmodules ocf: add ocf submodule 2019-02-27 17:26:51 +00:00
autobuild.sh test: Shellcheck - correct rule: Use find... 2019-11-27 07:08:57 +00:00
autopackage.sh test: fix SC2103 errors on older shellcheck. 2019-11-18 13:06:49 +00:00
autorun_post.py Check file permissions in the check_format script 2018-10-04 23:08:12 +00:00
autorun.sh test: Run autotest.sh with sudo -E 2019-07-03 04:15:18 +00:00
autotest.sh Add bdev_raid.sh to per-patch tests 2019-11-25 14:34:30 +00:00
CHANGELOG.md pipe: Add a utility for buffering data from sockets 2019-11-20 09:35:32 +00:00
CONFIG lib/nvme: add NVMe character device 2019-10-24 23:43:59 +00:00
configure spdk: enable isa-l by default aarch64 2019-11-18 13:14:41 +00:00
CONTRIBUTING.md Add CONTRIBUTING.md 2017-09-05 13:25:45 -04:00
ISSUE_TEMPLATE.md github: Add issue tracker template 2018-04-19 13:50:08 -04:00
LICENSE Remove year from copyright headers. 2016-01-28 08:54:18 -07:00
Makefile mk: move the bdev modules under module directory. 2019-08-22 16:29:49 +00:00
README.md doc: update doc with instructions for building shared lib 2018-10-26 20:41:24 +00:00

Storage Performance Development Kit

Build Status

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme:

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh.

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./test/unit/unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has only been tested on MacOS and Ubuntu 16.04.2 LTS with the VirtualBox provider. The VirtualBox Extension Pack must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in the Makefile configuration file in the root of the repository. CONFIG contains the base settings for the configure script. This script generates a new file, mk/config.mk, that contains final build settings. For advanced configuration, there are a number of additional options to configure that may be used, or mk/config.mk can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to mk/config.mk with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overridden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. Note, this includes the ability to build not only from DPDK sources, but also just with the includes and libraries installed via the dpdk and dpdk-devel packages. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the values in mk/config.mk. This can be useful if you, for example, generate a mk/config.mk using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Shared libraries

By default, the build of the SPDK yields static libraries against which the SPDK applications and examples are linked. Configure option --with-shared provides the ability to produce SPDK shared libraries, in addition to the default static ones. Use of this flag also results in the SPDK executables linked to the shared versions of libraries. SPDK shared libraries by default, are located in ./build/lib. This includes the single SPDK shared lib encompassing all of the SPDK static libs (libspdk.so) as well as individual SPDK shared libs corresponding to each of the SPDK static ones.

In order to start a SPDK app linked with SPDK shared libraries, make sure to do the following steps:

  • run ldconfig specifying the directory containing SPDK shared libraries
  • provide proper LD_LIBRARY_PATH

Linux:

./configure --with-shared
make
ldconfig -v -n ./build/lib
LD_LIBRARY_PATH=./build/lib/ ./app/spdk_tgt/spdk_tgt

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activities, please refer to spdk.io