971f07b9fb
John Kariuki tested this patch on a system with several Intel P5800X Optane SSDs, to determine the performance impact of adding these two spdk_trace_records() in the main NVMe I/O path. The pathological case (512B random reads on a single Xeon core) decreased from 13.10M to 12.88M, or 1.7%. Normal workloads (4KB+) would incur a smaller penalty since the I/O rate would be much lower - maybe even unnoticeable.. This is a really valuable tracepoint to have enabled by default, so I think this small amount of degradation is acceptable. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie2543cadf3541eb74398d31ac0f495522ab49ec0 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9303 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
||
|---|---|---|
| .. | ||
| nvme.libtest.mk | ||
| spdk_blank.map | ||
| spdk.app_cxx.mk | ||
| spdk.app_vars.mk | ||
| spdk.app.mk | ||
| spdk.common.mk | ||
| spdk.deps.mk | ||
| spdk.fio.mk | ||
| spdk.lib_deps.mk | ||
| spdk.lib.mk | ||
| spdk.mock.unittest.mk | ||
| spdk.modules.mk | ||
| spdk.nvmecli.mk | ||
| spdk.subdirs.mk | ||
| spdk.unittest.mk | ||