130d278adf
Fixes condition where blobstore was prematurely calling the application callback on spdk_bs_unload(), if the application tries to do something too quickly bad things happen. To avoid application changes with how the g_devlist_mutex is held, it is no longer held while calling _spdk_io_device_attempt_free() because the app unload CB is called from that function and may want to call spdk_io_device_unregister() from its unload CB. So the lock is now held and releases strictly around the list its protecting which allows the CB from _spdk_io_device_attempt_free() to be called without issue. Change-Id: Ib451cfe6b33ea0c3f9e66c86785316f9d88837c7 Signed-off-by: Paul Luse <paul.e.luse@intel.com> Reviewed-on: https://review.gerrithub.io/377872 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
378 lines
11 KiB
C
378 lines
11 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "blobstore.h"
|
|
#include "request.h"
|
|
|
|
#include "spdk/io_channel.h"
|
|
#include "spdk/queue.h"
|
|
|
|
#include "spdk_internal/log.h"
|
|
|
|
void
|
|
spdk_bs_call_cpl(struct spdk_bs_cpl *cpl, int bserrno)
|
|
{
|
|
switch (cpl->type) {
|
|
case SPDK_BS_CPL_TYPE_BS_BASIC:
|
|
cpl->u.bs_basic.cb_fn(cpl->u.bs_basic.cb_arg,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_BS_HANDLE:
|
|
cpl->u.bs_handle.cb_fn(cpl->u.bs_handle.cb_arg,
|
|
cpl->u.bs_handle.bs,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_BLOB_BASIC:
|
|
cpl->u.blob_basic.cb_fn(cpl->u.blob_basic.cb_arg,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_BLOBID:
|
|
cpl->u.blobid.cb_fn(cpl->u.blobid.cb_arg,
|
|
cpl->u.blobid.blobid,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_BLOB_HANDLE:
|
|
cpl->u.blob_handle.cb_fn(cpl->u.blob_handle.cb_arg,
|
|
cpl->u.blob_handle.blob,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_NESTED_SEQUENCE:
|
|
cpl->u.nested_seq.cb_fn(cpl->u.nested_seq.cb_arg,
|
|
cpl->u.nested_seq.parent,
|
|
bserrno);
|
|
break;
|
|
case SPDK_BS_CPL_TYPE_NONE:
|
|
/* this completion's callback is handled elsewhere */
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void
|
|
spdk_bs_request_set_complete(struct spdk_bs_request_set *set)
|
|
{
|
|
struct spdk_bs_cpl cpl = set->cpl;
|
|
int bserrno = set->bserrno;
|
|
|
|
TAILQ_INSERT_TAIL(&set->channel->reqs, set, link);
|
|
|
|
spdk_bs_call_cpl(&cpl, bserrno);
|
|
}
|
|
|
|
static void
|
|
spdk_bs_sequence_completion(struct spdk_io_channel *channel, void *cb_arg, int bserrno)
|
|
{
|
|
struct spdk_bs_request_set *set = cb_arg;
|
|
|
|
set->bserrno = bserrno;
|
|
set->u.sequence.cb_fn((spdk_bs_sequence_t *)set, set->u.sequence.cb_arg, bserrno);
|
|
}
|
|
|
|
spdk_bs_sequence_t *
|
|
spdk_bs_sequence_start(struct spdk_io_channel *_channel,
|
|
struct spdk_bs_cpl *cpl)
|
|
{
|
|
struct spdk_bs_channel *channel;
|
|
struct spdk_bs_request_set *set;
|
|
|
|
channel = spdk_io_channel_get_ctx(_channel);
|
|
|
|
set = TAILQ_FIRST(&channel->reqs);
|
|
if (!set) {
|
|
return NULL;
|
|
}
|
|
TAILQ_REMOVE(&channel->reqs, set, link);
|
|
|
|
set->cpl = *cpl;
|
|
set->bserrno = 0;
|
|
set->channel = channel;
|
|
|
|
set->cb_args.cb_fn = spdk_bs_sequence_completion;
|
|
set->cb_args.cb_arg = set;
|
|
set->cb_args.channel = channel->dev_channel;
|
|
|
|
return (spdk_bs_sequence_t *)set;
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_read(spdk_bs_sequence_t *seq, void *payload,
|
|
uint64_t lba, uint32_t lba_count,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Reading %u blocks from LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->read(channel->dev, channel->dev_channel, payload, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_write(spdk_bs_sequence_t *seq, void *payload,
|
|
uint64_t lba, uint32_t lba_count,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Writing %u blocks to LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->write(channel->dev, channel->dev_channel, payload, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_readv(spdk_bs_sequence_t *seq, struct iovec *iov, int iovcnt,
|
|
uint64_t lba, uint32_t lba_count,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Reading %u blocks from LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->readv(channel->dev, channel->dev_channel, iov, iovcnt, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_writev(spdk_bs_sequence_t *seq, struct iovec *iov, int iovcnt,
|
|
uint64_t lba, uint32_t lba_count,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Writing %u blocks to LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->writev(channel->dev, channel->dev_channel, iov, iovcnt, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_flush(spdk_bs_sequence_t *seq,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Flushing\n");
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->flush(channel->dev, channel->dev_channel,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_unmap(spdk_bs_sequence_t *seq,
|
|
uint64_t lba, uint32_t lba_count,
|
|
spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Unmapping %u blocks at LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.sequence.cb_fn = cb_fn;
|
|
set->u.sequence.cb_arg = cb_arg;
|
|
|
|
channel->dev->unmap(channel->dev, channel->dev_channel, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_sequence_finish(spdk_bs_sequence_t *seq, int bserrno)
|
|
{
|
|
if (bserrno != 0) {
|
|
seq->bserrno = bserrno;
|
|
}
|
|
spdk_bs_request_set_complete((struct spdk_bs_request_set *)seq);
|
|
}
|
|
|
|
static void
|
|
spdk_bs_batch_completion(struct spdk_io_channel *_channel,
|
|
void *cb_arg, int bserrno)
|
|
{
|
|
struct spdk_bs_request_set *set = cb_arg;
|
|
|
|
set->u.batch.outstanding_ops--;
|
|
if (bserrno != 0) {
|
|
set->bserrno = bserrno;
|
|
}
|
|
|
|
if (set->u.batch.outstanding_ops == 0 && set->u.batch.batch_closed) {
|
|
if (set->u.batch.cb_fn) {
|
|
set->cb_args.cb_fn = spdk_bs_sequence_completion;
|
|
set->u.batch.cb_fn((spdk_bs_sequence_t *)set, set->u.batch.cb_arg, bserrno);
|
|
} else {
|
|
spdk_bs_request_set_complete(set);
|
|
}
|
|
}
|
|
}
|
|
|
|
spdk_bs_batch_t *
|
|
spdk_bs_batch_open(struct spdk_io_channel *_channel,
|
|
struct spdk_bs_cpl *cpl)
|
|
{
|
|
struct spdk_bs_channel *channel;
|
|
struct spdk_bs_request_set *set;
|
|
|
|
channel = spdk_io_channel_get_ctx(_channel);
|
|
|
|
set = TAILQ_FIRST(&channel->reqs);
|
|
if (!set) {
|
|
return NULL;
|
|
}
|
|
TAILQ_REMOVE(&channel->reqs, set, link);
|
|
|
|
set->cpl = *cpl;
|
|
set->bserrno = 0;
|
|
set->channel = channel;
|
|
|
|
set->u.batch.cb_fn = NULL;
|
|
set->u.batch.cb_arg = NULL;
|
|
set->u.batch.outstanding_ops = 0;
|
|
set->u.batch.batch_closed = 0;
|
|
|
|
set->cb_args.cb_fn = spdk_bs_batch_completion;
|
|
set->cb_args.cb_arg = set;
|
|
set->cb_args.channel = channel->dev_channel;
|
|
|
|
return (spdk_bs_batch_t *)set;
|
|
}
|
|
|
|
void
|
|
spdk_bs_batch_read(spdk_bs_batch_t *batch, void *payload,
|
|
uint64_t lba, uint32_t lba_count)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Reading %u blocks from LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.batch.outstanding_ops++;
|
|
channel->dev->read(channel->dev, channel->dev_channel, payload, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_batch_write(spdk_bs_batch_t *batch, void *payload,
|
|
uint64_t lba, uint32_t lba_count)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Writing %u blocks to LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.batch.outstanding_ops++;
|
|
channel->dev->write(channel->dev, channel->dev_channel, payload, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_batch_flush(spdk_bs_batch_t *batch)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Flushing\n");
|
|
|
|
set->u.batch.outstanding_ops++;
|
|
channel->dev->flush(channel->dev, channel->dev_channel,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_batch_unmap(spdk_bs_batch_t *batch,
|
|
uint64_t lba, uint32_t lba_count)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;
|
|
struct spdk_bs_channel *channel = set->channel;
|
|
|
|
SPDK_DEBUGLOG(SPDK_TRACE_BLOB_RW, "Unmapping %u blocks at LBA %lu\n", lba_count, lba);
|
|
|
|
set->u.batch.outstanding_ops++;
|
|
channel->dev->unmap(channel->dev, channel->dev_channel, lba, lba_count,
|
|
&set->cb_args);
|
|
}
|
|
|
|
void
|
|
spdk_bs_batch_close(spdk_bs_batch_t *batch)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;
|
|
|
|
set->u.batch.batch_closed = 1;
|
|
|
|
if (set->u.batch.outstanding_ops == 0) {
|
|
if (set->u.batch.cb_fn) {
|
|
set->cb_args.cb_fn = spdk_bs_sequence_completion;
|
|
set->u.batch.cb_fn((spdk_bs_sequence_t *)set, set->u.batch.cb_arg, set->bserrno);
|
|
} else {
|
|
spdk_bs_request_set_complete(set);
|
|
}
|
|
}
|
|
}
|
|
|
|
spdk_bs_batch_t *
|
|
spdk_bs_sequence_to_batch(spdk_bs_sequence_t *seq, spdk_bs_sequence_cpl cb_fn, void *cb_arg)
|
|
{
|
|
struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq;
|
|
|
|
set->u.batch.cb_fn = cb_fn;
|
|
set->u.batch.cb_arg = cb_arg;
|
|
set->u.batch.outstanding_ops = 0;
|
|
set->u.batch.batch_closed = 0;
|
|
|
|
set->cb_args.cb_fn = spdk_bs_batch_completion;
|
|
|
|
return set;
|
|
}
|
|
|
|
SPDK_LOG_REGISTER_TRACE_FLAG("blob_rw", SPDK_TRACE_BLOB_RW);
|