2ea005f0a9
Orderings of portal group create operation are diferrent between config file and JSON-RPC. Unification is necessary for correct concurrency control and the global accept poller like NVMf-tgt. Hence unify the ordering of operations in this patch. Common ordering of portal group create operation between configuration file and JSON-RPC after this patch is the following: - create a portal group - create portals - add the portals to the portal group - open the portals of the portal group - add the portal group to the global portal group list After this patch, the gap between listening socket and accepting socket will be increased a little when portals groups are creted by config file. However this will cause no issue because of the TCP backlog and resend mechanism. Besides, necessary concurrency control is added and minor refactoring is done. About portal group delete operation, orderings of application shutdown and JSON-RPC are already unified. Change-Id: I1db7ef4400388127134d7734c68e138a4573b734 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/396848 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
79 lines
3.2 KiB
C
79 lines
3.2 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_PORTAL_GRP_H
|
|
#define SPDK_PORTAL_GRP_H
|
|
|
|
#include "spdk/conf.h"
|
|
#include "spdk/cpuset.h"
|
|
|
|
struct spdk_iscsi_portal {
|
|
struct spdk_iscsi_portal_grp *group;
|
|
char *host;
|
|
char *port;
|
|
int sock;
|
|
struct spdk_cpuset *cpumask;
|
|
struct spdk_poller *acceptor_poller;
|
|
TAILQ_ENTRY(spdk_iscsi_portal) per_pg_tailq;
|
|
TAILQ_ENTRY(spdk_iscsi_portal) g_tailq;
|
|
};
|
|
|
|
struct spdk_iscsi_portal_grp {
|
|
int ref;
|
|
int tag;
|
|
TAILQ_ENTRY(spdk_iscsi_portal_grp) tailq;
|
|
TAILQ_HEAD(, spdk_iscsi_portal) head;
|
|
};
|
|
|
|
/* SPDK iSCSI Portal Group management API */
|
|
|
|
struct spdk_iscsi_portal *spdk_iscsi_portal_create(const char *host, const char *port,
|
|
const char *cpumask);
|
|
void spdk_iscsi_portal_destroy(struct spdk_iscsi_portal *p);
|
|
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_create(int tag);
|
|
void spdk_iscsi_portal_grp_add_portal(struct spdk_iscsi_portal_grp *pg,
|
|
struct spdk_iscsi_portal *p);
|
|
void spdk_iscsi_portal_grp_destroy(struct spdk_iscsi_portal_grp *pg);
|
|
void spdk_iscsi_portal_grp_release(struct spdk_iscsi_portal_grp *pg);
|
|
int spdk_iscsi_portal_grp_array_create(void);
|
|
void spdk_iscsi_portal_grp_array_destroy(void);
|
|
int spdk_iscsi_portal_grp_register(struct spdk_iscsi_portal_grp *pg);
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_unregister(int tag);
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_find_by_tag(int tag);
|
|
int spdk_iscsi_portal_grp_open(struct spdk_iscsi_portal_grp *pg);
|
|
|
|
void spdk_iscsi_portal_grp_close_all(void);
|
|
#endif // SPDK_PORTAL_GRP_H
|