cff52180c4
Most of our bash test scripts source autotest_common.sh to be able to use some autotest-specific functions like timing_enter(). The same test scripts allow specifying custom command line parameters without actually realizing that those parameters can be potentially picked up by autotest_common.sh as well. For example, if particular nvmf tests are run in "isolation" mode by being executed with the first param set to "iso", and there is a file named "iso" in the current dir, that file will be sourced. This could be bad. In this patch we stop sourcing or even processing $1 in autotest_common.sh. Instead, the test configuration will be sourced just once from autobuild.sh, autopackage.sh and autotest.sh. If the user wants to run particular test scripts manually, he should source an SPDK test configuration by himself - manually as well. In most cases he won't even have two, as only a few test scripts depend on SPDK_* variables. Note that we still have to setup the default values for SPDK_* variables in autotest_common.sh because some of our test scripts actually depend on them: > if [ $SPDK_TEST_RBD -eq 1 ]; then ... Because it lacks any type of quotes around SPDK_TEST_RBD, it will print the following message when that variable is unset: > /bin/bash: line 0: [: -eq: unary operator expected It doesn't trigger any error ($? == 0), but can be still a bit misleading in the script output. Change-Id: I350045d8582d66fe1ed7697d4bcbba324cb541ad Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453876 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
97 lines
2.2 KiB
Bash
Executable File
97 lines
2.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
set -xe
|
|
|
|
# If the configuration of tests is not provided, no tests will be carried out.
|
|
if [[ ! -f $1 ]]; then
|
|
echo "ERROR: SPDK test configuration not specified"
|
|
exit 1
|
|
fi
|
|
|
|
source "$1"
|
|
|
|
rootdir=$(readlink -f $(dirname $0))
|
|
source "$rootdir/test/common/autotest_common.sh"
|
|
|
|
out=$PWD
|
|
|
|
MAKEFLAGS=${MAKEFLAGS:--j16}
|
|
cd $rootdir
|
|
|
|
timing_enter porcelain_check
|
|
$MAKE clean
|
|
|
|
if [ `git status --porcelain --ignore-submodules | wc -l` -ne 0 ]; then
|
|
echo make clean left the following files:
|
|
git status --porcelain --ignore-submodules
|
|
exit 1
|
|
fi
|
|
timing_exit porcelain_check
|
|
|
|
if [ $RUN_NIGHTLY -eq 0 ]; then
|
|
timing_finish
|
|
exit 0
|
|
fi
|
|
|
|
timing_enter autopackage
|
|
|
|
spdk_pv=spdk-$(date +%Y_%m_%d)
|
|
spdk_tarball=${spdk_pv}.tar
|
|
dpdk_pv=dpdk-$(date +%Y_%m_%d)
|
|
dpdk_tarball=${dpdk_pv}.tar
|
|
ipsec_pv=ipsec-$(date +%Y_%m_%d)
|
|
ipsec_tarball=${ipsec_pv}.tar
|
|
isal_pv=isal-$(date +%Y_%m_%d)
|
|
isal_tarball=${isal_pv}.tar
|
|
ocf_pv=ocf-$(date +%Y_%m_%d)
|
|
ocf_tarball=${ocf_pv}.tar
|
|
|
|
find . -iname "spdk-*.tar* dpdk-*.tar* ipsec-*.tar* isal-*.tar*" -delete
|
|
git archive HEAD^{tree} --prefix=${spdk_pv}/ -o ${spdk_tarball}
|
|
|
|
# Build from packaged source
|
|
tmpdir=$(mktemp -d)
|
|
echo "tmpdir=$tmpdir"
|
|
tar -C "$tmpdir" -xf $spdk_tarball
|
|
|
|
if [ -z "$WITH_DPDK_DIR" ]; then
|
|
cd dpdk
|
|
git archive HEAD^{tree} --prefix=dpdk/ -o ../${dpdk_tarball}
|
|
cd ..
|
|
tar -C "$tmpdir/${spdk_pv}" -xf $dpdk_tarball
|
|
fi
|
|
|
|
if [ -d "intel-ipsec-mb" ]; then
|
|
cd intel-ipsec-mb
|
|
git archive HEAD^{tree} --prefix=intel-ipsec-mb/ -o ../${ipsec_tarball}
|
|
cd ..
|
|
tar -C "$tmpdir/${spdk_pv}" -xf $ipsec_tarball
|
|
fi
|
|
|
|
if [ -d "isa-l" ]; then
|
|
cd isa-l
|
|
git archive HEAD^{tree} --prefix=isa-l/ -o ../${isal_tarball}
|
|
cd ..
|
|
tar -C "$tmpdir/${spdk_pv}" -xf $isal_tarball
|
|
fi
|
|
|
|
if [ -d "ocf" ]; then
|
|
cd ocf
|
|
git archive HEAD^{tree} --prefix=ocf/ -o ../${ocf_tarball}
|
|
cd ..
|
|
tar -C "$tmpdir/${spdk_pv}" -xf $ocf_tarball
|
|
fi
|
|
|
|
(
|
|
cd "$tmpdir"/spdk-*
|
|
# use $config_params to get the right dependency options, but disable coverage and ubsan
|
|
# explicitly since they are not needed for this build
|
|
./configure $config_params --disable-debug --enable-werror --disable-coverage --disable-ubsan
|
|
time $MAKE ${MAKEFLAGS}
|
|
)
|
|
rm -rf "$tmpdir"
|
|
|
|
timing_exit autopackage
|
|
|
|
timing_finish
|