d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
404d27263f
numam-spdk/lib/iscsi
History
Shuhei Matsumoto f341e69a50 iscsi: Use not malloc'ed but fixed size string for portal porta number 
Using malloc'ed string for string in iSCSI target has caused
scan-build error.

Define maximum port number of portal to be 32 and use fixed size string
whose size is 33 for spdk_iscsi_portal_grp::port.

This change will reduce the potential malloc failure.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ie1fcdbd45ce000a9c1c53761195697555b8d030a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459709
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-07-01 05:03:07 +00:00
..
conn.c iscsi: return the correct error code in spdk_iscsi_read_pdu 2019-06-13 06:04:31 +00:00
conn.h iscsi: Deprecate MinConnectionsPerCore 2019-05-06 17:10:48 +00:00
init_grp.c iscsi: Use not malloc'ed but fixed size string for initiator address 2019-07-01 05:03:07 +00:00
init_grp.h iscsi: Use not malloc'ed but fixed size string for initiator address 2019-07-01 05:03:07 +00:00
iscsi_rpc.c lib/iscsi: Make iscsi_shutdown_tgt_node_by_name asynchronous 2019-04-22 16:00:42 +00:00
iscsi_subsystem.c iscsi: Simplify include relationships to avoid cyclic inclusion 2019-07-01 05:03:07 +00:00
iscsi.c iscsi: Use not malloc'ed but fixed size string for target name and alias 2019-07-01 05:03:07 +00:00
iscsi.h iscsi: Simplify include relationships to avoid cyclic inclusion 2019-07-01 05:03:07 +00:00
Makefile iscsi: Move acceptor into portal_grp 2019-05-16 23:23:45 +00:00
md5.c astyle: enforce braces around single-line statements 2017-12-11 11:19:32 -05:00
md5.h include: Move the remainder of the code base to stdinc.h 2017-05-08 13:20:36 -07:00
param.c iscsi: Remove the prefix spdk_ from names of private functions 2019-04-01 00:52:56 +00:00
param.h include: Move the remainder of the code base to stdinc.h 2017-05-08 13:20:36 -07:00
portal_grp.c iscsi: Use not malloc'ed but fixed size string for portal porta number 2019-07-01 05:03:07 +00:00
portal_grp.h iscsi: Use not malloc'ed but fixed size string for portal porta number 2019-07-01 05:03:07 +00:00
task.c iscsi: Remove the prefix spdk_ from names of private functions 2019-04-01 00:52:56 +00:00
task.h iscsi: Propagate SCSI error status to split SCSI read/write commands 2018-12-11 16:37:55 +00:00
tgt_node.c iscsi: Use not malloc'ed but fixed size string for target name and alias 2019-07-01 05:03:07 +00:00
tgt_node.h iscsi: Use not malloc'ed but fixed size string for target name and alias 2019-07-01 05:03:07 +00:00