numam-spdk
Go to file
Sylvain Didelot 4cd97383cc nvme_cuse: Fix NULL pointer dereference triggered by unit test
The unit test test_nvme_cuse_stop() manually creates 2 cuse devices
and executes nvme_cuse_stop(). Problem is that the Fuse session is
never initialized for those 2 cuse devices, causing cuse_nvme_ns_stop()
to access 'ns_device->session', which is a NULL pointer.

This bug is detected by ASAN as follows:

==77298==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000180 (pc 0x7fdac6d7d40e bp 0x000000000000 sp 0x7fff74768320 T0)
==77298==The signal is caused by a READ memory access.
==77298==Hint: address points to the zero page.
    0 0x7fdac6d7d40e in fuse_session_destroy (/usr/lib64/libfuse3.so.3+0x1640e)
    1 0x40dc7a in cuse_nvme_ns_stop /home/vagrant/spdk_repo/spdk/lib/nvme/nvme_cuse.c:851
    2 0x40df59 in cuse_nvme_ctrlr_stop /home/vagrant/spdk_repo/spdk/lib/nvme/nvme_cuse.c:923
    3 0x40f103 in nvme_cuse_stop /home/vagrant/spdk_repo/spdk/lib/nvme/nvme_cuse.c:1094
    4 0x415803 in test_nvme_cuse_stop /home/vagrant/spdk_repo/spdk/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c:393
    5 0x7fdac724c1a6  (/usr/lib64/libcunit.so.1+0x41a6)
    6 0x7fdac724c528  (/usr/lib64/libcunit.so.1+0x4528)
    7 0x7fdac724d456 in CU_run_all_tests (/usr/lib64/libcunit.so.1+0x5456)
    8 0x415a4e in main /home/vagrant/spdk_repo/spdk/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c:415
    9 0x7fdac62351e1 in __libc_start_main (/usr/lib64/libc.so.6+0x281e1)
    10 0x403ddd in _start (/home/vagrant/spdk_repo/spdk/test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut+0x403ddd)

The fix is to call fuse_session_destroy() only if the fuse session is != NULL.

Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
Change-Id: I41881243227d83e8d1e6b90e72c1b6d62ccd98d3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10225
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2021-11-17 10:58:50 +00:00
.githooks githooks/prepush: remove clang 2020-06-10 13:56:32 +00:00
.github markdownlint: add -g option to check_format and fix mdl errors 2021-08-10 08:13:00 +00:00
app spdk_top: fixed incorrect poller stats when pollers are duplicated 2021-11-16 09:06:10 +00:00
doc thread: add spdk_poller_get_id 2021-11-16 09:06:10 +00:00
docker docker: Add virtio traffic generator 2021-10-22 07:02:52 +00:00
dpdk@22e79be44f dpdk: update submodule to allow using meson >= 0.60.0 2021-10-28 16:28:58 +00:00
dpdkbuild dpdkbuild: fix misspelled variable name 2021-11-17 10:58:35 +00:00
examples bdev_fio: use the new bdev_get_zone_id() helper 2021-11-11 23:23:35 +00:00
go go: empty Go package 2018-06-28 18:15:51 +00:00
include idxd: add trace events for OP_SUBMIT and OP_COMPLETE 2021-11-17 10:58:17 +00:00
intel-ipsec-mb@775043b6f7 Commit updating intel-ipsec-mb submodule. 2021-10-14 09:52:39 +00:00
ipsecbuild Makefile: don't override MAKEFLAGS in submake 2020-02-21 09:33:45 +00:00
isa-l@2df39cf5f1 isa-l: update submodule to v2.30.0 2021-01-21 19:24:10 +00:00
isalbuild Makefile: don't override MAKEFLAGS in submake 2020-02-21 09:33:45 +00:00
lib nvme_cuse: Fix NULL pointer dereference triggered by unit test 2021-11-17 10:58:50 +00:00
libvfio-user@46ed1dbd8e libvfio-user: update submodule 2021-08-19 07:17:57 +00:00
mk idxd: add trace events for OP_SUBMIT and OP_COMPLETE 2021-11-17 10:58:17 +00:00
module module/bdev: move the NULL check before dereference 2021-11-17 10:58:30 +00:00
ocf@865d29d0cb Update ocf to 21.6 2021-10-20 07:22:22 +00:00
rpmbuild autobuild: Adjusting crypto build for latest DPDK (21.11) 2021-10-28 07:08:26 +00:00
scripts syscalls.bt: print syscall map every second 2021-11-17 10:58:17 +00:00
shared_lib so_ver: increase all major versions 2021-02-05 14:43:47 +00:00
test pgkdep: Add llvm package 2021-11-17 10:58:43 +00:00
vfiouserbuild libvfio-user: include libvfio-user as a submodule with SPDK 2021-01-21 05:00:18 +00:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore mk: support file extension for executables 2021-03-15 09:29:10 +00:00
.gitmodules libvfio-user: include libvfio-user as a submodule with SPDK 2021-01-21 05:00:18 +00:00
autobuild.sh autobuild: Adjusting crypto build for latest DPDK (21.11) 2021-10-28 07:08:26 +00:00
autopackage.sh rpmbuild: Allow to define custom builddir 2021-06-08 08:18:36 +00:00
autorun_post.py post_process: clearly delineate the beginning os script output. 2020-06-17 07:21:44 +00:00
autorun.sh autobuild: Separate unit tests from autobuild 2021-05-21 12:56:48 +00:00
autotest.sh test/nvmf: Limit number of tests executed under uring job 2021-11-15 12:00:30 +00:00
CHANGELOG.md nvme: add an API to check existing transport type is fabric or not 2021-11-05 00:53:27 +00:00
CONFIG mk: Enable build of mlx5_pci compress PMD 2021-08-16 08:48:31 +00:00
configure configure: Fix DPDK version lookup in case submodule is in use 2021-09-24 07:42:05 +00:00
CONTRIBUTING.md Add CONTRIBUTING.md 2017-09-05 13:25:45 -04:00
deprecation.md markdownlint: enable rule MD025 2021-08-26 19:27:22 +00:00
LICENSE LICENSE: add info about submodules 2021-02-04 08:42:09 +00:00
Makefile build: remove lib/.gitignore 2021-08-17 08:54:30 +00:00
mdl_rules.rb markdownlint: enable rule MD003 2021-09-08 21:53:48 +00:00
README.md README.md: add some additional pointers on setup.sh help 2021-09-30 08:06:02 +00:00

Storage Performance Development Kit

Build Status

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh. The scripts/pkgdep.sh script will automatically install the bare minimum dependencies required to build SPDK. Use --help to see information on installing dependencies for optional components

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./test/unit/unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has been tested on MacOS, Ubuntu 16.04.2 LTS and Ubuntu 18.04.3 LTS with the VirtualBox and Libvirt provider. The VirtualBox Extension Pack or [Vagrant Libvirt] (https://github.com/vagrant-libvirt/vagrant-libvirt) must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

AWS

The following setup is known to work on AWS: Image: Ubuntu 18.04 Before running setup.sh, run modprobe vfio-pci then: DRIVER_OVERRIDE=vfio-pci ./setup.sh

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in the Makefile configuration file in the root of the repository. CONFIG contains the base settings for the configure script. This script generates a new file, mk/config.mk, that contains final build settings. For advanced configuration, there are a number of additional options to configure that may be used, or mk/config.mk can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to mk/config.mk with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overridden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. Note, this includes the ability to build not only from DPDK sources, but also just with the includes and libraries installed via the dpdk and dpdk-devel packages. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the values in mk/config.mk. This can be useful if you, for example, generate a mk/config.mk using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Shared libraries

By default, the build of the SPDK yields static libraries against which the SPDK applications and examples are linked. Configure option --with-shared provides the ability to produce SPDK shared libraries, in addition to the default static ones. Use of this flag also results in the SPDK executables linked to the shared versions of libraries. SPDK shared libraries by default, are located in ./build/lib. This includes the single SPDK shared lib encompassing all of the SPDK static libs (libspdk.so) as well as individual SPDK shared libs corresponding to each of the SPDK static ones.

In order to start a SPDK app linked with SPDK shared libraries, make sure to do the following steps:

  • run ldconfig specifying the directory containing SPDK shared libraries
  • provide proper LD_LIBRARY_PATH

If DPDK shared libraries are used, you may also need to add DPDK shared libraries to LD_LIBRARY_PATH

Linux:

./configure --with-shared
make
ldconfig -v -n ./build/lib
LD_LIBRARY_PATH=./build/lib/:./dpdk/build/lib/ ./build/bin/spdk_tgt

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

There are a lot of other environment variables that can be set to configure setup.sh for advanced users. To see the full list, run:

scripts/setup.sh --help

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activities, please refer to spdk.io