numam-spdk/lib/nvmf
Tomasz Zawadzki 4ea996ce19 nvmf/rdma: dont refer to rtransport when poll_group_create failed
This issue was found by code inspection.
It only occurs when pdk_nvmf_transport_poll_group_create()
itself calls spdk_nvmf_transport_poll_group_destroy().
Other transports at this time do not show this issue.

spdk_nvmf_rdma_poll_group_destroy() depends on
rgroup being assigned a transport, which is only being
done on generic nvmf layer using
spdk_nvmf_transport_poll_group_create()
after successful spdk_nvmf_rdma_poll_group_create().
When failure occurs during create, such assignment was not
performed so any references to rtransport will segfault.

Reported-by: Jacek Kalwas <jacek.kalwas@intel.com>
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Id54482d562bd6d7c71371306cf1de93bc05f4e8a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475002
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com>
2019-11-20 10:01:43 +00:00
..
ctrlr_bdev.c nvme: allow setting of completion queue CDW0 2019-10-24 18:02:38 +00:00
ctrlr_discovery.c nvmf: don't keep a global discovery log page. 2019-09-03 00:30:59 +00:00
ctrlr.c nvmf/ctrlr: Disable in-capsule data transfer for RDMA controllers when dif_insert_or_strip is enabled 2019-10-11 15:36:19 +00:00
fc_ls.c nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00
fc.c nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00
Makefile lib/nvmf: extract RPCs from the subsystem directory 2019-08-21 17:20:28 +00:00
nvmf_fc.h nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00
nvmf_internal.h nvmf/fc: Add listen address support in FC transport 2019-10-17 16:29:04 +00:00
nvmf_rpc.c lib/nvmf: add the nvmf_get_targets rpc. 2019-09-26 15:21:44 +00:00
nvmf.c nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00
rdma.c nvmf/rdma: dont refer to rtransport when poll_group_create failed 2019-11-20 10:01:43 +00:00
subsystem.c nvmf: Use correct error code on bad reservation report command 2019-11-15 18:26:54 +00:00
tcp.c lib/nvmf: Add a new state to wait for the req slot 2019-11-15 20:25:15 +00:00
transport.c nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00
transport.h nvmf: Add context parameter to new_qpair() callback 2019-10-17 16:29:36 +00:00