6b41a08654
Makefile support in DPDK was deprecated and will be removed soon, so switch to the officially supported way of building DPDK - with meson and ninja. Two new tools. Basically, our Makefiles will invoke meson+ninja for DPDK, no other SPDK components are affected. Apparently DPDK wanted to move away from an octopus-like config system and the ideology behind meson configuration is simple now: build everything by default. Some PMDs can be explicitly disabled with meson command line, but all libraries (both static and shared versions) and test apps are built unconditionally. How long does it take to build minimal DPDK with meson? Too much. On my machine half of the total build time is spent on libraries we don't need at all. (I have some hacks up my sleeve to disable building those libraries - see the subsequent patch.) As for the official way of building a minimal DPDK, there was a patch [1] on dpdk mailing list to introduce more specific configuration, but it was rejected: > We talked about this a few times in the past, and it was actually one > of the design goals to _avoid_ replicating the octopus-like config > system of the makefiles. That's because it makes the test matrix > insanely complicated, not to mention the harm to user friendliness, > among other things. > > If someone doesn't want to use a PMD, they can just avoid installing it > - it's simple enough. > > Sorry, but from me it's a very strong NACK. Let's not follow that direction, hack the DPDK build system instead. As for advantages of meson+ninja over Makefiles? I can't find any. It's another build system that does a lot for you with some functions, magic options, and a built-in dependency system. It seems nice if you know the syntax, but it's another component that you need to learn, debug, and possibly find bugs in (there's a lot of github issues open for meson). I would compare it to CMake. As for changes in this patch: rather that explicitly disabling PMDs we don't need, specify a list of PMDs we do need and disable everything else found in ./dpdk/drivers/*. This way we won't have to disable the new PMDs as they're added to DPDK. Meson configuration also sets RTE_EAL_PMD_PATH #define to a valid directory with built PMD shared libs. When it's set, DPDK dynamically loads all shared libraries inside. The drivers there depend on DPDK shared libs and fail to load in static SPDK builds, so we disable them altogether by unsetting RTE_EAL_PMD_PATH in the meson-generated config file - just like DPDK Makefiles did. EAL checks for RTE_EAL_PMD_PATH being empty and skips loading any external PMDs then. We do it for both static and shared libs. We specify all PMDs at build time for now, so there's just no need to load them dynamically. We have three more hacks in our submodule: * disable building dpdk apps by commenting-out a line in dpdk/meson.build * disable building unnecessary libs (build everything that spdk *may* need) * build isa-l compress pmd with `-L[...] -lisal`. DPDK expects to find libisal with pkg-config. We don't want to prepare a pkg-config file, so comment-out a failing check in another meson.build file and provide isa-l through CFLAGS and LDFLAGS. We also need to make some changes to our test/external_code. First of all, -ldpdk is no more. Meson build generates a pkg-config file with all libs, but we'll switch to it in a separate patch - for now just specify all -lrte_ libs one by one. -Wl,--no-as-needed has to be added to some test cases, otherwise rte_mempool_ring isn't loaded. We don't use any APIs from this library, it only has a static constructor that provides a few callbacks used by rte_mempool_create(). Also, since DPDK now builds both static and shared libraries, we need to add -Wl,-Bstatic to force using static libswhere required. It's only needed for DPDK libs, but we use it for SPDK libs as well since there's no harm. As for performance: $ ./configure --enable-debug --with-crypto --with-reduce $ time make -j40 -C dpdkbuild all with meson: real 0m8.287s user 1m7.983s sys 0m10.548s before, with the old DPDK makefiles: real 0m20.232s user 0m55.921s sys 0m16.491s The subsequent builds are much faster too: $ time make -j40 -C dpdkbuild all meson: real 0m0.876s user 0m0.663s sys 0m0.217s makefiles: real 0m10.150s user 0m11.740s sys 0m6.772s [1] http://inbox.dpdk.org/dev/1a07d1cd59d84dce84e56c10fdabf5e5504560a6.camel@debian.org/ Change-Id: Ic65db563014100bafb12e61ee0530cc2ae64401d Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1440 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
147 lines
3.9 KiB
Makefile
147 lines
3.9 KiB
Makefile
#
|
|
# BSD LICENSE
|
|
#
|
|
# Copyright (c) Intel Corporation.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Intel Corporation nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
#
|
|
|
|
S :=
|
|
|
|
SPDK_ROOT_DIR := $(CURDIR)
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
|
|
|
|
DIRS-y += lib
|
|
DIRS-y += module
|
|
DIRS-$(CONFIG_SHARED) += shared_lib
|
|
DIRS-y += app include
|
|
DIRS-$(CONFIG_EXAMPLES) += examples
|
|
DIRS-y += test
|
|
DIRS-$(CONFIG_IPSEC_MB) += ipsecbuild
|
|
DIRS-$(CONFIG_ISAL) += isalbuild
|
|
|
|
.PHONY: all clean $(DIRS-y) include/spdk/config.h mk/config.mk \
|
|
cc_version cxx_version .libs_only_other .ldflags ldflags install \
|
|
uninstall
|
|
|
|
# Workaround for ninja. See dpdkbuild/Makefile
|
|
export MAKE_PID := $(shell echo $$PPID)
|
|
|
|
ifeq ($(SPDK_ROOT_DIR)/lib/env_dpdk,$(CONFIG_ENV))
|
|
ifeq ($(CURDIR)/dpdk/build,$(CONFIG_DPDK_DIR))
|
|
ifneq ($(SKIP_DPDK_BUILD),1)
|
|
DPDKBUILD = dpdkbuild
|
|
DIRS-y += dpdkbuild
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(CONFIG_SHARED),y)
|
|
LIB = shared_lib
|
|
else
|
|
LIB = module
|
|
endif
|
|
|
|
ifeq ($(CONFIG_IPSEC_MB),y)
|
|
LIB += ipsecbuild
|
|
DPDK_DEPS += ipsecbuild
|
|
endif
|
|
|
|
ifeq ($(CONFIG_ISAL),y)
|
|
LIB += isalbuild
|
|
DPDK_DEPS += isalbuild
|
|
endif
|
|
|
|
all: mk/cc.mk $(DIRS-y)
|
|
clean: $(DIRS-y)
|
|
$(Q)rm -f include/spdk/config.h
|
|
$(Q)rm -rf build/bin
|
|
$(Q)rm -rf build/fio
|
|
$(Q)rm -rf build/examples
|
|
$(Q)rm -rf build/include
|
|
|
|
install: all
|
|
$(Q)echo "Installed to $(DESTDIR)$(CONFIG_PREFIX)"
|
|
|
|
uninstall: $(DIRS-y)
|
|
$(Q)echo "Uninstalled spdk"
|
|
|
|
ifneq ($(SKIP_DPDK_BUILD),1)
|
|
dpdkbuild: $(DPDK_DEPS)
|
|
endif
|
|
|
|
lib: $(DPDKBUILD)
|
|
module: lib
|
|
shared_lib: module
|
|
app: $(LIB)
|
|
test: $(LIB)
|
|
examples: $(LIB)
|
|
pkgdep:
|
|
sh ./scripts/pkgdep.sh
|
|
|
|
$(DIRS-y): mk/cc.mk build_dir include/spdk/config.h
|
|
|
|
mk/cc.mk:
|
|
$(Q)echo "Please run configure prior to make"
|
|
false
|
|
|
|
build_dir: mk/cc.mk
|
|
$(Q)mkdir -p build/lib
|
|
$(Q)mkdir -p build/bin
|
|
$(Q)mkdir -p build/fio
|
|
$(Q)mkdir -p build/examples
|
|
$(Q)mkdir -p build/include/spdk
|
|
|
|
include/spdk/config.h: mk/config.mk scripts/genconfig.py
|
|
$(Q)echo "#ifndef SPDK_CONFIG_H" > $@.tmp; \
|
|
echo "#define SPDK_CONFIG_H" >> $@.tmp; \
|
|
scripts/genconfig.py $(MAKEFLAGS) >> $@.tmp; \
|
|
echo "#endif /* SPDK_CONFIG_H */" >> $@.tmp; \
|
|
cmp -s $@.tmp $@ || mv $@.tmp $@ ; \
|
|
rm -f $@.tmp
|
|
|
|
cc_version: mk/cc.mk
|
|
$(Q)echo "SPDK using CC=$(CC)"; $(CC) -v
|
|
|
|
cxx_version: mk/cc.mk
|
|
$(Q)echo "SPDK using CXX=$(CXX)"; $(CXX) -v
|
|
|
|
.libs_only_other:
|
|
$(Q)echo -n '$(SYS_LIBS) '
|
|
$(Q)if [ "$(CONFIG_SHARED)" = "y" ]; then \
|
|
echo -n '-lspdk '; \
|
|
fi
|
|
|
|
.ldflags:
|
|
$(Q)echo -n '$(LDFLAGS) '
|
|
|
|
ldflags: .ldflags .libs_only_other
|
|
$(Q)echo ''
|
|
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.subdirs.mk
|