3f12b5fa1e
We always need to ensure bvdev->bdev is not NULL before accessing it. GET_CONFIG handler was standing out in this matter, causing segfaults when connecting to a vhost block device that went through a bdev hotremove. If the bdev has been hotremoved we'll now report blocksize == 0 and blockcount == 0. From what I checked, QEMU will still expose a virtio-blk device to the VM, but linux (because that's what I checked) won't create a block device for it. Note: The behavior above can be tricky to investigate as neither QEMU nor VM doesn't log any messages about it. We should eventually reject any new connections to a vhost-blk socket with hotremoved bdev, but that's a task for later. Fixes #460 Change-Id: I266257f4b35d07f35ba03adf46cb18425f3cf39a Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/417934 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> |
||
|---|---|---|
| .. | ||
| rte_vhost | ||
| Makefile | ||
| vhost_blk.c | ||
| vhost_internal.h | ||
| vhost_nvme.c | ||
| vhost_rpc.c | ||
| vhost_scsi.c | ||
| vhost.c | ||