975e48ae8a
Using malloc'ed string for string in iSCSI target has caused scan-build error. Maximum size of initiator address is already defined to be MAX_INITIATOR_ADDR, and hence use fixed size string whose size is MAX_INITIATOR_ADDR + 1 for spdk_iscsi_initiator_mask::mask. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Ic39e08986c9377800ce58a1cb5b8401c6b71cf96 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459706 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
82 lines
3.4 KiB
C
82 lines
3.4 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_INIT_GRP_H
|
|
#define SPDK_INIT_GRP_H
|
|
|
|
#include "spdk/conf.h"
|
|
#include "iscsi/iscsi.h"
|
|
#include "iscsi/conn.h"
|
|
|
|
struct spdk_iscsi_initiator_name {
|
|
char name[MAX_INITIATOR_NAME + 1];
|
|
TAILQ_ENTRY(spdk_iscsi_initiator_name) tailq;
|
|
};
|
|
|
|
struct spdk_iscsi_initiator_netmask {
|
|
char mask[MAX_INITIATOR_ADDR + 1];
|
|
TAILQ_ENTRY(spdk_iscsi_initiator_netmask) tailq;
|
|
};
|
|
|
|
struct spdk_iscsi_init_grp {
|
|
int ninitiators;
|
|
TAILQ_HEAD(, spdk_iscsi_initiator_name) initiator_head;
|
|
int nnetmasks;
|
|
TAILQ_HEAD(, spdk_iscsi_initiator_netmask) netmask_head;
|
|
int ref;
|
|
int tag;
|
|
TAILQ_ENTRY(spdk_iscsi_init_grp) tailq;
|
|
};
|
|
|
|
/* SPDK iSCSI Initiator Group management API */
|
|
int spdk_iscsi_init_grp_create_from_initiator_list(int tag,
|
|
int num_initiator_names, char **initiator_names,
|
|
int num_initiator_masks, char **initiator_masks);
|
|
int spdk_iscsi_init_grp_add_initiators_from_initiator_list(int tag,
|
|
int num_initiator_names, char **initiator_names,
|
|
int num_initiator_masks, char **initiator_masks);
|
|
int spdk_iscsi_init_grp_delete_initiators_from_initiator_list(int tag,
|
|
int num_initiator_names, char **initiator_names,
|
|
int num_initiator_masks, char **initiator_masks);
|
|
int spdk_iscsi_init_grp_register(struct spdk_iscsi_init_grp *ig);
|
|
struct spdk_iscsi_init_grp *spdk_iscsi_init_grp_unregister(int tag);
|
|
struct spdk_iscsi_init_grp *spdk_iscsi_init_grp_find_by_tag(int tag);
|
|
void spdk_iscsi_init_grp_destroy(struct spdk_iscsi_init_grp *ig);
|
|
int spdk_iscsi_parse_init_grps(void);
|
|
void spdk_iscsi_init_grps_destroy(void);
|
|
void spdk_iscsi_init_grps_config_text(FILE *fp);
|
|
void spdk_iscsi_init_grps_info_json(struct spdk_json_write_ctx *w);
|
|
void spdk_iscsi_init_grps_config_json(struct spdk_json_write_ctx *w);
|
|
#endif /* SPDK_INIT_GRP_H */
|