7a1c568598
Hotremoving a bdev exposed as a vhost-scsi LUN which
has an allocated io_channel is broken now. By detaching
LUNs from their SCSI devices at the start of LUN
hotremoval, we can end up with the LUN's descriptor
completely leaked.
Upon hotremove, each LUN fires a hotremove_cb to the
upper layer (iscsi/vhost) and starts a poller to
periodically check if lun->io_channel has been closed
already. While iSCSI allocates and frees io_channels
for particular LUNs separately using
spdk_scsi_lun_allocate_io_channel(), vhost allocates
and frees io_channels for the entire SCSI device using
spdk_scsi_dev_free_io_channels(), as it knows there's
only one LUN per SCSI device.
Since LUNs are removed from SCSI devices at the start
of LUN hotremoval, the spdk_scsi_dev_free_io_channels()
is not able to close the io_channel of the child LUN.
That LUN is no longer referenced there, and the function
returns immediately without any error.
By reverting this patch, we practically defer removing
LUN from SCSI device until the bdev descriptor is closed,
that is, until that spdk_scsi_dev_free_io_channels()
and the subsequent spdk_scsi_dev_destruct() in vhost
is called.
Historically, spdk_scsi_lun_free_io_channel() was
introduced after vhost-scsi already supported hotremove,
so before we can introduce a change like this one we
have to refactor vhost to use the new APIs first.
This reverts commit 497997bc60
.
Change-Id: I58a9988a22694f5b5b927173098ac8218270462e
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455371
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
511 lines
12 KiB
C
511 lines
12 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "scsi_internal.h"
|
|
#include "spdk/endian.h"
|
|
#include "spdk/env.h"
|
|
#include "spdk/thread.h"
|
|
#include "spdk/event.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/likely.h"
|
|
|
|
void
|
|
spdk_scsi_lun_complete_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task)
|
|
{
|
|
if (lun) {
|
|
TAILQ_REMOVE(&lun->tasks, task, scsi_link);
|
|
spdk_trace_record(TRACE_SCSI_TASK_DONE, lun->dev->id, 0, (uintptr_t)task, 0);
|
|
}
|
|
task->cpl_fn(task);
|
|
}
|
|
|
|
static void
|
|
scsi_lun_complete_mgmt_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task)
|
|
{
|
|
TAILQ_REMOVE(&lun->mgmt_tasks, task, scsi_link);
|
|
|
|
task->cpl_fn(task);
|
|
|
|
/* Try to execute the first pending mgmt task if it exists. */
|
|
spdk_scsi_lun_execute_mgmt_task(lun);
|
|
}
|
|
|
|
static bool
|
|
scsi_lun_has_outstanding_tasks(struct spdk_scsi_lun *lun)
|
|
{
|
|
return !TAILQ_EMPTY(&lun->tasks);
|
|
}
|
|
|
|
/* Reset task have to wait until all prior outstanding tasks complete. */
|
|
static int
|
|
scsi_lun_reset_check_outstanding_tasks(void *arg)
|
|
{
|
|
struct spdk_scsi_task *task = (struct spdk_scsi_task *)arg;
|
|
struct spdk_scsi_lun *lun = task->lun;
|
|
|
|
if (scsi_lun_has_outstanding_tasks(lun)) {
|
|
return 0;
|
|
}
|
|
spdk_poller_unregister(&lun->reset_poller);
|
|
|
|
scsi_lun_complete_mgmt_task(lun, task);
|
|
return 1;
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_complete_reset_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task)
|
|
{
|
|
if (task->status == SPDK_SCSI_STATUS_GOOD) {
|
|
if (scsi_lun_has_outstanding_tasks(lun)) {
|
|
lun->reset_poller =
|
|
spdk_poller_register(scsi_lun_reset_check_outstanding_tasks,
|
|
task, 10);
|
|
return;
|
|
}
|
|
}
|
|
|
|
scsi_lun_complete_mgmt_task(lun, task);
|
|
}
|
|
|
|
static void
|
|
_scsi_lun_execute_mgmt_task(struct spdk_scsi_lun *lun,
|
|
struct spdk_scsi_task *task)
|
|
{
|
|
TAILQ_INSERT_TAIL(&lun->mgmt_tasks, task, scsi_link);
|
|
|
|
switch (task->function) {
|
|
case SPDK_SCSI_TASK_FUNC_ABORT_TASK:
|
|
task->response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;
|
|
SPDK_ERRLOG("ABORT_TASK failed\n");
|
|
break;
|
|
|
|
case SPDK_SCSI_TASK_FUNC_ABORT_TASK_SET:
|
|
task->response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;
|
|
SPDK_ERRLOG("ABORT_TASK_SET failed\n");
|
|
break;
|
|
|
|
case SPDK_SCSI_TASK_FUNC_LUN_RESET:
|
|
spdk_bdev_scsi_reset(task);
|
|
return;
|
|
|
|
default:
|
|
SPDK_ERRLOG("Unknown Task Management Function!\n");
|
|
/*
|
|
* Task management functions other than those above should never
|
|
* reach this point having been filtered by the frontend. Reject
|
|
* the task as being unsupported.
|
|
*/
|
|
task->response = SPDK_SCSI_TASK_MGMT_RESP_REJECT_FUNC_NOT_SUPPORTED;
|
|
break;
|
|
}
|
|
|
|
scsi_lun_complete_mgmt_task(lun, task);
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_append_mgmt_task(struct spdk_scsi_lun *lun,
|
|
struct spdk_scsi_task *task)
|
|
{
|
|
TAILQ_INSERT_TAIL(&lun->pending_mgmt_tasks, task, scsi_link);
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_execute_mgmt_task(struct spdk_scsi_lun *lun)
|
|
{
|
|
struct spdk_scsi_task *task;
|
|
|
|
if (!TAILQ_EMPTY(&lun->mgmt_tasks)) {
|
|
return;
|
|
}
|
|
|
|
task = TAILQ_FIRST(&lun->pending_mgmt_tasks);
|
|
if (spdk_likely(task == NULL)) {
|
|
/* Try to execute all pending tasks */
|
|
spdk_scsi_lun_execute_tasks(lun);
|
|
return;
|
|
}
|
|
TAILQ_REMOVE(&lun->pending_mgmt_tasks, task, scsi_link);
|
|
|
|
_scsi_lun_execute_mgmt_task(lun, task);
|
|
}
|
|
|
|
static void
|
|
_scsi_lun_execute_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task)
|
|
{
|
|
int rc;
|
|
|
|
task->status = SPDK_SCSI_STATUS_GOOD;
|
|
spdk_trace_record(TRACE_SCSI_TASK_START, lun->dev->id, task->length, (uintptr_t)task, 0);
|
|
TAILQ_INSERT_TAIL(&lun->tasks, task, scsi_link);
|
|
if (!lun->removed) {
|
|
rc = spdk_bdev_scsi_execute(task);
|
|
} else {
|
|
spdk_scsi_task_process_abort(task);
|
|
rc = SPDK_SCSI_TASK_COMPLETE;
|
|
}
|
|
|
|
switch (rc) {
|
|
case SPDK_SCSI_TASK_PENDING:
|
|
break;
|
|
|
|
case SPDK_SCSI_TASK_COMPLETE:
|
|
spdk_scsi_lun_complete_task(lun, task);
|
|
break;
|
|
|
|
default:
|
|
abort();
|
|
}
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_append_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task)
|
|
{
|
|
TAILQ_INSERT_TAIL(&lun->pending_tasks, task, scsi_link);
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_execute_tasks(struct spdk_scsi_lun *lun)
|
|
{
|
|
struct spdk_scsi_task *task, *task_tmp;
|
|
|
|
if (spdk_scsi_lun_has_pending_mgmt_tasks(lun)) {
|
|
/* Pending IO tasks will wait for completion of existing mgmt tasks.
|
|
*/
|
|
return;
|
|
}
|
|
|
|
TAILQ_FOREACH_SAFE(task, &lun->pending_tasks, scsi_link, task_tmp) {
|
|
TAILQ_REMOVE(&lun->pending_tasks, task, scsi_link);
|
|
_scsi_lun_execute_task(lun, task);
|
|
}
|
|
}
|
|
|
|
static void
|
|
scsi_lun_remove(struct spdk_scsi_lun *lun)
|
|
{
|
|
struct spdk_scsi_pr_registrant *reg, *tmp;
|
|
|
|
TAILQ_FOREACH_SAFE(reg, &lun->reg_head, link, tmp) {
|
|
TAILQ_REMOVE(&lun->reg_head, reg, link);
|
|
free(reg);
|
|
}
|
|
spdk_bdev_close(lun->bdev_desc);
|
|
|
|
spdk_scsi_dev_delete_lun(lun->dev, lun);
|
|
free(lun);
|
|
}
|
|
|
|
static int
|
|
scsi_lun_check_io_channel(void *arg)
|
|
{
|
|
struct spdk_scsi_lun *lun = (struct spdk_scsi_lun *)arg;
|
|
|
|
if (lun->io_channel) {
|
|
return -1;
|
|
}
|
|
spdk_poller_unregister(&lun->hotremove_poller);
|
|
|
|
scsi_lun_remove(lun);
|
|
return -1;
|
|
}
|
|
|
|
static void
|
|
scsi_lun_notify_hot_remove(struct spdk_scsi_lun *lun)
|
|
{
|
|
struct spdk_scsi_lun_desc *desc, *tmp;
|
|
|
|
if (lun->hotremove_cb) {
|
|
lun->hotremove_cb(lun, lun->hotremove_ctx);
|
|
}
|
|
|
|
TAILQ_FOREACH_SAFE(desc, &lun->open_descs, link, tmp) {
|
|
if (desc->hotremove_cb) {
|
|
desc->hotremove_cb(lun, desc->hotremove_ctx);
|
|
} else {
|
|
spdk_scsi_lun_close(desc);
|
|
}
|
|
}
|
|
|
|
if (lun->io_channel) {
|
|
lun->hotremove_poller = spdk_poller_register(scsi_lun_check_io_channel,
|
|
lun, 10);
|
|
} else {
|
|
scsi_lun_remove(lun);
|
|
}
|
|
}
|
|
|
|
static int
|
|
scsi_lun_check_pending_tasks(void *arg)
|
|
{
|
|
struct spdk_scsi_lun *lun = (struct spdk_scsi_lun *)arg;
|
|
|
|
if (spdk_scsi_lun_has_pending_tasks(lun) ||
|
|
spdk_scsi_lun_has_pending_mgmt_tasks(lun)) {
|
|
return -1;
|
|
}
|
|
spdk_poller_unregister(&lun->hotremove_poller);
|
|
|
|
scsi_lun_notify_hot_remove(lun);
|
|
return -1;
|
|
}
|
|
|
|
static void
|
|
_scsi_lun_hot_remove(void *arg1)
|
|
{
|
|
struct spdk_scsi_lun *lun = arg1;
|
|
|
|
if (spdk_scsi_lun_has_pending_tasks(lun) ||
|
|
spdk_scsi_lun_has_pending_mgmt_tasks(lun)) {
|
|
lun->hotremove_poller = spdk_poller_register(scsi_lun_check_pending_tasks,
|
|
lun, 10);
|
|
} else {
|
|
scsi_lun_notify_hot_remove(lun);
|
|
}
|
|
}
|
|
|
|
static void
|
|
scsi_lun_hot_remove(void *remove_ctx)
|
|
{
|
|
struct spdk_scsi_lun *lun = (struct spdk_scsi_lun *)remove_ctx;
|
|
struct spdk_thread *thread;
|
|
|
|
if (lun->removed) {
|
|
return;
|
|
}
|
|
|
|
lun->removed = true;
|
|
if (lun->io_channel == NULL) {
|
|
_scsi_lun_hot_remove(lun);
|
|
return;
|
|
}
|
|
|
|
thread = spdk_io_channel_get_thread(lun->io_channel);
|
|
if (thread != spdk_get_thread()) {
|
|
spdk_thread_send_msg(thread, _scsi_lun_hot_remove, lun);
|
|
} else {
|
|
_scsi_lun_hot_remove(lun);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* \brief Constructs a new spdk_scsi_lun object based on the provided parameters.
|
|
*
|
|
* \param bdev bdev associated with this LUN
|
|
*
|
|
* \return NULL if bdev == NULL
|
|
* \return pointer to the new spdk_scsi_lun object otherwise
|
|
*/
|
|
_spdk_scsi_lun *
|
|
spdk_scsi_lun_construct(struct spdk_bdev *bdev,
|
|
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
|
|
void *hotremove_ctx)
|
|
{
|
|
struct spdk_scsi_lun *lun;
|
|
int rc;
|
|
|
|
if (bdev == NULL) {
|
|
SPDK_ERRLOG("bdev must be non-NULL\n");
|
|
return NULL;
|
|
}
|
|
|
|
lun = calloc(1, sizeof(*lun));
|
|
if (lun == NULL) {
|
|
SPDK_ERRLOG("could not allocate lun\n");
|
|
return NULL;
|
|
}
|
|
|
|
rc = spdk_bdev_open(bdev, true, scsi_lun_hot_remove, lun, &lun->bdev_desc);
|
|
|
|
if (rc != 0) {
|
|
SPDK_ERRLOG("bdev %s cannot be opened, error=%d\n", spdk_bdev_get_name(bdev), rc);
|
|
free(lun);
|
|
return NULL;
|
|
}
|
|
|
|
TAILQ_INIT(&lun->tasks);
|
|
TAILQ_INIT(&lun->pending_tasks);
|
|
TAILQ_INIT(&lun->mgmt_tasks);
|
|
TAILQ_INIT(&lun->pending_mgmt_tasks);
|
|
|
|
lun->bdev = bdev;
|
|
lun->io_channel = NULL;
|
|
lun->hotremove_cb = hotremove_cb;
|
|
lun->hotremove_ctx = hotremove_ctx;
|
|
TAILQ_INIT(&lun->open_descs);
|
|
TAILQ_INIT(&lun->reg_head);
|
|
|
|
return lun;
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_destruct(struct spdk_scsi_lun *lun)
|
|
{
|
|
scsi_lun_hot_remove(lun);
|
|
}
|
|
|
|
int
|
|
spdk_scsi_lun_open(struct spdk_scsi_lun *lun, spdk_scsi_lun_remove_cb_t hotremove_cb,
|
|
void *hotremove_ctx, struct spdk_scsi_lun_desc **_desc)
|
|
{
|
|
struct spdk_scsi_lun_desc *desc;
|
|
|
|
desc = calloc(1, sizeof(*desc));
|
|
if (desc == NULL) {
|
|
SPDK_ERRLOG("calloc() failed for LUN descriptor.\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
TAILQ_INSERT_TAIL(&lun->open_descs, desc, link);
|
|
|
|
desc->lun = lun;
|
|
desc->hotremove_cb = hotremove_cb;
|
|
desc->hotremove_ctx = hotremove_ctx;
|
|
*_desc = desc;
|
|
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_close(struct spdk_scsi_lun_desc *desc)
|
|
{
|
|
struct spdk_scsi_lun *lun = desc->lun;
|
|
|
|
TAILQ_REMOVE(&lun->open_descs, desc, link);
|
|
free(desc);
|
|
|
|
assert(!TAILQ_EMPTY(&lun->open_descs) || lun->io_channel == NULL);
|
|
}
|
|
|
|
int
|
|
_spdk_scsi_lun_allocate_io_channel(struct spdk_scsi_lun *lun)
|
|
{
|
|
if (lun->io_channel != NULL) {
|
|
if (spdk_get_thread() == spdk_io_channel_get_thread(lun->io_channel)) {
|
|
lun->ref++;
|
|
return 0;
|
|
}
|
|
SPDK_ERRLOG("io_channel already allocated for lun %s\n",
|
|
spdk_bdev_get_name(lun->bdev));
|
|
return -1;
|
|
}
|
|
|
|
lun->io_channel = spdk_bdev_get_io_channel(lun->bdev_desc);
|
|
if (lun->io_channel == NULL) {
|
|
return -1;
|
|
}
|
|
lun->ref = 1;
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
_spdk_scsi_lun_free_io_channel(struct spdk_scsi_lun *lun)
|
|
{
|
|
if (lun->io_channel == NULL) {
|
|
return;
|
|
}
|
|
|
|
if (spdk_get_thread() != spdk_io_channel_get_thread(lun->io_channel)) {
|
|
SPDK_ERRLOG("io_channel was freed by different thread\n");
|
|
return;
|
|
}
|
|
|
|
lun->ref--;
|
|
if (lun->ref == 0) {
|
|
spdk_put_io_channel(lun->io_channel);
|
|
lun->io_channel = NULL;
|
|
}
|
|
}
|
|
|
|
int
|
|
spdk_scsi_lun_allocate_io_channel(struct spdk_scsi_lun_desc *desc)
|
|
{
|
|
struct spdk_scsi_lun *lun = desc->lun;
|
|
|
|
return _spdk_scsi_lun_allocate_io_channel(lun);
|
|
}
|
|
|
|
void
|
|
spdk_scsi_lun_free_io_channel(struct spdk_scsi_lun_desc *desc)
|
|
{
|
|
struct spdk_scsi_lun *lun = desc->lun;
|
|
|
|
_spdk_scsi_lun_free_io_channel(lun);
|
|
}
|
|
|
|
int
|
|
spdk_scsi_lun_get_id(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return lun->id;
|
|
}
|
|
|
|
const char *
|
|
spdk_scsi_lun_get_bdev_name(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return spdk_bdev_get_name(lun->bdev);
|
|
}
|
|
|
|
const struct spdk_scsi_dev *
|
|
spdk_scsi_lun_get_dev(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return lun->dev;
|
|
}
|
|
|
|
bool
|
|
spdk_scsi_lun_has_pending_mgmt_tasks(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return !TAILQ_EMPTY(&lun->pending_mgmt_tasks) ||
|
|
!TAILQ_EMPTY(&lun->mgmt_tasks);
|
|
}
|
|
|
|
/* This check includes both pending and submitted (outstanding) tasks. */
|
|
bool
|
|
spdk_scsi_lun_has_pending_tasks(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return !TAILQ_EMPTY(&lun->pending_tasks) ||
|
|
!TAILQ_EMPTY(&lun->tasks);
|
|
}
|
|
|
|
bool
|
|
spdk_scsi_lun_is_removing(const struct spdk_scsi_lun *lun)
|
|
{
|
|
return lun->removed;
|
|
}
|
|
|
|
bool
|
|
spdk_scsi_lun_get_dif_ctx(struct spdk_scsi_lun *lun, uint8_t *cdb,
|
|
uint32_t offset, struct spdk_dif_ctx *dif_ctx)
|
|
{
|
|
return spdk_scsi_bdev_get_dif_ctx(lun->bdev, cdb, offset, dif_ctx);
|
|
}
|