2a8065b554
On Windows there has to be a thin layer above the system calls to provide POSIX functionality. When wrapping system calls, the name needs to be prefixed with wpdk_ to ensure that the layer is called. Re-arrange the definitions to facilitate wrapping and prefix with wpdk_ for mingw. For other compilers targeting Windows, the --wrap flag is not supported and the layer above the system calls implements an alternative mechanism to enable the mocking. Tested with $(info LDFLAGS) added to spdk.mock.unittest.mk combined with visual inspection and running the unit tests. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: If00504740229362c40bee4ae171d35489afb2e77 Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6577 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
56 lines
2.2 KiB
Makefile
56 lines
2.2 KiB
Makefile
#
|
|
# BSD LICENSE
|
|
#
|
|
# Copyright (c) Intel Corporation.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Intel Corporation nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
#
|
|
SPDK_MOCK_SYSCALLS = \
|
|
calloc \
|
|
pthread_mutexattr_init \
|
|
pthread_mutex_init \
|
|
recvmsg \
|
|
sendmsg \
|
|
writev
|
|
|
|
define add_wrap_with_prefix
|
|
$(2:%=-Wl,--wrap,$(1)%)
|
|
endef
|
|
|
|
ifeq ($(OS),Windows)
|
|
# Windows needs a thin layer above the system calls to provide POSIX
|
|
# functionality. For GCC, use the prefix wpdk_ to ensure that the layer
|
|
# is called. For other compilers, --wrap is not supported so the layer
|
|
# implements an alternative mechanism to enable mocking.
|
|
ifeq ($(CC_TYPE),gcc)
|
|
LDFLAGS += $(call add_wrap_with_prefix,wpdk_,$(SPDK_MOCK_SYSCALLS))
|
|
endif
|
|
else
|
|
LDFLAGS += $(call add_wrap_with_prefix,,$(SPDK_MOCK_SYSCALLS))
|
|
endif
|